From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1834AC32753 for ; Wed, 14 Aug 2019 20:10:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD97C2084F for ; Wed, 14 Aug 2019 20:09:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="L+Sm00Jg"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="b7YT4qyJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD97C2084F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:Message-ID: In-Reply-To:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ap0kis68LKH+ExjXJYnOjLEZfMz5lfSnkPR69+yIzf4=; b=L+Sm00JgGJMXEs I6Qwvoza/qu2S0b+fmXjOoVGOWQZqjcnJRHmqvl7+x2Hkv0xQ4U/ySXaWnDNiFwRQKQEcGyj5r66O IARlBcpeH3tdXxNnRGPRzzpTatAYnQgA5lVnt/bAIigybkWgQaelQRcJZK7UkfbR0MqZbc1FnzWk4 npGfpXMleDIYdvdWfr4VijB3gfXCCz86r9gk9UE1U1sx2ld8wfhuIIqtvwohcZHYpf4ashcRslpKv wlRWM7MCnp+ZbFCKwENlCST5gGIYA/MBkDz3Y84Ff/PcXJ4iK9AzE96SG3Yh6fk0aNJyKVkubpQGK GnERiS0gyooB2Dc/N18Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hxzaj-0005jh-EI; Wed, 14 Aug 2019 20:09:53 +0000 Received: from mail-oi1-x243.google.com ([2607:f8b0:4864:20::243]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hxzah-0005j5-3n for linux-riscv@lists.infradead.org; Wed, 14 Aug 2019 20:09:52 +0000 Received: by mail-oi1-x243.google.com with SMTP id a21so1568937oie.4 for ; Wed, 14 Aug 2019 13:09:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=paXj73KYL+NWP5ZXUWHWrPw2G6gc8123BvsposI90Bo=; b=b7YT4qyJQvfxELhlzPTrHH9UpVblpaV25D445MXc6bb+UY+fVx/aeZtzluWXnKPiWx jLuBLH/LeBWfVk2g1vd1tse0uAz3PZeuueEbpkgm6PbLhYKVaj+yAg2k81C1vkNNicdw qvYHxRhCDaRSKMdkm+fPpYQQC3GWt3tbevb4ZbBZhQrkKrw4H+lGfyI8INn0MokKpYHm WdkXWh1lOe6hWeYivy4SNAuUIUZ9QlUQniBqy5T/EvAVpq3cqyzEvWIiAtRB0j+6QvEc 3B7eaIFT5XRK23QpfIU+qyWCWEa8Ee3GOwZuianuwIzkJZagOL7JoKMKqcDXbYeKqqmS J/cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=paXj73KYL+NWP5ZXUWHWrPw2G6gc8123BvsposI90Bo=; b=bK9jWyFxc8YO9/gHQx8kg26u1YCHe0m/A7iBcaRHS762W4E1D1HBdRUjFXoqo2sCjs IHuIKq4rYQ4+2xrA9psPHvKt2bY0f173FemjL9c8PN6GdKOKz2W+AvrdF5RxfF1VH0wl rkkuFVwgK+QAeBHyC57zJ8+uGi1XpFPsjxAxogQP8YQzXz/bZojS8oD1kBRA+5dHP1Mq ObkiZUXiS/nfr8dQxGQtgKudDkFHYjg0n4TOl3O7Jxl6kwSleEwYODPJI90mw3PXSbrr E1PDJLm8BKXbh0a55KtEjlgQoiMSeA7txogXb0n2tZ+/t1S7CfDjff4oIe0bOYhZxKkh EXqg== X-Gm-Message-State: APjAAAUylgbVBdO6OysLyW+HkxIut+6FW267SfEsbEUweLF5MSqOQmLl xdNDji8soZ5rFRyEb2dDKipjQg== X-Google-Smtp-Source: APXvYqw1lyPb/CnPlEzGyigLpCsfoIWzRduhjsHvNrNZxuOSSWClhtGRaPdR8iq562gSdVmoVDYHUA== X-Received: by 2002:a02:a503:: with SMTP id e3mr1164929jam.134.1565813389877; Wed, 14 Aug 2019 13:09:49 -0700 (PDT) Received: from localhost (c-73-95-159-87.hsd1.co.comcast.net. [73.95.159.87]) by smtp.gmail.com with ESMTPSA id y25sm1071822iol.59.2019.08.14.13.09.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Aug 2019 13:09:49 -0700 (PDT) Date: Wed, 14 Aug 2019 13:09:48 -0700 (PDT) From: Paul Walmsley X-X-Sender: paulw@viisi.sifive.com To: Logan Gunthorpe Subject: Re: [PATCH v4 2/2] RISC-V: Implement sparsemem In-Reply-To: <26594413-227b-2cc8-0f61-232a6a3907d0@deltatee.com> Message-ID: References: <20190109203911.7887-1-logang@deltatee.com> <0926a261-520e-4c40-f926-ddd40bb8ce44@deltatee.com> <96156909-1453-d487-ff66-a041d67c74d6@deltatee.com> <5506c875-9387-acc9-a7fe-5b7c10036c40@deltatee.com> <0d81412d-73fc-fa56-6f84-dedda72b9cc6@deltatee.com> <26594413-227b-2cc8-0f61-232a6a3907d0@deltatee.com> User-Agent: Alpine 2.21.9999 (DEB 301 2018-08-15) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190814_130951_185873_54D355D1 X-CRM114-Status: GOOD ( 15.36 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Albert Ou , Andrew Waterman , Palmer Dabbelt , Linux Kernel Mailing List , Stephen Bates , Olof Johansson , Greentime Hu , linux-mm@vger.kernel.org, greentime.hu@sifive.com, linux-riscv@lists.infradead.org, Michael Clark , Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Wed, 14 Aug 2019, Logan Gunthorpe wrote: > On 2019-08-14 11:40 a.m., Paul Walmsley wrote: > > On Wed, 14 Aug 2019, Logan Gunthorpe wrote: > > > >> On 2019-08-14 7:35 a.m., Greentime Hu wrote: > >> > >>> Maybe this commit explains why it used HAVE_ARCH_PFN_VALID instead of SPARSEMEM. > >>> https://github.com/torvalds/linux/commit/7b7bf499f79de3f6c85a340c8453a78789523f85 > >>> > >>> BTW, I found another issue here. > >>> #define FIXADDR_TOP (VMALLOC_START) > >>> #define FIXADDR_START (FIXADDR_TOP - FIXADDR_SIZE) > >>> #define VMEMMAP_END (VMALLOC_START - 1) > >>> #define VMEMMAP_START (VMALLOC_START - VMEMMAP_SIZE) > >>> These 2 regions are overlapped. > >>> > >>> How about this fix? Not sure if it is good for everyone. > >> > >> Yes, this looks good to me. I can fold these changes into my patch and > >> send a v5 to the list. > > > > The change to FIXADDR_TOP should be separated out into its own patch - it > > probably needs to go up as a fix. > > I don't think so... VMEMMAP_START doesn't exist until the sparsemem > patch so it can't be changed until after the sparsemem patch and no > sense adding a bug in the sparsemem patch... OK, that's fine then. - Paul _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv