From: Paul Walmsley <paul.walmsley@sifive.com>
To: Mao Han <han_mao@c-sky.com>
Cc: Palmer Dabbelt <palmer@sifive.com>,
linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org,
Guo Ren <guoren@kernel.org>, Greentime Hu <green.hu@gmail.com>,
linux-riscv@lists.infradead.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH V6 2/3] riscv: Add support for perf registers sampling
Date: Wed, 4 Sep 2019 14:22:18 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.9999.1909041420270.13502@viisi.sifive.com> (raw)
In-Reply-To: <0179424c5edc166273d5fe261f70b1a4c13a90f8.1567060834.git.han_mao@c-sky.com>
Hello Mao Han,
On Thu, 29 Aug 2019, Mao Han wrote:
> This patch implements the perf registers sampling and validation API
> for riscv arch. The valid registers and their register ID are defined in
> perf_regs.h. Perf tool can backtrace in userspace with unwind library
> and the registers/user stack dump support.
[ ... ]
> diff --git a/arch/riscv/include/uapi/asm/perf_regs.h b/arch/riscv/include/uapi/asm/perf_regs.h
> new file mode 100644
> index 0000000..df1a581
> --- /dev/null
> +++ b/arch/riscv/include/uapi/asm/perf_regs.h
> @@ -0,0 +1,42 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
All of the other Linux architectures use "GPL-2.0 WITH Linux-syscall-note"
for their license for the perf uapi files. Could you please change this
license string to match the standard Linux practice? Then I think it
should be good to merge.
- Paul
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-09-04 21:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 6:56 [PATCH V6 0/3] riscv: Add perf callchain support Mao Han
2019-08-29 6:57 ` [PATCH V6 1/3] " Mao Han
2019-09-04 19:54 ` Paul Walmsley
2019-09-05 2:30 ` Mao Han
2019-08-29 6:57 ` [PATCH V6 2/3] riscv: Add support for perf registers sampling Mao Han
2019-09-04 21:22 ` Paul Walmsley [this message]
2019-08-29 6:57 ` [PATCH V6 3/3] riscv: Add support for libdw Mao Han
2019-09-04 21:24 ` Paul Walmsley
2019-09-05 2:49 ` Mao Han
2019-09-04 7:25 ` [PATCH V6 0/3] riscv: Add perf callchain support Greentime Hu
2019-09-04 12:20 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.9999.1909041420270.13502@viisi.sifive.com \
--to=paul.walmsley@sifive.com \
--cc=green.hu@gmail.com \
--cc=guoren@kernel.org \
--cc=han_mao@c-sky.com \
--cc=hch@lst.de \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).