From: Paul Walmsley <paul.walmsley@sifive.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Atish Patra <Atish.Patra@wdc.com>,
linux-riscv@lists.infradead.org,
Palmer Dabbelt <palmer@sifive.com>
Subject: Re: [PATCH 3/6] riscv: optimize send_ipi_single
Date: Thu, 5 Sep 2019 01:48:58 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.9999.1909050147020.27305@viisi.sifive.com> (raw)
In-Reply-To: <20190821145837.3686-4-hch@lst.de>
On Wed, 21 Aug 2019, Christoph Hellwig wrote:
> Don't go through send_ipi_mask, but just set the op bit an then pass a
> simple generate hartid mask directly to sbi_send_ipi.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Thanks, I fixed some minor issues in the patch description and queued
the following for v5.4-rc1.
- Paul
From: Christoph Hellwig <hch@lst.de>
Date: Wed, 21 Aug 2019 23:58:34 +0900
Subject: [PATCH] riscv: optimize send_ipi_single
Don't go through send_ipi_mask, but just set the op bit and then pass
a simple generated hartid mask directly to sbi_send_ipi.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Atish Patra <atish.patra@wdc.com>
[paul.walmsley@sifive.com: minor patch description fixes]
Signed-off-by: Paul Walmsley <paul.walmsley@sifive.com>
---
arch/riscv/kernel/smp.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/arch/riscv/kernel/smp.c b/arch/riscv/kernel/smp.c
index 2e21669aa068..a3715d621f60 100644
--- a/arch/riscv/kernel/smp.c
+++ b/arch/riscv/kernel/smp.c
@@ -94,7 +94,13 @@ static void send_ipi_mask(const struct cpumask *mask, enum ipi_message_type op)
static void send_ipi_single(int cpu, enum ipi_message_type op)
{
- send_ipi_mask(cpumask_of(cpu), op);
+ int hartid = cpuid_to_hartid_map(cpu);
+
+ smp_mb__before_atomic();
+ set_bit(op, &ipi_data[cpu].bits);
+ smp_mb__after_atomic();
+
+ sbi_send_ipi(cpumask_bits(cpumask_of(hartid)));
}
static inline void clear_ipi(void)
--
2.23.0
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-09-05 8:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 14:58 misc riscv cleanups Christoph Hellwig
2019-08-21 14:58 ` [PATCH 1/6] riscv: refactor the IPI code Christoph Hellwig
2019-08-24 1:03 ` Atish Patra
2019-09-05 8:44 ` Paul Walmsley
2019-08-21 14:58 ` [PATCH 2/6] riscv: cleanup send_ipi_mask Christoph Hellwig
2019-08-24 0:11 ` Atish Patra
2019-08-26 11:28 ` hch
2019-08-27 18:45 ` Atish Patra
2019-09-05 8:46 ` Paul Walmsley
2019-08-21 14:58 ` [PATCH 3/6] riscv: optimize send_ipi_single Christoph Hellwig
2019-08-24 0:26 ` Atish Patra
2019-08-26 11:29 ` hch
2019-08-27 18:48 ` Atish Patra
2019-09-05 8:48 ` Paul Walmsley [this message]
2019-08-21 14:58 ` [PATCH 4/6] riscv: cleanup riscv_cpuid_to_hartid_mask Christoph Hellwig
2019-08-24 0:03 ` Atish Patra
2019-09-05 8:50 ` Paul Walmsley
2019-08-21 14:58 ` [PATCH 5/6] riscv: don't use the rdtime(h) pseudo-instructions Christoph Hellwig
2019-08-24 0:37 ` Atish Patra
2019-08-24 0:43 ` Atish Patra
2019-08-26 11:30 ` hch
2019-08-27 18:50 ` Atish Patra
2019-09-05 8:55 ` Paul Walmsley
2019-08-21 14:58 ` [PATCH 6/6] riscv: move the TLB flush logic out of line Christoph Hellwig
2019-08-24 0:03 ` Atish Patra
2019-09-05 8:58 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.9999.1909050147020.27305@viisi.sifive.com \
--to=paul.walmsley@sifive.com \
--cc=Atish.Patra@wdc.com \
--cc=hch@lst.de \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).