From: Paul Walmsley <paul.walmsley@sifive.com>
To: Jonathan Corbet <corbet@lwn.net>
Cc: "aou@eecs.berkeley.edu" <aou@eecs.berkeley.edu>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"palmer@sifive.com" <palmer@sifive.com>,
Chester Lin <clin@suse.com>,
"atish.patra@wdc.com" <atish.patra@wdc.com>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>
Subject: Re: [PATCH] riscv-docs: correct the sequence of the magic number 2 since it's little endian
Date: Tue, 1 Oct 2019 11:35:11 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.9999.1910011132280.3732@viisi.sifive.com> (raw)
In-Reply-To: <20191001072212.21d55899@lwn.net>
Hi Jon,
On Tue, 1 Oct 2019, Jonathan Corbet wrote:
> On Mon, 16 Sep 2019 13:01:40 +0000
> Chester Lin <clin@suse.com> wrote:
>
> > Correct the sequence of the magic number 2 since it's little endian.
> >
> > Signed-off-by: Chester Lin <clin@suse.com>
> > ---
> > Documentation/riscv/boot-image-header.txt | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> So I'm slowly digging my way through my docs folder, sorry for the delay.
>
> > diff --git a/Documentation/riscv/boot-image-header.txt b/Documentation/riscv/boot-image-header.txt
> > index 14b1492f689b..f388805aa5c3 100644
> > --- a/Documentation/riscv/boot-image-header.txt
> > +++ b/Documentation/riscv/boot-image-header.txt
> > @@ -18,7 +18,7 @@ The following 64-byte header is present in decompressed Linux kernel image.
> > u32 res1 = 0; /* Reserved */
> > u64 res2 = 0; /* Reserved */
> > u64 magic = 0x5643534952; /* Magic number, little endian, "RISCV" */
> > - u32 magic2 = 0x56534905; /* Magic number 2, little endian, "RSC\x05" */
> > + u32 magic2 = 0x05435352; /* Magic number 2, little endian, "RSC\x05" */
>
> That's doing more than just reordering the bytes. Was the original
> completely wrong? If so, the changelog should probably reflect that. Or
> else what am I missing?
This was simply due to idiocy on my part, due to a very last-minute patch
submission, where I missed that the original documented magic number was
already in little-endian format. The updated number from Chester is
correct.
So,
Reviewed-by: Paul Walmsley <paul.walmsley@sifive.com>
- Paul
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-10-01 18:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-16 13:01 [PATCH] riscv-docs: correct the sequence of the magic number 2 since it's little endian Chester Lin
2019-10-01 13:22 ` Jonathan Corbet
2019-10-01 18:35 ` Paul Walmsley [this message]
2019-10-03 16:52 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.9999.1910011132280.3732@viisi.sifive.com \
--to=paul.walmsley@sifive.com \
--cc=aou@eecs.berkeley.edu \
--cc=atish.patra@wdc.com \
--cc=clin@suse.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).