From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C503ECE58C for ; Wed, 9 Oct 2019 22:26:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 68141206BB for ; Wed, 9 Oct 2019 22:26:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lSEIa5y0"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="FQOgJj4V" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 68141206BB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:Message-ID: In-Reply-To:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eF7S7UoSziIwmujVb/7U1BSgm2RuZ1cMyYCahJ+VMvg=; b=lSEIa5y0aAU5Q8 dG8LcmGBL9bS2SbgaLojvWdax+7QblBtA8bFCkZlw6UU4lsJZBHqs0EPFJyd64JnnT+5lzhjwjfF4 bCgktCCbV0S7EqHADMN8c/ZMkqQXw9ESswn9it5eBJ5V8vHQp+1jnU2XSNExTuCrwQ9YXf5tCnIKG 77ZkWkgQiHHbz6+jApReKPifTrsRpjFQNBuuftK7fr1dLJnLNAS6ihKQvnzhC8PRddISTulDegFmV VZ3iycgad6u70YvY1tJXFGnWQHA7cNds/NfZyMps8hslpf9qPrvzfmOHQy4xcICJwL9C/gcIqGJ4S oh4aJCg+Dh3FuYaub4jw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iIKPP-0003A0-1k; Wed, 09 Oct 2019 22:26:15 +0000 Received: from mail-io1-xd43.google.com ([2607:f8b0:4864:20::d43]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iIKPM-00039N-0v for linux-riscv@lists.infradead.org; Wed, 09 Oct 2019 22:26:13 +0000 Received: by mail-io1-xd43.google.com with SMTP id q1so9160369ion.1 for ; Wed, 09 Oct 2019 15:26:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=xKOBnu3vyrbYs+yVc1anmwNLgo+Dsz1N+1/T+XrPL3k=; b=FQOgJj4V4ewf2GDsATw3jWNrLpUW0sFE/u973EEBTQFtiVoH7SRJCuohbipAkukMqA 1abiZfwsUvdoSGwvZxMP0BrF49aAk2ouUKil790AKTdMw2kdQX1O2gZjJVoEZ3djXQLz 8ezx5SkhZkjYUCLkgM5aYkkR6px7oh8GI9kyakzqwUWaoHFbGT9hWISJ//Ft4tpmldtK cykpw0VAnicKVVeoL1T03V1tpUdsbHN+nyGADuTnesecO5zMOdh1ANnVdUHLUewEGhXY P7iwS51HcCVlyOmJgwXx0Qjb0vrxEvUuCtlb9sWUs3T2fDAIX3raiXKdB8dDVk643P+T 9R9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=xKOBnu3vyrbYs+yVc1anmwNLgo+Dsz1N+1/T+XrPL3k=; b=uId9szwD8djrkMY1pWjBx9oI0bf1h99emp2VdG8WrBk62GtSiW9WWEQ9essK2R8fQq fnFJTQBmCUeeCMMHqjQ4dZ5R7EVo+952w93+A5baPzCRiIom1GU+Qg01MbmqDUDcmqvI JWNrU3/uqP+RjPIVuRv90RrFxXyRks5XZi3QcJuwSV+p6nGwbL3EXS7eKQn+mYhPm+t7 WB0fTz/R/exVFvWXLHdbUoiG4vfyO/uU19zuMr6ti4xaBLekwKflKAjH6KsOJjLh/nfM EQnJFxJ5Ajh1cr2OIM6K6RoDA1/Mvl0vwKG/hJk8MHibyR+enHhVsAfFPLGZnXGfp3i+ N2pg== X-Gm-Message-State: APjAAAUyEDCV/hA+Vnb6Km+WlLJOD2gjm/xAi96mH+cAIaIWcD51cccw bWkzH+Q+IsNkzQ0D814s44O4cA== X-Google-Smtp-Source: APXvYqwWo1rZRGJvvPvWwd6KxxvwdHisWmnYRCVbu8fDLhbDrxEbdGmfv0xWkHUwZxqb9slxmhGw3A== X-Received: by 2002:a02:cd8e:: with SMTP id l14mr5946947jap.30.1570659970360; Wed, 09 Oct 2019 15:26:10 -0700 (PDT) Received: from localhost (c-73-95-159-87.hsd1.co.comcast.net. [73.95.159.87]) by smtp.gmail.com with ESMTPSA id d26sm1856581ioc.16.2019.10.09.15.26.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2019 15:26:09 -0700 (PDT) Date: Wed, 9 Oct 2019 15:26:08 -0700 (PDT) From: Paul Walmsley X-X-Sender: paulw@viisi.sifive.com To: Christoph Hellwig Subject: Re: [PATCH 4/4] riscv: remove the switch statement in do_trap_break() In-Reply-To: <20191007161050.GA20596@infradead.org> Message-ID: References: <1569199517-5884-1-git-send-email-vincent.chen@sifive.com> <1569199517-5884-5-git-send-email-vincent.chen@sifive.com> <20190927224711.GI4700@infradead.org> <20191007161050.GA20596@infradead.org> User-Agent: Alpine 2.21.9999 (DEB 301 2018-08-15) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191009_152612_077053_7AF0FA80 X-CRM114-Status: UNSURE ( 9.33 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vincent Chen , linux-riscv@lists.infradead.org, palmer@sifive.com, linux-kernel@vger.kernel.org, aou@eecs.berkeley.edu Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Mon, 7 Oct 2019, Christoph Hellwig wrote: > On Mon, Oct 07, 2019 at 09:08:23AM -0700, Paul Walmsley wrote: > > force_sig_fault(SIGTRAP, TRAP_BRKPT, > > (void __user *)(regs->sepc)); > > No nee for the extra braces, which also means it all fits onto a single > line. You could have just copied what I pasted.. It turns out that the rewrite breaks allnoconfig: https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org/thread/VDCU2WOB6KQISREO4V5DTXEI2M7VOV55/ Am just going to pick up Vincent's original patch. Then we can do any subsequent cleanup in a separate patch. - Paul _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv