From: Paul Walmsley <paul.walmsley@sifive.com>
To: Greentime Hu <green.hu@gmail.com>
Cc: Greentime Hu <greentime.hu@sifive.com>,
linux-riscv@lists.infradead.org, Guo Ren <guoren@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Mao Han <han_mao@c-sky.com>
Subject: Re: [PATCH v3 5/8] riscv: mark some code and data as file-static
Date: Wed, 23 Oct 2019 15:32:26 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.9999.1910231531480.6074@viisi.sifive.com> (raw)
In-Reply-To: <CAEbi=3dk0R3HMnqsK1mSm2bewecdHm279f9zEq1pHWLPo9tdAg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 617 bytes --]
On Wed, 23 Oct 2019, Greentime Hu wrote:
> Paul Walmsley <paul.walmsley@sifive.com> 於 2019年10月19日 週六 下午3:58寫道：
> >
> > Several functions and arrays which are only used in the files in which
> > they are declared are missing "static" qualifiers. Warnings for these
> > symbols are reported by sparse:
> >
> > arch/riscv/kernel/stacktrace.c:22:14: warning: symbol 'walk_stackframe' was not declared. Should it be static?
[ ... ]
> I think walk_stackframe() could not be static because it will be used
> in perf_callchain.c.
Thanks Greentime - will update the patch.
- Paul
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-10-23 22:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 8:08 [PATCH v3 0/8] riscv: resolve most warnings from sparse Paul Walmsley
2019-10-18 8:08 ` [PATCH v3 1/8] riscv: add prototypes for assembly language functions from entry.S Paul Walmsley
2019-10-18 15:49 ` Christoph Hellwig
2019-10-24 23:59 ` Paul Walmsley
2019-10-18 8:08 ` [PATCH v3 2/8] riscv: add prototypes for assembly language functions from head.S Paul Walmsley
2019-10-18 8:08 ` [PATCH v3 3/8] riscv: init: merge split string literals in preprocessor directive Paul Walmsley
2019-10-18 15:50 ` Christoph Hellwig
2019-10-18 8:08 ` [PATCH v3 4/8] riscv: add missing prototypes Paul Walmsley
2019-10-18 15:54 ` Christoph Hellwig
2019-10-18 8:08 ` [PATCH v3 5/8] riscv: mark some code and data as file-static Paul Walmsley
2019-10-18 15:55 ` Christoph Hellwig
2019-10-23 5:46 ` Greentime Hu
2019-10-23 22:32 ` Paul Walmsley [this message]
2019-10-18 8:08 ` [PATCH v3 6/8] riscv: add missing header file includes Paul Walmsley
2019-10-18 15:55 ` Christoph Hellwig
2019-10-18 8:08 ` [PATCH v3 7/8] riscv: fp: add missing __user pointer annotations Paul Walmsley
2019-10-18 15:56 ` Christoph Hellwig
2019-10-18 8:08 ` [PATCH v3 8/8] riscv: for C functions called only from assembly, mark with __visible Paul Walmsley
2019-10-18 15:56 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.9999.1910231531480.6074@viisi.sifive.com \
--to=paul.walmsley@sifive.com \
--cc=green.hu@gmail.com \
--cc=greentime.hu@sifive.com \
--cc=guoren@kernel.org \
--cc=han_mao@c-sky.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).