From: Paul Walmsley <paul.walmsley@sifive.com>
To: dvyukov@google.com, glider@google.com, aryabinin@virtuozzo.com
Cc: aou@eecs.berkeley.edu, alankao@andestech.com,
Nick Hu <nickhu@andestech.com>,
corbet@lwn.net, gregkh@linuxfoundation.org, palmer@sifive.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
kasan-dev@googlegroups.com, linux-mm@kvack.org,
atish.patra@wdc.com, Anup.Patel@wdc.com, green.hu@gmail.com,
tglx@linutronix.de, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v4 1/3] kasan: No KASAN's memmove check if archs don't have it.
Date: Sat, 16 Nov 2019 20:57:55 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.21.9999.1911162055490.21209@viisi.sifive.com> (raw)
In-Reply-To: <20191028024101.26655-2-nickhu@andestech.com>
Hello Andrey, Alexander, Dmitry,
On Mon, 28 Oct 2019, Nick Hu wrote:
> If archs don't have memmove then the C implementation from lib/string.c is used,
> and then it's instrumented by compiler. So there is no need to add KASAN's
> memmove to manual checks.
>
> Signed-off-by: Nick Hu <nickhu@andestech.com>
If you're happy with this revision of this patch, could you please ack it
so we can merge it as part of the RISC-V KASAN patch set?
Or if you'd prefer to take this patch yourself, please let me know.
- Paul
> ---
> mm/kasan/common.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/mm/kasan/common.c b/mm/kasan/common.c
> index 6814d6d6a023..897f9520bab3 100644
> --- a/mm/kasan/common.c
> +++ b/mm/kasan/common.c
> @@ -107,6 +107,7 @@ void *memset(void *addr, int c, size_t len)
> return __memset(addr, c, len);
> }
>
> +#ifdef __HAVE_ARCH_MEMMOVE
> #undef memmove
> void *memmove(void *dest, const void *src, size_t len)
> {
> @@ -115,6 +116,7 @@ void *memmove(void *dest, const void *src, size_t len)
>
> return __memmove(dest, src, len);
> }
> +#endif
>
> #undef memcpy
> void *memcpy(void *dest, const void *src, size_t len)
> --
> 2.17.0
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
>
- Paul
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-11-17 4:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 2:40 [PATCH v4 0/3] KASAN support for RISC-V Nick Hu
2019-10-28 2:40 ` [PATCH v4 1/3] kasan: No KASAN's memmove check if archs don't have it Nick Hu
2019-11-17 4:57 ` Paul Walmsley [this message]
2019-11-18 8:41 ` Dmitry Vyukov
2019-11-18 16:22 ` Andrey Ryabinin
2019-10-28 2:41 ` [PATCH v4 2/3] riscv: Add KASAN support Nick Hu
2019-10-28 2:41 ` [PATCH v4 3/3] kasan: Add riscv to KASAN documentation Nick Hu
2019-10-28 7:01 ` [PATCH v4 0/3] KASAN support for RISC-V Greentime Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.9999.1911162055490.21209@viisi.sifive.com \
--to=paul.walmsley@sifive.com \
--cc=Anup.Patel@wdc.com \
--cc=alankao@andestech.com \
--cc=aou@eecs.berkeley.edu \
--cc=aryabinin@virtuozzo.com \
--cc=atish.patra@wdc.com \
--cc=corbet@lwn.net \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=green.hu@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kasan-dev@googlegroups.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=nickhu@andestech.com \
--cc=palmer@sifive.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).