From: Paul Walmsley <paul.walmsley@sifive.com>
To: Olof Johansson <olof@lixom.net>
Cc: linux-riscv@lists.infradead.org,
Albert Ou <aou@eecs.berkeley.edu>,
Palmer Dabbelt <palmer@dabbelt.com>,
linux-kernel@vger.kernel.org, hch@lst.de
Subject: Re: [PATCH] riscv: export flush_icache_all to modules
Date: Fri, 20 Dec 2019 03:05:04 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.21.9999.1912200302290.3767@viisi.sifive.com> (raw)
In-Reply-To: <20191217040704.91995-1-olof@lixom.net>
On Mon, 16 Dec 2019, Olof Johansson wrote:
> This is needed by LKDTM (crash dump test module), it calls
> flush_icache_range(), which on RISC-V turns into flush_icache_all(). On
> other architectures, the actual implementation is exported, so follow
> that precedence and export it here too.
>
> Fixes build of CONFIG_LKDTM that fails with:
> ERROR: "flush_icache_all" [drivers/misc/lkdtm/lkdtm.ko] undefined!
In the past we've resisted doing this; see
https://lore.kernel.org/linux-riscv/20190611134945.GA28532@lst.de/
under the principle that we don't want modules to be able to flush the I$
directly via this interface. But maybe, like moving the L2 related code
out of arch/riscv, we should just do it.
- Paul
next prev parent reply other threads:[~2019-12-20 11:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 4:07 [PATCH] riscv: export flush_icache_all to modules Olof Johansson
2019-12-17 11:43 ` Anup Patel
2019-12-20 11:05 ` Paul Walmsley [this message]
2019-12-20 22:29 ` Olof Johansson
2019-12-20 23:00 ` Paul Walmsley
2019-12-28 6:04 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.9999.1912200302290.3767@viisi.sifive.com \
--to=paul.walmsley@sifive.com \
--cc=aou@eecs.berkeley.edu \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=olof@lixom.net \
--cc=palmer@dabbelt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).