From: Paul Walmsley <paul.walmsley@sifive.com>
To: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
linux-riscv@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org, kbuild test robot <lkp@intel.com>
Subject: Re: [PATCH] riscv: fix compile failure with EXPORT_SYMBOL() & !MMU
Date: Fri, 27 Dec 2019 22:04:09 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.21.9999.1912272203260.194339@viisi.sifive.com> (raw)
In-Reply-To: <20191222092604.92217-1-luc.vanoostenryck@gmail.com>
On Sun, 22 Dec 2019, Luc Van Oostenryck wrote:
> When support for !MMU was added, the declaration of
> __asm_copy_to_user() & __asm_copy_from_user() were #ifdefed
> out hence their EXPORT_SYMBOL() give an error message like:
> .../riscv_ksyms.c:13:15: error: '__asm_copy_to_user' undeclared here
> .../riscv_ksyms.c:14:15: error: '__asm_copy_from_user' undeclared here
>
> Since these symbols are not defined with !MMU it's wrong to export them.
> Same for __clear_user() (even though this one is also declared in
> include/asm-generic/uaccess.h and thus doesn't give an error message).
>
> Fix this by doing the EXPORT_SYMBOL() directly where these symbols
> are defined: inside lib/uaccess.S itself.
>
> Fixes 6bd33e1ece528f67646db33bf97406b747dafda0
> Reported-by: kbuild test robot <lkp@intel.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Palmer Dabbelt <palmer@dabbelt.com>
> Cc: Paul Walmsley <paul.walmsley@sifive.com>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Thanks Luc; queued for v5.5-rc.
- Paul
prev parent reply other threads:[~2019-12-28 6:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-22 9:26 [PATCH] riscv: fix compile failure with EXPORT_SYMBOL() & !MMU Luc Van Oostenryck
2019-12-28 6:04 ` Paul Walmsley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.9999.1912272203260.194339@viisi.sifive.com \
--to=paul.walmsley@sifive.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lkp@intel.com \
--cc=luc.vanoostenryck@gmail.com \
--cc=palmer@dabbelt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).