From: Paul Walmsley <paul.walmsley@sifive.com>
To: Olof Johansson <olof@lixom.net>
Cc: Damien Le Moal <damien.lemoal@wdc.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <maz@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>,
Palmer Dabbelt <palmer@dabbelt.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH] riscv: change CSR M/S defines to use "X" for prefix
Date: Tue, 7 Jan 2020 03:15:56 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.21.9999.2001070314050.75790@viisi.sifive.com> (raw)
In-Reply-To: <CAOesGMir810kVTDyoTFuhK-PdFe4J2u2VM+L8jOdO8DghAELQg@mail.gmail.com>
On Fri, 3 Jan 2020, Olof Johansson wrote:
> Sure, this does the job. I'd personally prefer consistent prefixes but
> that's just bikeshed color preferences -- this is fine.
Thanks for the ack. For what it's worth, we're in agreement that we
should prophylactically place RV_ prefixes on the rest of the CSR_ macro
names. I just would prefer that it's done outside the late -rc series,
since it's not technically a fix.
> (Builds are still failing for some configs, but will be fixed if/when
> you pick up https://lore.kernel.org/linux-riscv/20191217040631.91886-1-olof@lixom.net/)
That one is on my radar - just haven't had a chance to review/test it
yet. Thanks for sending that one too!
- Paul
next prev parent reply other threads:[~2020-01-07 11:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 17:06 [PATCH] riscv: change CSR M/S defines to use "X" for prefix Olof Johansson
2019-12-18 18:35 ` Paul Walmsley
2020-01-04 1:28 ` Paul Walmsley
2020-01-04 3:05 ` Olof Johansson
2020-01-07 11:15 ` Paul Walmsley [this message]
2020-01-23 0:22 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.9999.2001070314050.75790@viisi.sifive.com \
--to=paul.walmsley@sifive.com \
--cc=aou@eecs.berkeley.edu \
--cc=damien.lemoal@wdc.com \
--cc=daniel.lezcano@linaro.org \
--cc=hch@lst.de \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=maz@kernel.org \
--cc=olof@lixom.net \
--cc=palmer@dabbelt.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).