From: Paul Walmsley <paul.walmsley@sifive.com>
To: Palmer Dabbelt <palmerdabbelt@google.com>
Cc: Olof Johansson <olof@lixom.net>,
linux-riscv@lists.infradead.org, aou@eecs.berkeley.edu,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] riscv: keep 32-bit kernel to 32-bit phys_addr_t
Date: Fri, 10 Jan 2020 17:14:46 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.21.9999.2001101709090.2113@viisi.sifive.com> (raw)
In-Reply-To: <mhng-d39bd2da-7e27-484a-b8f8-a96edf1336c0@palmerdabbelt-glaptop>
On Fri, 10 Jan 2020, Palmer Dabbelt wrote:
> On Mon, 06 Jan 2020 15:20:24 PST (-0800), Olof Johansson wrote:
> > While rv32 technically has 34-bit physical addresses, no current platforms
> > use it and it's likely to shake out driver bugs.
> >
> > Let's keep 64-bit phys_addr_t off on 32-bit builds until one shows up,
> > since other work will be needed to make such a system useful anyway.
> >
> > PHYS_ADDR_T_64BIT is def_bool 64BIT, so just remove the select.
> >
> > Signed-off-by: Olof Johansson <olof@lixom.net>
> > ---
> >
> > v2: Just remove the select, since it's set by default if CONFIG_64BIT
> >
> > arch/riscv/Kconfig | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> > index a31169b02ec06..569fc6deb94d6 100644
> > --- a/arch/riscv/Kconfig
> > +++ b/arch/riscv/Kconfig
> > @@ -12,8 +12,6 @@ config 32BIT
> >
> > config RISCV
> > def_bool y
> > - # even on 32-bit, physical (and DMA) addresses are > 32-bits
> > - select PHYS_ADDR_T_64BIT
> > select OF
> > select OF_EARLY_FLATTREE
> > select OF_IRQ
>
> I gave 5.5-rc5 a quick test on a 32-bit QEMU with 8GiB of RAM and the system
> wouldn't boot, so we've got at least some bugs floating around somewhere.
> Given that this doesn't work I don't see any reason to keep it around as an
> option, as if someone wants to make it work there's a lot more to do than make
> things compile.
>
> I've put this on for-next. If anyone cares about 34-bit physical addresses on
> rv32 then now is the right time to speak up... ideally by fixing it :)
You know, if, according to
https://freenode.logbot.info/riscv/20200106
the main reason for doing this is to avoid autobuilder warnings, I'd be
tempted to suggest we leave it in there so people have some incentive to
go fix the real bugs ;-)
(that said, the patch is basically okay by me until at least QEMU is
fixed or hardware appears)
- Paul
next prev parent reply other threads:[~2020-01-11 1:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 23:16 [PATCH] riscv: keep 32-bit kernel to 32-bit phys_addr_t Olof Johansson
2020-01-06 23:20 ` [PATCH v2] " Olof Johansson
2020-01-10 21:24 ` Palmer Dabbelt
2020-01-11 1:14 ` Paul Walmsley [this message]
2020-01-11 1:48 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.9999.2001101709090.2113@viisi.sifive.com \
--to=paul.walmsley@sifive.com \
--cc=aou@eecs.berkeley.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=olof@lixom.net \
--cc=palmerdabbelt@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).