From: Paul Walmsley <paul.walmsley@sifive.com>
To: Greentime Hu <greentime.hu@sifive.com>, anup@brainfault.org
Cc: schwab@suse.de, linux-kernel@vger.kernel.org, palmer@dabbelt.com,
green.hu@gmail.com, greentime@kernel.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v4] riscv: make sure the cores stay looping in .Lsecondary_park
Date: Wed, 15 Jan 2020 18:32:55 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.21.9999.2001151832001.98477@viisi.sifive.com> (raw)
In-Reply-To: <20200115065436.7702-1-greentime.hu@sifive.com>
On Wed, 15 Jan 2020, Greentime Hu wrote:
> The code in secondary_park is currently placed in the .init section. The
> kernel reclaims and clears this code when it finishes booting. That
> causes the cores parked in it to go to somewhere unpredictable, so we
> move this function out of init to make sure the cores stay looping there.
>
> The instruction bgeu a0, t0, .Lsecondary_park may have "a relocation
> truncated to fit" issue during linking time. It is because that sections
> are too far to jump. Let's use tail to jump to the .Lsecondary_park.
>
> Signed-off-by: Greentime Hu <greentime.hu@sifive.com>
Thanks, queued for v5.5-rc. Anup's Reviewed-by: has been dropped since
the patch changed significantly - Anup, if you are still happy with it,
please reply with another Reviewed-by:. Thanks,
- Paul
next prev parent reply other threads:[~2020-01-16 2:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 6:54 [PATCH v4] riscv: make sure the cores stay looping in .Lsecondary_park Greentime Hu
2020-01-16 2:32 ` Paul Walmsley [this message]
2020-01-16 4:28 ` Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.9999.2001151832001.98477@viisi.sifive.com \
--to=paul.walmsley@sifive.com \
--cc=anup@brainfault.org \
--cc=green.hu@gmail.com \
--cc=greentime.hu@sifive.com \
--cc=greentime@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).