From: "Maciej W. Rozycki" <macro@wdc.com>
To: "Fāng-ruì Sòng" <maskray@google.com>
Cc: Albert Ou <aou@eecs.berkeley.edu>,
Nick Clifton <nickc@redhat.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Nathan Chancellor <natechancellor@gmail.com>,
linux-riscv@lists.infradead.org
Subject: Re: Upstream binutils commit a87e1817a435dab6c6c042f9306497c9f13d4236 breaks building the RISC-V vDSO
Date: Wed, 22 Jul 2020 22:50:06 +0100 (BST) [thread overview]
Message-ID: <alpine.LFD.2.21.2007222245550.24175@redsun52.ssa.fujisawa.hgst.com> (raw)
In-Reply-To: <CAFP8O3Kf54SYBKMTQDhJ+UwTate7KDszSGG1MwPJc0kTFhqkWw@mail.gmail.com>
On Tue, 16 Jun 2020, F?ng-ru? S?ng wrote:
> > > I suggested that GNU ld from 2.35 onwards disallows accepting ET_EXEC
> > > as input (https://sourceware.org/bugzilla/show_bug.cgi?id=26047 ). The
> > > error message is from the patch.
> > > Taking ET_EXEC files as input are usually errors.
> > >
> > > If we do need to take ET_EXEC as input, we can change e_type in the
> > > ELF header to make the file an ET_REL
> > >
> > > printf '\1' | dd of=${2} conv=notrunc bs=1 seek=16 status=none
> > > (See http://git.kernel.org/linus/90ceddcb495008ac8ba7a3dce297841efcd7d584 )
> >
> > Is there a convenient way to do this in a Makefile? The relevant rule
> > is:
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/riscv/kernel/vdso/Makefile#n63
> >
> > I am not sure if that is strictly necessary, hence the initial email.
> >
> > Cheers,
> > Nathan
>
> If I understand correctly,
>
> $(obj)/vdso-dummy.o:
> ...
> printf '\1' | dd of=$@ conv=notrunc bs=1 seek=16 status=none
>
> should fix the issue. The change can be made along with the migration
> from $(CC) to $(LD). Hope an arch/riscv maintainer can do this.
This is an LD bug in the fix for PR ld/26047, so let's not invent hacks
to work it around. I have filed PR ld/26288 and I'm currently verifying a
fix along with a couple of test cases with the intent to have it all
included with the upcoming binutils 2.35 release currently scheduled this
coming Sat.
Cf. <https://sourceware.org/bugzilla/show_bug.cgi?id=26288>.
Maciej
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2020-07-22 21:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 8:43 Upstream binutils commit a87e1817a435dab6c6c042f9306497c9f13d4236 breaks building the RISC-V vDSO Nathan Chancellor
2020-06-12 15:41 ` Fāng-ruì Sòng
2020-06-17 2:42 ` Nathan Chancellor
2020-06-17 3:34 ` Fāng-ruì Sòng
2020-07-16 4:09 ` Nathan Chancellor
2020-07-22 21:50 ` Maciej W. Rozycki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.2007222245550.24175@redsun52.ssa.fujisawa.hgst.com \
--to=macro@wdc.com \
--cc=aou@eecs.berkeley.edu \
--cc=linux-riscv@lists.infradead.org \
--cc=maskray@google.com \
--cc=natechancellor@gmail.com \
--cc=nickc@redhat.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).