Linux-RISC-V Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] riscv: only select serial sifive if TTY is enabled
@ 2019-10-24  7:20 Kefeng Wang
  2019-10-24 16:12 ` Paul Walmsley
  0 siblings, 1 reply; 4+ messages in thread
From: Kefeng Wang @ 2019-10-24  7:20 UTC (permalink / raw)
  To: Paul Walmsley; +Cc: linux-riscv, Palmer Dabbelt, Kefeng Wang, Albert Ou

There is some warning if TTY is not enabled, and lead to
build error, only select serial sifive if TTY enabled, and
this also makes randconfig happy.

Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
 arch/riscv/Kconfig.socs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs
index 536c0ef4aee8..c1043799e194 100644
--- a/arch/riscv/Kconfig.socs
+++ b/arch/riscv/Kconfig.socs
@@ -2,8 +2,8 @@ menu "SoC selection"
 
 config SOC_SIFIVE
        bool "SiFive SoCs"
-       select SERIAL_SIFIVE
-       select SERIAL_SIFIVE_CONSOLE
+       select SERIAL_SIFIVE if TTY
+       select SERIAL_SIFIVE_CONSOLE if TTY
        select CLK_SIFIVE
        select CLK_SIFIVE_FU540_PRCI
        select SIFIVE_PLIC
-- 
2.20.1


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] riscv: only select serial sifive if TTY is enabled
  2019-10-24  7:20 [PATCH] riscv: only select serial sifive if TTY is enabled Kefeng Wang
@ 2019-10-24 16:12 ` Paul Walmsley
  2019-11-29  6:47   ` Kefeng Wang
  0 siblings, 1 reply; 4+ messages in thread
From: Paul Walmsley @ 2019-10-24 16:12 UTC (permalink / raw)
  To: Kefeng Wang; +Cc: linux-riscv, Palmer Dabbelt, Albert Ou

On Thu, 24 Oct 2019, Kefeng Wang wrote:

> There is some warning if TTY is not enabled, and lead to
> build error, only select serial sifive if TTY enabled, and
> this also makes randconfig happy.
> 
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>

Thanks for doing these randconfig tests!  Queued for v5.4-rc.


- Paul

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] riscv: only select serial sifive if TTY is enabled
  2019-10-24 16:12 ` Paul Walmsley
@ 2019-11-29  6:47   ` Kefeng Wang
  2019-12-09  4:24     ` Paul Walmsley
  0 siblings, 1 reply; 4+ messages in thread
From: Kefeng Wang @ 2019-11-29  6:47 UTC (permalink / raw)
  To: Paul Walmsley; +Cc: linux-riscv, Palmer Dabbelt, Albert Ou



On 2019/10/25 0:12, Paul Walmsley wrote:
> On Thu, 24 Oct 2019, Kefeng Wang wrote:
> 
>> There is some warning if TTY is not enabled, and lead to
>> build error, only select serial sifive if TTY enabled, and
>> this also makes randconfig happy.
>>
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> 
> Thanks for doing these randconfig tests!  Queued for v5.4-rc.

Hi Paul, this patch is not in v5.4 :)

> 
> 
> - Paul
> 
> 


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] riscv: only select serial sifive if TTY is enabled
  2019-11-29  6:47   ` Kefeng Wang
@ 2019-12-09  4:24     ` Paul Walmsley
  0 siblings, 0 replies; 4+ messages in thread
From: Paul Walmsley @ 2019-12-09  4:24 UTC (permalink / raw)
  To: Kefeng Wang; +Cc: linux-riscv, Palmer Dabbelt, Albert Ou

Hi Kefeng Wang,

On Fri, 29 Nov 2019, Kefeng Wang wrote:

> On 2019/10/25 0:12, Paul Walmsley wrote:
> > On Thu, 24 Oct 2019, Kefeng Wang wrote:
> > 
> >> There is some warning if TTY is not enabled, and lead to
> >> build error, only select serial sifive if TTY enabled, and
> >> this also makes randconfig happy.
> >>
> >> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> > 
> > Thanks for doing these randconfig tests!  Queued for v5.4-rc.
> 
> Hi Paul, this patch is not in v5.4 :)

Sorry about that.  I've re-queued it for v5.5-rc.


- Paul


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-24  7:20 [PATCH] riscv: only select serial sifive if TTY is enabled Kefeng Wang
2019-10-24 16:12 ` Paul Walmsley
2019-11-29  6:47   ` Kefeng Wang
2019-12-09  4:24     ` Paul Walmsley

Linux-RISC-V Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-riscv/0 linux-riscv/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-riscv linux-riscv/ https://lore.kernel.org/linux-riscv \
		linux-riscv@lists.infradead.org
	public-inbox-index linux-riscv

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-riscv


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git