From: Colin Ian King <colin.king@canonical.com>
To: Palmer Dabbelt <palmerdabbelt@google.com>,
schwab@suse.de, david.abdurachmanov@gmail.com,
dvyukov@google.com
Cc: linux-riscv@lists.infradead.org, stable@vger.kernel.org
Subject: Re: [PATCH] RISC-V: Double the stack size on rv64
Date: Tue, 14 Jul 2020 09:16:33 +0100 [thread overview]
Message-ID: <bd9d97f6-13c8-2fc3-fe10-97129e2d24de@canonical.com> (raw)
In-Reply-To: <20200714011922.138617-1-palmerdabbelt@google.com>
On 14/07/2020 02:19, Palmer Dabbelt wrote:
> This was suggested in the syzkaller thread as a fix for a bunch of issues. It
> seems in line with what other architectures are doing, and while I haven't
> personally figured out how to reproduce the issues they seem believable enough
> to just change it.
>
> Fixes: 7db91e57a0ac ("RISC-V: Task implementation")
> Cc: stable@vger.kernel.org
> Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
> ---
> I've put this on fixes as I don't see a patch from anyone on that thread, and
> it seems straight-forward enough to just do it. If there's any issues I'm
> happy to listen, otherwise this is going up later this week.
> ---
> arch/riscv/include/asm/thread_info.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/riscv/include/asm/thread_info.h b/arch/riscv/include/asm/thread_info.h
> index 1dd12a0cbb2b..2026076b1d30 100644
> --- a/arch/riscv/include/asm/thread_info.h
> +++ b/arch/riscv/include/asm/thread_info.h
> @@ -12,7 +12,11 @@
> #include <linux/const.h>
>
> /* thread information allocation */
> +#if defined(CONFIG_32BIT)
> #define THREAD_SIZE_ORDER (1)
> +#elif defined(CONFIG_64BIT)
> +#define THREAD_SIZE_ORDER (2)
> +#endif
> #define THREAD_SIZE (PAGE_SIZE << THREAD_SIZE_ORDER)
>
> #ifndef __ASSEMBLY__
>
FWIW, this fixes a gcov issue I was seeing.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2020-07-14 8:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 1:19 [PATCH] RISC-V: Double the stack size on rv64 Palmer Dabbelt
2020-07-14 5:32 ` Andreas Schwab
2020-07-14 21:37 ` Palmer Dabbelt
2020-07-14 8:16 ` Colin Ian King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd9d97f6-13c8-2fc3-fe10-97129e2d24de@canonical.com \
--to=colin.king@canonical.com \
--cc=david.abdurachmanov@gmail.com \
--cc=dvyukov@google.com \
--cc=linux-riscv@lists.infradead.org \
--cc=palmerdabbelt@google.com \
--cc=schwab@suse.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).