From: Vignesh Raghavendra <vigneshr@ti.com>
To: Sagar Shrikant Kadam <sagar.kadam@sifive.com>,
<marek.vasut@gmail.com>, <tudor.ambarus@microchip.com>,
<dwmw2@infradead.org>, <computersforpeace@gmail.com>,
<miquel.raynal@bootlin.com>, <richard@nod.at>
Cc: aou@eecs.berkeley.edu, palmer@sifive.com,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
paul.walmsley@sifive.com, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v7 1/4] mtd: spi-nor: add support for is25wp256
Date: Fri, 9 Aug 2019 17:04:29 +0530 [thread overview]
Message-ID: <c193950a-ddd9-cf8e-0694-eeb91b994729@ti.com> (raw)
In-Reply-To: <1562092745-11541-2-git-send-email-sagar.kadam@sifive.com>
On 03/07/19 12:09 AM, Sagar Shrikant Kadam wrote:
> Update spi_nor_id table for is25wp256 (32MB) device from ISSI,
> present on HiFive Unleashed dev board (Rev: A00).
>
> Set method to enable quad mode for ISSI device in flash parameters
> table.
>
> Based on code originally written by Wesley Terpstra <wesley@sifive.com>
> and/or Palmer Dabbelt <palmer@sifive.com>
> https://github.com/riscv/riscv-linux/commit/c94e267766d62bc9a669611c3d0c8ed5ea26569b
>
> Signed-off-by: Sagar Shrikant Kadam <sagar.kadam@sifive.com>
> ---
Reviewed-by: Vignesh Raghavendra <vigneshr@ti.com>
> drivers/mtd/spi-nor/spi-nor.c | 9 ++++++++-
> include/linux/mtd/spi-nor.h | 1 +
> 2 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index e3a28c0..971f0f3 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -1857,7 +1857,10 @@ static int sr2_bit7_quad_enable(struct spi_nor *nor)
> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> { "is25wp128", INFO(0x9d7018, 0, 64 * 1024, 256,
> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> -
> + { "is25wp256", INFO(0x9d7019, 0, 64 * 1024, 1024,
> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> + SPI_NOR_4B_OPCODES)
> + },
> /* Macronix */
> { "mx25l512e", INFO(0xc22010, 0, 64 * 1024, 1, SECT_4K) },
> { "mx25l2005a", INFO(0xc22012, 0, 64 * 1024, 4, SECT_4K) },
> @@ -3687,6 +3690,10 @@ static int spi_nor_init_params(struct spi_nor *nor,
> case SNOR_MFR_ST:
> case SNOR_MFR_MICRON:
> break;
> + case SNOR_MFR_ISSI:
> + params->quad_enable = macronix_quad_enable;
> + break;
> +
>
> default:
> /* Kept only for backward compatibility purpose. */
> diff --git a/include/linux/mtd/spi-nor.h b/include/linux/mtd/spi-nor.h
> index b3d360b..b0e42b3 100644
> --- a/include/linux/mtd/spi-nor.h
> +++ b/include/linux/mtd/spi-nor.h
> @@ -21,6 +21,7 @@
> #define SNOR_MFR_INTEL CFI_MFR_INTEL
> #define SNOR_MFR_ST CFI_MFR_ST /* ST Micro */
> #define SNOR_MFR_MICRON CFI_MFR_MICRON /* Micron */
> +#define SNOR_MFR_ISSI 0x9d /* ISSI */
> #define SNOR_MFR_MACRONIX CFI_MFR_MACRONIX
> #define SNOR_MFR_SPANSION CFI_MFR_AMD
> #define SNOR_MFR_SST CFI_MFR_SST
>
--
Regards
Vignesh
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-08-09 11:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 18:39 [PATCH v7 0/4] mtd: spi-nor: add support for is25wp256 spi-nor flash Sagar Shrikant Kadam
2019-07-02 18:39 ` [PATCH v7 1/4] mtd: spi-nor: add support for is25wp256 Sagar Shrikant Kadam
2019-08-09 11:34 ` Vignesh Raghavendra [this message]
2019-07-02 18:39 ` [PATCH v7 2/4] mtd: spi-nor: fix nor->addr_width " Sagar Shrikant Kadam
2019-08-09 11:35 ` Vignesh Raghavendra
2019-08-09 14:25 ` Sagar Kadam
2019-07-02 18:39 ` [PATCH v7 3/4] mtd: spi-nor: add support to unlock the flash device Sagar Shrikant Kadam
2019-07-02 18:39 ` [PATCH v7 4/4] mtd: spi-nor: add locking support for is25wp256 device Sagar Shrikant Kadam
2019-08-09 11:27 ` Vignesh Raghavendra
2019-08-09 14:23 ` Sagar Kadam
2019-07-15 10:45 ` [PATCH v7 0/4] mtd: spi-nor: add support for is25wp256 spi-nor flash Sagar Kadam
2019-07-15 11:05 ` Tudor.Ambarus
2019-07-15 11:31 ` Sagar Kadam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c193950a-ddd9-cf8e-0694-eeb91b994729@ti.com \
--to=vigneshr@ti.com \
--cc=aou@eecs.berkeley.edu \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-riscv@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=richard@nod.at \
--cc=sagar.kadam@sifive.com \
--cc=tudor.ambarus@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).