From: Kuldeep Dave <kuldeep.dave@xilinx.com> Enable msi.h generation for pci/pcie irq domain support. The same change has been done by commit 251a44888183 ("riscv: include generic support for MSI irqdomains"). Signed-off-by: Kuldeep Dave <kuldeep.dave@xilinx.com> Signed-off-by: Bharat Kumar Gogada <bharat.kumar.gogada@xilinx.com> Signed-off-by: Michal Simek <michal.simek@xilinx.com> --- arch/microblaze/include/asm/Kbuild | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/microblaze/include/asm/Kbuild b/arch/microblaze/include/asm/Kbuild index e5c9170a07fc..83417105c00a 100644 --- a/arch/microblaze/include/asm/Kbuild +++ b/arch/microblaze/include/asm/Kbuild @@ -25,6 +25,7 @@ generic-y += local64.h generic-y += mcs_spinlock.h generic-y += mm-arch-hooks.h generic-y += mmiowb.h +generic-y += msi.h generic-y += parport.h generic-y += percpu.h generic-y += preempt.h -- 2.17.1 _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
On Tue, Oct 08, 2019 at 12:34:47PM +0200, Michal Simek wrote: > index e5c9170a07fc..83417105c00a 100644 > --- a/arch/microblaze/include/asm/Kbuild > +++ b/arch/microblaze/include/asm/Kbuild > @@ -25,6 +25,7 @@ generic-y += local64.h > generic-y += mcs_spinlock.h > generic-y += mm-arch-hooks.h > generic-y += mmiowb.h > +generic-y += msi.h Please just mark it as mandatory-y in the asm-generic makefile instead of requiring a sniplet for every architecture. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
On 08. 10. 19 17:46, Christoph Hellwig wrote: > On Tue, Oct 08, 2019 at 12:34:47PM +0200, Michal Simek wrote: >> index e5c9170a07fc..83417105c00a 100644 >> --- a/arch/microblaze/include/asm/Kbuild >> +++ b/arch/microblaze/include/asm/Kbuild >> @@ -25,6 +25,7 @@ generic-y += local64.h >> generic-y += mcs_spinlock.h >> generic-y += mm-arch-hooks.h >> generic-y += mmiowb.h >> +generic-y += msi.h > > Please just mark it as mandatory-y in the asm-generic makefile > instead of requiring a sniplet for every architecture. > But is it really mandatory for all architectures? Thanks, Michal _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
On Thu, Oct 10, 2019 at 12:47:31PM +0200, Michal Simek wrote: > On 08. 10. 19 17:46, Christoph Hellwig wrote: > > On Tue, Oct 08, 2019 at 12:34:47PM +0200, Michal Simek wrote: > >> index e5c9170a07fc..83417105c00a 100644 > >> --- a/arch/microblaze/include/asm/Kbuild > >> +++ b/arch/microblaze/include/asm/Kbuild > >> @@ -25,6 +25,7 @@ generic-y += local64.h > >> generic-y += mcs_spinlock.h > >> generic-y += mm-arch-hooks.h > >> generic-y += mmiowb.h > >> +generic-y += msi.h > > > > Please just mark it as mandatory-y in the asm-generic makefile > > instead of requiring a sniplet for every architecture. > > > > But is it really mandatory for all architectures? What the mandatory-y keyword means is that every architecture that doesn't provide its own header gets the default one, which seems applicable here. Maybe the keyword is a bit misnamed and should be default-y or something like that.. But in this case I think we have a clear case of x86 vs the rest, which is unlikely to change in a major way. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
On 15. 10. 19 9:47, Christoph Hellwig wrote: > On Thu, Oct 10, 2019 at 12:47:31PM +0200, Michal Simek wrote: >> On 08. 10. 19 17:46, Christoph Hellwig wrote: >>> On Tue, Oct 08, 2019 at 12:34:47PM +0200, Michal Simek wrote: >>>> index e5c9170a07fc..83417105c00a 100644 >>>> --- a/arch/microblaze/include/asm/Kbuild >>>> +++ b/arch/microblaze/include/asm/Kbuild >>>> @@ -25,6 +25,7 @@ generic-y += local64.h >>>> generic-y += mcs_spinlock.h >>>> generic-y += mm-arch-hooks.h >>>> generic-y += mmiowb.h >>>> +generic-y += msi.h >>> >>> Please just mark it as mandatory-y in the asm-generic makefile >>> instead of requiring a sniplet for every architecture. >>> >> >> But is it really mandatory for all architectures? > > What the mandatory-y keyword means is that every architecture that > doesn't provide its own header gets the default one, which seems > applicable here. Maybe the keyword is a bit misnamed and should be > default-y or something like that.. > > But in this case I think we have a clear case of x86 vs the rest, which > is unlikely to change in a major way. > Bjorn: If you are ok with this I will make the patch. Thanks, Michal _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv