* [PATCH] microblaze: Include generic support for MSI irqdomains
@ 2019-10-08 10:34 Michal Simek
2019-10-08 15:46 ` Christoph Hellwig
0 siblings, 1 reply; 5+ messages in thread
From: Michal Simek @ 2019-10-08 10:34 UTC (permalink / raw)
To: linux-kernel, monstr, michal.simek, git
Cc: Kate Stewart, Kuldeep Dave, Albert Ou, Greg Kroah-Hartman,
Palmer Dabbelt, Masahiro Yamada, Firoz Khan, Paul Walmsley,
Andrew Morton, Will Deacon, linux-riscv
From: Kuldeep Dave <kuldeep.dave@xilinx.com>
Enable msi.h generation for pci/pcie irq domain support.
The same change has been done by commit 251a44888183
("riscv: include generic support for MSI irqdomains").
Signed-off-by: Kuldeep Dave <kuldeep.dave@xilinx.com>
Signed-off-by: Bharat Kumar Gogada <bharat.kumar.gogada@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
arch/microblaze/include/asm/Kbuild | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/microblaze/include/asm/Kbuild b/arch/microblaze/include/asm/Kbuild
index e5c9170a07fc..83417105c00a 100644
--- a/arch/microblaze/include/asm/Kbuild
+++ b/arch/microblaze/include/asm/Kbuild
@@ -25,6 +25,7 @@ generic-y += local64.h
generic-y += mcs_spinlock.h
generic-y += mm-arch-hooks.h
generic-y += mmiowb.h
+generic-y += msi.h
generic-y += parport.h
generic-y += percpu.h
generic-y += preempt.h
--
2.17.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] microblaze: Include generic support for MSI irqdomains 2019-10-08 10:34 [PATCH] microblaze: Include generic support for MSI irqdomains Michal Simek @ 2019-10-08 15:46 ` Christoph Hellwig 2019-10-10 10:47 ` Michal Simek 0 siblings, 1 reply; 5+ messages in thread From: Christoph Hellwig @ 2019-10-08 15:46 UTC (permalink / raw) To: Michal Simek Cc: Kate Stewart, Kuldeep Dave, Albert Ou, Greg Kroah-Hartman, Palmer Dabbelt, monstr, linux-kernel, Masahiro Yamada, Firoz Khan, git, Paul Walmsley, Andrew Morton, Will Deacon, linux-riscv On Tue, Oct 08, 2019 at 12:34:47PM +0200, Michal Simek wrote: > index e5c9170a07fc..83417105c00a 100644 > --- a/arch/microblaze/include/asm/Kbuild > +++ b/arch/microblaze/include/asm/Kbuild > @@ -25,6 +25,7 @@ generic-y += local64.h > generic-y += mcs_spinlock.h > generic-y += mm-arch-hooks.h > generic-y += mmiowb.h > +generic-y += msi.h Please just mark it as mandatory-y in the asm-generic makefile instead of requiring a sniplet for every architecture. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] microblaze: Include generic support for MSI irqdomains 2019-10-08 15:46 ` Christoph Hellwig @ 2019-10-10 10:47 ` Michal Simek 2019-10-15 7:47 ` Christoph Hellwig 0 siblings, 1 reply; 5+ messages in thread From: Michal Simek @ 2019-10-10 10:47 UTC (permalink / raw) To: Christoph Hellwig, Michal Simek Cc: Kate Stewart, Kuldeep Dave, Albert Ou, Greg Kroah-Hartman, Palmer Dabbelt, monstr, linux-kernel, Masahiro Yamada, Firoz Khan, git, Paul Walmsley, Andrew Morton, Will Deacon, linux-riscv On 08. 10. 19 17:46, Christoph Hellwig wrote: > On Tue, Oct 08, 2019 at 12:34:47PM +0200, Michal Simek wrote: >> index e5c9170a07fc..83417105c00a 100644 >> --- a/arch/microblaze/include/asm/Kbuild >> +++ b/arch/microblaze/include/asm/Kbuild >> @@ -25,6 +25,7 @@ generic-y += local64.h >> generic-y += mcs_spinlock.h >> generic-y += mm-arch-hooks.h >> generic-y += mmiowb.h >> +generic-y += msi.h > > Please just mark it as mandatory-y in the asm-generic makefile > instead of requiring a sniplet for every architecture. > But is it really mandatory for all architectures? Thanks, Michal _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] microblaze: Include generic support for MSI irqdomains 2019-10-10 10:47 ` Michal Simek @ 2019-10-15 7:47 ` Christoph Hellwig 2019-10-15 8:46 ` Michal Simek 0 siblings, 1 reply; 5+ messages in thread From: Christoph Hellwig @ 2019-10-15 7:47 UTC (permalink / raw) To: Michal Simek Cc: Kate Stewart, monstr, Albert Ou, linux-kbuild, Greg Kroah-Hartman, Palmer Dabbelt, Kuldeep Dave, linux-kernel, Christoph Hellwig, Masahiro Yamada, Firoz Khan, git, Paul Walmsley, Andrew Morton, Will Deacon, linux-riscv On Thu, Oct 10, 2019 at 12:47:31PM +0200, Michal Simek wrote: > On 08. 10. 19 17:46, Christoph Hellwig wrote: > > On Tue, Oct 08, 2019 at 12:34:47PM +0200, Michal Simek wrote: > >> index e5c9170a07fc..83417105c00a 100644 > >> --- a/arch/microblaze/include/asm/Kbuild > >> +++ b/arch/microblaze/include/asm/Kbuild > >> @@ -25,6 +25,7 @@ generic-y += local64.h > >> generic-y += mcs_spinlock.h > >> generic-y += mm-arch-hooks.h > >> generic-y += mmiowb.h > >> +generic-y += msi.h > > > > Please just mark it as mandatory-y in the asm-generic makefile > > instead of requiring a sniplet for every architecture. > > > > But is it really mandatory for all architectures? What the mandatory-y keyword means is that every architecture that doesn't provide its own header gets the default one, which seems applicable here. Maybe the keyword is a bit misnamed and should be default-y or something like that.. But in this case I think we have a clear case of x86 vs the rest, which is unlikely to change in a major way. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] microblaze: Include generic support for MSI irqdomains 2019-10-15 7:47 ` Christoph Hellwig @ 2019-10-15 8:46 ` Michal Simek 0 siblings, 0 replies; 5+ messages in thread From: Michal Simek @ 2019-10-15 8:46 UTC (permalink / raw) To: Christoph Hellwig, Michal Simek, Bjorn Helgaas Cc: Kate Stewart, Kuldeep Dave, Albert Ou, linux-kbuild, Greg Kroah-Hartman, Palmer Dabbelt, monstr, linux-kernel, Masahiro Yamada, Firoz Khan, git, Paul Walmsley, Andrew Morton, Will Deacon, linux-riscv On 15. 10. 19 9:47, Christoph Hellwig wrote: > On Thu, Oct 10, 2019 at 12:47:31PM +0200, Michal Simek wrote: >> On 08. 10. 19 17:46, Christoph Hellwig wrote: >>> On Tue, Oct 08, 2019 at 12:34:47PM +0200, Michal Simek wrote: >>>> index e5c9170a07fc..83417105c00a 100644 >>>> --- a/arch/microblaze/include/asm/Kbuild >>>> +++ b/arch/microblaze/include/asm/Kbuild >>>> @@ -25,6 +25,7 @@ generic-y += local64.h >>>> generic-y += mcs_spinlock.h >>>> generic-y += mm-arch-hooks.h >>>> generic-y += mmiowb.h >>>> +generic-y += msi.h >>> >>> Please just mark it as mandatory-y in the asm-generic makefile >>> instead of requiring a sniplet for every architecture. >>> >> >> But is it really mandatory for all architectures? > > What the mandatory-y keyword means is that every architecture that > doesn't provide its own header gets the default one, which seems > applicable here. Maybe the keyword is a bit misnamed and should be > default-y or something like that.. > > But in this case I think we have a clear case of x86 vs the rest, which > is unlikely to change in a major way. > Bjorn: If you are ok with this I will make the patch. Thanks, Michal _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-10-15 8:47 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-10-08 10:34 [PATCH] microblaze: Include generic support for MSI irqdomains Michal Simek 2019-10-08 15:46 ` Christoph Hellwig 2019-10-10 10:47 ` Michal Simek 2019-10-15 7:47 ` Christoph Hellwig 2019-10-15 8:46 ` Michal Simek
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).