From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27DC0C19F21 for ; Wed, 27 Jul 2022 10:09:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vYMA89fU1v4Cx4ytQnUa4SURCDlOc2IllrAOPuTjIP8=; b=V0qDOIFrIxRY5B 7nZ7VcITHO6UT8BZutpqu0+6/8/P5kET/S4Adala+2CvyreQaF6mjP8cNt+6fJ0I0fZjSClAaDMN2 ZweZgxOaeW1mlACqagaC56vyUIf/SH5r14zAUWPj25Jm6B2uPmWjTvNEVSlILcGKlOy8RrZ+WJhf4 Lnn35a83EcOaB0Ls+aUC+yBsz145QbnB2AYsEhFm3uh2CCuax7SfWiCJlxTEeBT3/SpUjO1YP4iki GLWlHn6XBQVu1NLErsdf0uDAhZWmzaMa9SxSuHuAZddS1Mg6mCn8JNEw3Ui4lGRCIrjx6/wPqG60Z T9cdF73zZEaX399AlYag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGdym-00CCak-Jo; Wed, 27 Jul 2022 10:09:24 +0000 Received: from mail-lj1-x22f.google.com ([2a00:1450:4864:20::22f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGdyi-00CCSu-Ed for linux-riscv@lists.infradead.org; Wed, 27 Jul 2022 10:09:22 +0000 Received: by mail-lj1-x22f.google.com with SMTP id p22so9457869lji.10 for ; Wed, 27 Jul 2022 03:09:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=uuNq9hfTepHAFE0eywf2hpY8DuWFXCPjA0vLmy+cL2Y=; b=hRcrD6P42aCD0B448rCI9bv5kCUIWCcmpojo29vmyxbcMy0+g4ExD9urSz7AQlk+M2 bNVe7+Fgy1GnWbByGZOQ/Ag/AfwQusPqpUQivmPLeri8o3pvVxTe7EMi01YNxT3qUc4C jzhszp6GFbBBcicGwNz8VkugOOhygffJOIRWId3r4a2SYxyc8DaxP//ODNNZb58zg9+y jCf/U/2IKfLTet7/jk4/aEaI6fTv3BjbjaV23KxqPXJv6symih2qxwqjpwdwg7vN8piS 7uDrnw/TRX1qEJR2ZuADJNf+ws8GxVKI4UxvN3vCARHVmUapPl5CNMtsSz8ukq1d1KDm zFWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=uuNq9hfTepHAFE0eywf2hpY8DuWFXCPjA0vLmy+cL2Y=; b=qGNQwhKztlZzNFyDeoPoLyLikvw/eJEz8CZDpO+O1rKbVsZiYK4+wwKMiUbvaIHy2C XPMZmKJkRIKOphwkG7He/5LNXE3GQ8dXShjR7g95QwSm/BsOWspFy3AZl9GnvzM96da7 SnRJ6HX+stawT5JaZNi8LrzYH8jV3o0UQrcrO7HeKsG3V/ftQcmJyFAl8ZCpQ8y8cD3k Z0LxwbOqQS3XtlATkJPEqPiIY80yYUqrh9UwMiU8iHgblHWJ9T4q84qL+QJHgK6n8R2L RAaOhTMOwZzXuziIGWxcXCT6qOJGmma/W230Vx83tTnukCyAGNd5GLh+jyXojtCmHr5p yhZA== X-Gm-Message-State: AJIora/vKXVG9ytJEDxoTy3s0wiuydUiwiclGkaiJ3y2MJYZKbOVweJZ S4xnYAnQcRGB6vQv4XDLWYkOfg== X-Google-Smtp-Source: AGRyM1suc/PKkW1uyphUiV/vWtNfdbJ3RSHOSpNeADbXVSbYHIolqold/1p4v27Nh3Q/P8gVj9+FVg== X-Received: by 2002:a2e:9193:0:b0:25e:568:6a8a with SMTP id f19-20020a2e9193000000b0025e05686a8amr5303577ljg.166.1658916551822; Wed, 27 Jul 2022 03:09:11 -0700 (PDT) Received: from [192.168.3.197] (78-26-46-173.network.trollfjord.no. [78.26.46.173]) by smtp.gmail.com with ESMTPSA id e14-20020a2e930e000000b0025e0ca6f6b8sm765782ljh.77.2022.07.27.03.09.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Jul 2022 03:09:11 -0700 (PDT) Message-ID: Date: Wed, 27 Jul 2022 12:09:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 4/6] dt-bindings: riscv: Add DT binding documentation for Renesas RZ/Five SoC and SMARC EVK Content-Language: en-US To: "Lad, Prabhakar" Cc: Lad Prabhakar , Geert Uytterhoeven , Magnus Damm , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Anup Patel , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-riscv , LKML , Biju Das References: <20220726180623.1668-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20220726180623.1668-5-prabhakar.mahadev-lad.rj@bp.renesas.com> <636e9214-4b36-e9a6-3c6b-b6edb944335e@linaro.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220727_030921_150831_2C636BC0 X-CRM114-Status: GOOD ( 19.31 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On 27/07/2022 12:06, Lad, Prabhakar wrote: > Hi Krzysztof, > > On Wed, Jul 27, 2022 at 10:54 AM Krzysztof Kozlowski > wrote: >> >> On 27/07/2022 11:05, Lad, Prabhakar wrote: >>> Hi Krzysztof, >>> >>> Thank you for the review. >>> >>> On Wed, Jul 27, 2022 at 9:54 AM Krzysztof Kozlowski >>> wrote: >>>> >>>> On 26/07/2022 20:06, Lad Prabhakar wrote: >>>>> Document Renesas RZ/Five (R9A07G043) SoC and SMARC EVK based on this SoC. >>>>> >>>>> Signed-off-by: Lad Prabhakar >>>>> --- >>>>> .../devicetree/bindings/riscv/renesas.yaml | 49 +++++++++++++++++++ >>>>> 1 file changed, 49 insertions(+) >>>>> create mode 100644 Documentation/devicetree/bindings/riscv/renesas.yaml >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/riscv/renesas.yaml b/Documentation/devicetree/bindings/riscv/renesas.yaml >>>>> new file mode 100644 >>>>> index 000000000000..f72f8aea6a82 >>>>> --- /dev/null >>>>> +++ b/Documentation/devicetree/bindings/riscv/renesas.yaml >>>>> @@ -0,0 +1,49 @@ >>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>>> +%YAML 1.2 >>>>> +--- >>>>> +$id: http://devicetree.org/schemas/riscv/renesas.yaml# >>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>>> + >>>>> +title: Renesas RZ/Five Platform Device Tree Bindings >>>>> + >>>>> +maintainers: >>>>> + - Geert Uytterhoeven >>>>> + - Lad Prabhakar >>>>> + >>>>> +# We want to ignore this schema if the board is SMARC EVK based on ARM64 arch >>>>> +select: >>>>> + not: >>>>> + properties: >>>>> + compatible: >>>>> + contains: >>>>> + items: >>>> >>>> I think you should rather ignore the RiscV SoCs, not specific board. >>>> >>> You mean to ignore ARM/64 SoCs? >>> >>> Agreed just the below enum, should do the trick. >>> >>> - enum: >>> - renesas,r9a07g043u11 >>> - renesas,r9a07g043u12 >>> - renesas,r9a07g044c1 >>> - renesas,r9a07g044c2 >>> - renesas,r9a07g044l1 >>> - renesas,r9a07g044l2 >>> - renesas,r9a07g054l1 >>> - renesas,r9a07g054l2 >>> >>> >>>>> + - const: renesas,smarc-evk >>>>> + - enum: >>>>> + - renesas,r9a07g043u11 >>>>> + - renesas,r9a07g043u12 >>>>> + - renesas,r9a07g044c1 >>>>> + - renesas,r9a07g044c2 >>>>> + - renesas,r9a07g044l1 >>>>> + - renesas,r9a07g044l2 >>>>> + - renesas,r9a07g054l1 >>>>> + - renesas,r9a07g054l2 >>>>> + - enum: >>>>> + - renesas,r9a07g043 >>>>> + - renesas,r9a07g044 >>>>> + - renesas,r9a07g054 >>>> >>>> Did you actually test that it works and properly matches? >>>> >>> Yes I have run the dtbs_check and dt_binding _check for ARM64 and >>> RISC-V. Do you see any cases where it can fail? >> >> >> Just remove the renesas,smarc-evk2 from >> arch/arm64/boot/dts/renesas/r9a07g043u11-smarc.dts. Do you see the >> error? Not from this schema. The only error you will see is that no >> matching schema was found. >> > I did run the dtbs_check test as per your suggestion (below is the > log) and didn't see "no matching schema error" > So you do not see any errors at all. Then it does not work, does it? Best regards, Krzysztof _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv