From: Marc Zyngier <maz@kernel.org>
To: Yash Shah <yash.shah@sifive.com>
Cc: atish.patra@wdc.com, wesley@sifive.com, linus.walleij@linaro.org,
linux-kernel@vger.kernel.org, bgolaszewski@baylibre.com,
palmer@dabbelt.com, sachin.ghadi@sifive.com,
linux-gpio@vger.kernel.org, paul.walmsley@sifive.com,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH] gpio/sifive: fix static checker warning
Date: Tue, 28 Jan 2020 13:21:00 +0000 [thread overview]
Message-ID: <ecb0e9404a3f6256a7ba1fe48b5a1471@kernel.org> (raw)
In-Reply-To: <1580189061-14091-1-git-send-email-yash.shah@sifive.com>
On 2020-01-28 05:24, Yash Shah wrote:
> Typcasting "irq_state" leads to the below static checker warning:
> The fix is to declare "irq_state" as unsigned long instead of u32.
>
> drivers/gpio/gpio-sifive.c:97 sifive_gpio_irq_enable()
> warn: passing casted pointer '&chip->irq_state' to
> 'assign_bit()' 32 vs 64.
>
> Fixes: 96868dce644d ("gpio/sifive: Add GPIO driver for SiFive SoCs")
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Yash Shah <yash.shah@sifive.com>
> ---
> drivers/gpio/gpio-sifive.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpio/gpio-sifive.c b/drivers/gpio/gpio-sifive.c
> index 147a1bd..c54dd08 100644
> --- a/drivers/gpio/gpio-sifive.c
> +++ b/drivers/gpio/gpio-sifive.c
> @@ -35,7 +35,7 @@ struct sifive_gpio {
> void __iomem *base;
> struct gpio_chip gc;
> struct regmap *regs;
> - u32 irq_state;
> + unsigned long irq_state;
> unsigned int trigger[SIFIVE_GPIO_MAX];
> unsigned int irq_parent[SIFIVE_GPIO_MAX];
> };
> @@ -94,7 +94,7 @@ static void sifive_gpio_irq_enable(struct irq_data
> *d)
> spin_unlock_irqrestore(&gc->bgpio_lock, flags);
>
> /* Enable interrupts */
> - assign_bit(offset, (unsigned long *)&chip->irq_state, 1);
> + assign_bit(offset, &chip->irq_state, 1);
> sifive_gpio_set_ie(chip, offset);
> }
>
> @@ -104,7 +104,7 @@ static void sifive_gpio_irq_disable(struct irq_data
> *d)
> struct sifive_gpio *chip = gpiochip_get_data(gc);
> int offset = irqd_to_hwirq(d) % SIFIVE_GPIO_MAX;
>
> - assign_bit(offset, (unsigned long *)&chip->irq_state, 0);
> + assign_bit(offset, &chip->irq_state, 0);
> sifive_gpio_set_ie(chip, offset);
> irq_chip_disable_parent(d);
> }
Yup, nice one. Should have spotted it.
Reviewed-by: Marc Zyngier <maz@kernel.org>
Linus, do you want me to queue this via the irqchip tree (given that
it is where the original bug came from)? Or would you rather take it?
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2020-01-28 13:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-28 5:24 [PATCH] gpio/sifive: fix static checker warning Yash Shah
2020-01-28 13:21 ` Marc Zyngier [this message]
2020-01-29 1:27 ` JaeJoon Jung
2020-01-29 9:12 ` Marc Zyngier
2020-01-29 10:02 ` Linus Walleij
2020-02-10 12:55 ` Linus Walleij
2020-02-10 17:59 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecb0e9404a3f6256a7ba1fe48b5a1471@kernel.org \
--to=maz@kernel.org \
--cc=atish.patra@wdc.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=sachin.ghadi@sifive.com \
--cc=wesley@sifive.com \
--cc=yash.shah@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).