From: Greg Ungerer <gerg@linux-m68k.org>
To: Damien Le Moal <Damien.LeMoal@wdc.com>,
Al Viro <viro@zeniv.linux.org.uk>, Christoph Hellwig <hch@lst.de>
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jcmvbkbc@gmail.com" <jcmvbkbc@gmail.com>,
Anup Patel <Anup.Patel@wdc.com>,
"uclinux-dev@uclinux.org" <uclinux-dev@uclinux.org>
Subject: Re: [PATCH v2 0/2] Fix binfmt_flat loader for RISC-V
Date: Fri, 16 Apr 2021 17:26:27 +1000 [thread overview]
Message-ID: <f407de5f-7799-3e47-c68c-38a2428533aa@linux-m68k.org> (raw)
In-Reply-To: <BL0PR04MB65143E710571C8CE7E7F0FB0E74C9@BL0PR04MB6514.namprd04.prod.outlook.com>
On 16/4/21 10:26 am, Damien Le Moal wrote:
> On 2021/04/16 9:22, Al Viro wrote:
>> On Thu, Apr 15, 2021 at 07:56:05AM +0200, Christoph Hellwig wrote:
>>> binfmt_flat tends to go through Greg's uclinux tree, adding him and
>>> the list.
>>
>> FWIW, my involvement with binfmt_flat had been pretty much nil -
>> the least trivial had been "binfmt_flat: flat_{get,put}_addr_from_rp()
>> should be able to fail" about 4 years ago and that fell out of hunting
>> for places where __get_user() had been used without checking error values.
>>
>> It's in fs/*, but I've no way to test it and I have pretty much
>> zero familiarity with the guts of that one, so I can't give any useful
>> feedback on that series. So consider the Christoph's comment seconded -
>> you want it reviewed by gerg et.al., and it probably ought to go via
>> gerg/uclinux.git tree.
>>
>> I'm reasonably familiar with binfmt_{elf,misc,script}; anything
>> else gets touched as part of larger series and only with sanity checks
>> from other folks, if the changes are not entirely trivial.
>
> Al,
>
> Thanks for the clarification. Would it make sense to have an entry in
> MAINTAINERS file pointing to Greg and the uclinux tree for binfmt_flat.c ?
> Greg ?
Yep, looks like it does need that.
Regards
Greg
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2021-04-16 7:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 15:49 [PATCH v2 0/2] Fix binfmt_flat loader for RISC-V Damien Le Moal
2021-04-07 15:49 ` [PATCH v2 1/2] binfmt_flat: allow not offsetting data start Damien Le Moal
2021-04-07 15:49 ` [PATCH v2 2/2] riscv: Disable text-data gap in flat binaries Damien Le Moal
2021-04-15 0:32 ` [PATCH v2 0/2] Fix binfmt_flat loader for RISC-V Damien Le Moal
2021-04-15 5:46 ` Palmer Dabbelt
2021-04-15 5:56 ` Christoph Hellwig
2021-04-15 6:16 ` Damien Le Moal
2021-04-16 0:21 ` Al Viro
2021-04-16 0:26 ` Damien Le Moal
2021-04-16 7:26 ` Greg Ungerer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f407de5f-7799-3e47-c68c-38a2428533aa@linux-m68k.org \
--to=gerg@linux-m68k.org \
--cc=Anup.Patel@wdc.com \
--cc=Damien.LeMoal@wdc.com \
--cc=hch@lst.de \
--cc=jcmvbkbc@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=uclinux-dev@uclinux.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).