From: Conor Dooley <conor@kernel.org>
To: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Heiko Stuebner <heiko@sntech.de>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-rockchip@lists.infradead.org,
linux-riscv@lists.infradead.org, kernel@collabora.com
Subject: Re: [PATCH v2 06/10] riscv: dts: allwinner: d1: Switch dma-names order for snps,dw-apb-uart nodes
Date: Tue, 21 Mar 2023 22:10:37 +0000 [thread overview]
Message-ID: <f8a9f9e8-d0b0-4336-8d99-8dbe4792b0ff@spud> (raw)
In-Reply-To: <20230321215624.78383-7-cristian.ciocaltea@collabora.com>
[-- Attachment #1.1: Type: text/plain, Size: 2977 bytes --]
On Tue, Mar 21, 2023 at 11:56:20PM +0200, Cristian Ciocaltea wrote:
> Commit 370f696e4474 ("dt-bindings: serial: snps-dw-apb-uart: add dma &
> dma-names properties") documented dma-names property to handle Allwinner
> D1 dtbs_check warnings, but relies on the rx->tx ordering, which is the
> reverse of what a bunch of different boards expect.
>
> The initial proposed solution was to allow a flexible dma-names order in
> the binding, due to potential ABI breakage concerns after fixing the DTS
> files. But luckily the Allwinner boards are not affected, since they are
> using a shared DMA channel for rx and tx.
>
> Hence, the first step in fixing the inconsistency was to change
> dma-names order in the binding to tx->rx.
>
> Do the same for the snps,dw-apb-uart nodes in the DTS file.
>
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
> ---
> arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi b/arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi
> index 951810d46307..922e8e0e2c09 100644
> --- a/arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi
> +++ b/arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi
> @@ -211,7 +211,7 @@ uart0: serial@2500000 {
> clocks = <&ccu CLK_BUS_UART0>;
> resets = <&ccu RST_BUS_UART0>;
> dmas = <&dma 14>, <&dma 14>;
> - dma-names = "rx", "tx";
> + dma-names = "tx", "rx";
> status = "disabled";
> };
>
> @@ -224,7 +224,7 @@ uart1: serial@2500400 {
> clocks = <&ccu CLK_BUS_UART1>;
> resets = <&ccu RST_BUS_UART1>;
> dmas = <&dma 15>, <&dma 15>;
> - dma-names = "rx", "tx";
> + dma-names = "tx", "rx";
> status = "disabled";
> };
>
> @@ -237,7 +237,7 @@ uart2: serial@2500800 {
> clocks = <&ccu CLK_BUS_UART2>;
> resets = <&ccu RST_BUS_UART2>;
> dmas = <&dma 16>, <&dma 16>;
> - dma-names = "rx", "tx";
> + dma-names = "tx", "rx";
> status = "disabled";
> };
>
> @@ -250,7 +250,7 @@ uart3: serial@2500c00 {
> clocks = <&ccu CLK_BUS_UART3>;
> resets = <&ccu RST_BUS_UART3>;
> dmas = <&dma 17>, <&dma 17>;
> - dma-names = "rx", "tx";
> + dma-names = "tx", "rx";
> status = "disabled";
> };
>
> @@ -263,7 +263,7 @@ uart4: serial@2501000 {
> clocks = <&ccu CLK_BUS_UART4>;
> resets = <&ccu RST_BUS_UART4>;
> dmas = <&dma 18>, <&dma 18>;
> - dma-names = "rx", "tx";
> + dma-names = "tx", "rx";
> status = "disabled";
> };
>
> @@ -276,7 +276,7 @@ uart5: serial@2501400 {
> clocks = <&ccu CLK_BUS_UART5>;
> resets = <&ccu RST_BUS_UART5>;
> dmas = <&dma 19>, <&dma 19>;
> - dma-names = "rx", "tx";
> + dma-names = "tx", "rx";
> status = "disabled";
> };
>
> --
> 2.40.0
>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-03-21 22:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 21:56 [PATCH v2 00/10] Enable I2S support for RK3588/RK3588S SoCs Cristian Ciocaltea
2023-03-21 21:56 ` [PATCH v2 01/10] dt-bindings: serial: snps-dw-apb-uart: Switch dma-names order Cristian Ciocaltea
2023-03-21 22:09 ` Conor Dooley
2023-03-21 22:17 ` Cristian Ciocaltea
2023-03-27 15:30 ` Rob Herring
2023-03-21 21:56 ` [PATCH v2 02/10] ARM: dts: sun6i: a31: Switch dma-names order for snps,dw-apb-uart nodes Cristian Ciocaltea
2023-04-08 12:12 ` Jernej Škrabec
2023-03-21 21:56 ` [PATCH v2 03/10] ARM: dts: sun8i: a23/a33: " Cristian Ciocaltea
2023-04-08 12:12 ` Jernej Škrabec
2023-03-21 21:56 ` [PATCH v2 04/10] ARM: dts: sun8i: v3s: " Cristian Ciocaltea
2023-04-08 12:12 ` Jernej Škrabec
2023-03-21 21:56 ` [PATCH v2 05/10] ARM: dts: sunxi: h3/h5: " Cristian Ciocaltea
2023-04-08 12:13 ` Jernej Škrabec
2023-03-21 21:56 ` [PATCH v2 06/10] riscv: dts: allwinner: d1: " Cristian Ciocaltea
2023-03-21 22:10 ` Conor Dooley [this message]
2023-04-08 12:36 ` Jernej Škrabec
2023-04-10 12:25 ` Cristian Ciocaltea
2023-03-21 21:56 ` [PATCH v2 07/10] arm64: dts: rockchip: rk3588s: Move assigned-clocks/assigned-clock-rates out of scmi Cristian Ciocaltea
2023-03-21 21:56 ` [PATCH v2 08/10] arm64: dts: rockchip: rk3588s: Add I2S nodes Cristian Ciocaltea
2023-03-21 21:56 ` [PATCH v2 09/10] arm64: dts: rockchip: rk3588: " Cristian Ciocaltea
2023-03-21 21:56 ` [PATCH v2 10/10] arm64: dts: rockchip: rk3588-rock-5b: Add analog audio Cristian Ciocaltea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8a9f9e8-d0b0-4336-8d99-8dbe4792b0ff@spud \
--to=conor@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=cristian.ciocaltea@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=frattaroli.nicolas@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=jernej.skrabec@gmail.com \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).