From: Palmer Dabbelt <palmer@dabbelt.com>
To: Damien Le Moal <Damien.LeMoal@wdc.com>
Cc: aou@eecs.berkeley.edu, anup@brainfault.org, seanga2@gmail.com,
Atish Patra <Atish.Patra@wdc.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v2] riscv: Set text_offset correctly for M-Mode
Date: Thu, 05 Nov 2020 17:43:47 -0800 (PST) [thread overview]
Message-ID: <mhng-434fbfef-3e4d-4600-a327-50add822cd36@palmerdabbelt-glaptop1> (raw)
In-Reply-To: <BL0PR04MB6514430D1426E3C0CD8A1DC2E71D0@BL0PR04MB6514.namprd04.prod.outlook.com>
On Thu, 22 Oct 2020 16:55:33 PDT (-0700), Damien Le Moal wrote:
>> On 2020/10/23 5:30, Sean Anderson wrote:
>> M-Mode Linux is loaded at the start of RAM, not 2MB later. Perhaps this
>> should be calculated based on PAGE_OFFSET somehow? Even better would be to
>> deprecate text_offset and instead introduce something absolute.
>>
>> Signed-off-by: Sean Anderson <seanga2@gmail.com>
>> ---
>>
>> Changes in v2:
>> - RISCV_S_MODE does not exist; use RISCV_M_MODE instead
>>
>> arch/riscv/kernel/head.S | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/riscv/kernel/head.S b/arch/riscv/kernel/head.S
>> index 0a4e81b8dc79..5a0ae2eaf5e2 100644
>> --- a/arch/riscv/kernel/head.S
>> +++ b/arch/riscv/kernel/head.S
>> @@ -27,12 +27,17 @@ ENTRY(_start)
>> /* reserved */
>> .word 0
>> .balign 8
>> +#ifdef CONFIG_RISCV_M_MODE
>> + /* Image load offset (0MB) from start of RAM for M-mode */
>> + .dword 0
>> +#else
>> #if __riscv_xlen == 64
>> /* Image load offset(2MB) from start of RAM */
>> .dword 0x200000
>> #else
>> /* Image load offset(4MB) from start of RAM */
>> .dword 0x400000
>> #endif
>> +#endif
>> /* Effective size of kernel image */
>> .dword _end - _start
>>
>
> Looks good to me. Added this to my upcoming pile of patches for Kendryte and
> tested. No problems.
>
> Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
> Tested-by: Damien Le Moal <damien.lemoal@wdc.com>
Thanks. This is on fixes.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2020-11-06 1:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 20:30 [PATCH v2] riscv: Set text_offset correctly for M-Mode Sean Anderson
2020-10-22 23:55 ` Damien Le Moal
2020-11-06 1:43 ` Palmer Dabbelt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-434fbfef-3e4d-4600-a327-50add822cd36@palmerdabbelt-glaptop1 \
--to=palmer@dabbelt.com \
--cc=Atish.Patra@wdc.com \
--cc=Damien.LeMoal@wdc.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=linux-riscv@lists.infradead.org \
--cc=paul.walmsley@sifive.com \
--cc=seanga2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).