From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB46BC32753 for ; Wed, 14 Aug 2019 21:29:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 747B82083B for ; Wed, 14 Aug 2019 21:29:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sSjrbtv0"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="kea+s0+E" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 747B82083B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Mime-Version:Message-ID:To:From:In-Reply-To:Subject: Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References:List-Owner; bh=APiLJDb+2tSMbba6f47qHOFrvn7qxnQC/WdRK76u1LM=; b=sSjrbtv0TqgRWYehCrEZnj4+l O8Ikwp4EqcLRvQhGc9UCBqMEKH4G+XFS3xJDjAyyOqYXPvJ+toSiQI5FCf0Mj9abFqy5Yd/w+ixk0 /LlWRYoa3eRYokx27S1H5c7KWgx+0/C4Jclp59soXU7k+vzW4DYimsHGsUpmeMQ6+j+1RpUm91KBM qEzaKc9COfcOnro0JiS9UGtoOeW1JQQkPXjpXliLN1XxATxoGGDE40aMavs6E1g2I7fm+/Fii1vpj J/8HK6W+USw2twxqaPgM06B2D2LgeghR15kjXUir95efqfFd1AXMVYxn54jB/i2UfwfGsySdOsMmn sQtXlmAbw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hy0pn-0000M6-IC; Wed, 14 Aug 2019 21:29:31 +0000 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hy0pk-0000L4-6Z for linux-riscv@lists.infradead.org; Wed, 14 Aug 2019 21:29:29 +0000 Received: by mail-pl1-x643.google.com with SMTP id y1so171933plp.9 for ; Wed, 14 Aug 2019 14:29:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=date:subject:in-reply-to:cc:from:to:message-id:mime-version :content-transfer-encoding; bh=Q0GTf4SXd8ap/7eYvtbqWOyb5FQdhVMHgC+xfCGpXSQ=; b=kea+s0+EM0lH1QLqsZDsOn4sDOH41D3HRfCTW2cUvdWSICMhItatHtT/A6rHXo016S dCgfKALNbA888bZcw0h4uCtKVYxn8NHdwVsxi7iy8+79qiZQP3Q8ch5WvlR/i6L2rNZY sw8fYzM2F4Oby5/oXCn61+X+DqFP6g+PZ8jeCiPzmHzVxyK37+YvHxzJGSbVFpIILVJu ziqN7bbph16MtF6C+mDT0f5G8DI5VnpxilEiIvBPBFEPF+HJRQDwsg4JXnCcrcWRobhm SrxmxBgxMeoP6hfXkBI5tZ/YE+6BXtUTa3ZE8i4LjkqIDfqjv4/L8yLaLE66kGJtU1ez JrJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:subject:in-reply-to:cc:from:to:message-id :mime-version:content-transfer-encoding; bh=Q0GTf4SXd8ap/7eYvtbqWOyb5FQdhVMHgC+xfCGpXSQ=; b=YEQgpLK/Ai0GUc3DahcExfDdtWFJPWmG4NS8X+8avRiD38Iw+yFAf+aLHh06pdU1kX /WFpqhO5oL7oyIv1uxkjebhI1/tjx1nCvzGjMit8aMNsWJrB7HACy7IylJLRLrQinInc Qw6/PHP/vlR5416dP75EXAF+0rEyRROpoOgSSqpqXMFjTgpfkp80dRaStOb68EobPIzk ZrNyOqPFZI8ozJ5/v0dmjxkiJokyiX7Q9uebGbq8tXggRQ1JS+cxEDg40Tae2msQFR1s oHuiD2Y+4FfLKwgERjCNVW4YprDYVhTXAEbx2csuLhdQLsrUykPuhAJbUTU63OhQHktd TUXA== X-Gm-Message-State: APjAAAUavTfTWcBjjw12EepkTTpiuPD8aSAXQv74dvpY1sbYYYdJoCLR tTLaWGDe+q4mNfLJ1N8BJ84RjA== X-Google-Smtp-Source: APXvYqxeC6mQSHmSjfMvx2i1IeIw2IejFV3LJk1NJqcnb3GlKQMqyAZrrRNMCWBC5CwMBN6KMTvnQQ== X-Received: by 2002:a17:902:9a8d:: with SMTP id w13mr1279338plp.157.1565818165383; Wed, 14 Aug 2019 14:29:25 -0700 (PDT) Received: from localhost ([12.206.222.5]) by smtp.gmail.com with ESMTPSA id k5sm709566pjl.32.2019.08.14.14.29.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Aug 2019 14:29:24 -0700 (PDT) Date: Wed, 14 Aug 2019 14:29:24 -0700 (PDT) X-Google-Original-Date: Wed, 14 Aug 2019 14:15:32 PDT (-0700) Subject: Re: [PATCH v2 2/2] riscv: Make __fstate_clean() work correctly. In-Reply-To: From: Palmer Dabbelt To: Paul Walmsley Message-ID: Mime-Version: 1.0 (MHng) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190814_142928_297928_0440D014 X-CRM114-Status: GOOD ( 18.00 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: vincent.chen@sifive.com, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Wed, 14 Aug 2019 13:32:50 PDT (-0700), Paul Walmsley wrote: > On Wed, 14 Aug 2019, Vincent Chen wrote: > >> Make the __fstate_clean() function correctly set the >> state of sstatus.FS in pt_regs to SR_FS_CLEAN. >> >> Fixes: 7db91e5 ("RISC-V: Task implementation") >> Cc: linux-stable >> Signed-off-by: Vincent Chen >> Reviewed-by: Anup Patel >> Reviewed-by: Christoph Hellwig > > Thanks, I extended the "Fixes" commit ID to 12 digits, as is the usual > practice here, and have queued the following for v5.3-rc. For reference, something like "git config core.abbrev=12" (or whatever you write to get this in your .gitconfig) https://github.com/palmer-dabbelt/home/blob/master/.gitconfig.in#L23 causes git to do the right thing. > - Paul > > From: Vincent Chen > Date: Wed, 14 Aug 2019 16:23:53 +0800 > Subject: [PATCH] riscv: Make __fstate_clean() work correctly. > > Make the __fstate_clean() function correctly set the > state of sstatus.FS in pt_regs to SR_FS_CLEAN. > > Fixes: 7db91e57a0acd ("RISC-V: Task implementation") > Cc: linux-stable > Signed-off-by: Vincent Chen > Reviewed-by: Anup Patel > Reviewed-by: Christoph Hellwig > [paul.walmsley@sifive.com: expanded "Fixes" commit ID] > Signed-off-by: Paul Walmsley > --- > arch/riscv/include/asm/switch_to.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/riscv/include/asm/switch_to.h b/arch/riscv/include/asm/switch_to.h > index 949d9cd91dec..f0227bdce0f0 100644 > --- a/arch/riscv/include/asm/switch_to.h > +++ b/arch/riscv/include/asm/switch_to.h > @@ -16,7 +16,7 @@ extern void __fstate_restore(struct task_struct *restore_from); > > static inline void __fstate_clean(struct pt_regs *regs) > { > - regs->sstatus |= (regs->sstatus & ~(SR_FS)) | SR_FS_CLEAN; > + regs->sstatus = (regs->sstatus & ~SR_FS) | SR_FS_CLEAN; > } > > static inline void fstate_off(struct task_struct *task, _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv