From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UPPERCASE_50_75 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4493DC43215 for ; Mon, 2 Dec 2019 23:33:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 19A8920684 for ; Mon, 2 Dec 2019 23:33:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Wth4BNKh"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="VjhqmGAa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 19A8920684 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Mime-Version:Message-ID:To:In-Reply-To:Subject:From: Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References:List-Owner; bh=CWJXKOk/VKYPHK7dBsiWvFXTSiCds0g3Y5WprpaFckE=; b=Wth4BNKhxEpOPouONDZcW+5od Jz0h4RYFEoRWxX8j0Zs0zzXj5ojKcAympc2vtHxd/sPAj2jq5PQZ8Q6nWXXhf4RLCiO2cijZ1aF0p yfMPzx+8wfJsHtmwzP6sjec8oLQaz7D2Ox0ZZeuDAYJHSq4R0el7jMuUzxwfW6InzHBgYwUmvJqw0 VdFnz09qCPr5AuVCpgdFDO6QHHQ5NNVwanzkJhahcVZPrmpgJ5RxZf8gkHnIBnsZR26ByGWVros9P v1n4yXfzT5e0F6Wcne29gVumV4KxjKhCGtpCoZERmXXVeBSUYevfycwg1uLwrnWBCF5/Wa5aaeTv6 h97+6yJzQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ibvBb-0003v5-7B; Mon, 02 Dec 2019 23:32:59 +0000 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ibvBW-0003pK-VL for linux-riscv@lists.infradead.org; Mon, 02 Dec 2019 23:32:56 +0000 Received: by mail-pl1-x644.google.com with SMTP id o9so752220plk.6 for ; Mon, 02 Dec 2019 15:32:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:subject:in-reply-to:cc:to:message-id:mime-version :content-transfer-encoding; bh=6tCx0xpaZr/XSR1WIa5s+CeKR3QHvjhI5hsm121lnno=; b=VjhqmGAa5cXTvDGcC4jNfN/xABhpCNjayFZR6Dk8dqk5MZw05zB+oOBfLgXe5eO+Zt 0BfGJXURBpV6AHJDCduhM999tIzdn9aLv2isJJlWuBj9OgK4tNpXsYHz1i03B5b2snZu 0k7Tab6W+vtM5Ra1ySThKYV0Cz49v+YVhQPKfFvW1w7su2myMlBCkrLSyBetfKnwcfMa FomVlywjj64YJgxbQJTcOysMGMcG1WtSYroZhn0vfwWWAoiDD92MSXXyetFGVY+ygpUN 82PtIiw7BjNpIEVYzcfWLZohCepj35S4pUf+dlOmAFae3IXCPjgQo2BoZ1MH71yCUKKv AVyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:in-reply-to:cc:to:message-id :mime-version:content-transfer-encoding; bh=6tCx0xpaZr/XSR1WIa5s+CeKR3QHvjhI5hsm121lnno=; b=GbsEfuTy/l/gAi3mvT3TsJ6OuW9eNcSMGk/ZkPX+ozCu7Cmf8cWJF/jPEPVP0ntya4 rTISv8CoZR9pOMI1AXUSmbCqmhZ04LjwtcnG4bIpizDhb/SneARBLVEWB8rhve+x9iyG tFk5QOmaOjAyBuND7XyYvbEDAHulVFFNSX34PZJQ3MZYol2HveH6gxT1YCLThBZoYnY3 nPk1fXohYqBxDFqeWFQYtUFpbWFm8DELMFMurOCuDf+M0UjhDPhFBuUXkxNfX0eTtnXo ZLt/vdBL+Rj2l5T69oX1NLSMb8F7/t08L5/bvmDSO4hDWaybkl5uZ4RPvz1ApNcub7ZS 4s+g== X-Gm-Message-State: APjAAAX6MVcnk8Ivf4Dk7U+kF/tFRCmsgdofYOiojpGRiAdvia2ViHg5 sbKtQuBeUJbwwyVU7m24y0gYqQ== X-Google-Smtp-Source: APXvYqydgBmoG6TcLcLG+sVeP6rpWk2NkPEduGd6XFXqGsnsg7Yr2O2DCOQInzRHQ2F7XlDewyDdjA== X-Received: by 2002:a17:902:7607:: with SMTP id k7mr1797761pll.277.1575329571300; Mon, 02 Dec 2019 15:32:51 -0800 (PST) Received: from localhost ([2620:15c:211:200:12cb:e51e:cbf0:6e3f]) by smtp.gmail.com with ESMTPSA id a22sm624843pfk.108.2019.12.02.15.32.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Dec 2019 15:32:50 -0800 (PST) Date: Mon, 02 Dec 2019 15:32:50 -0800 (PST) X-Google-Original-Date: Mon, 02 Dec 2019 15:24:46 PST (-0800) From: Palmer Dabbelt X-Google-Original-From: Palmer Dabbelt Subject: Re: [PATCH 2/4] RISC-V: Enable QEMU virt machine support in defconfigs In-Reply-To: To: Atish Patra Message-ID: Mime-Version: 1.0 (MHng) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191202_153255_007807_2CE20DB0 X-CRM114-Status: GOOD ( 13.03 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: palmer@sifive.com, anup@brainfault.org, Anup Patel , linux-kernel@vger.kernel.org, aou@eecs.berkeley.edu, Alistair Francis , Paul Walmsley , linux-riscv@lists.infradead.org, Christoph Hellwig Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Tue, 26 Nov 2019 11:14:37 PST (-0800), Atish Patra wrote: > On Mon, 2019-11-25 at 13:22 +0000, Anup Patel wrote: >> We have kconfig option for QEMU virt machine so let's enable it >> in RV32 and RV64 defconfigs. >> > > and remove the virt specific configs from defconfig. > > Bit more verbose commit text makes more sense here. > > >> Signed-off-by: Anup Patel >> --- >> arch/riscv/configs/defconfig | 15 +-------------- >> arch/riscv/configs/rv32_defconfig | 16 +--------------- >> 2 files changed, 2 insertions(+), 29 deletions(-) >> >> diff --git a/arch/riscv/configs/defconfig >> b/arch/riscv/configs/defconfig >> index 420a0dbef386..2515fe6417e1 100644 >> --- a/arch/riscv/configs/defconfig >> +++ b/arch/riscv/configs/defconfig >> @@ -15,6 +15,7 @@ CONFIG_BLK_DEV_INITRD=y >> CONFIG_EXPERT=y >> CONFIG_BPF_SYSCALL=y >> CONFIG_SOC_SIFIVE=y >> +CONFIG_SOC_VIRT=y >> CONFIG_SMP=y >> CONFIG_MODULES=y >> CONFIG_MODULE_UNLOAD=y >> @@ -30,7 +31,6 @@ CONFIG_IP_PNP_BOOTP=y >> CONFIG_IP_PNP_RARP=y >> CONFIG_NETLINK_DIAG=y >> CONFIG_NET_9P=y >> -CONFIG_NET_9P_VIRTIO=y >> CONFIG_PCI=y >> CONFIG_PCIEPORTBUS=y >> CONFIG_PCI_HOST_GENERIC=y >> @@ -38,15 +38,12 @@ CONFIG_PCIE_XILINX=y >> CONFIG_DEVTMPFS=y >> CONFIG_DEVTMPFS_MOUNT=y >> CONFIG_BLK_DEV_LOOP=y >> -CONFIG_VIRTIO_BLK=y >> CONFIG_BLK_DEV_SD=y >> CONFIG_BLK_DEV_SR=y >> -CONFIG_SCSI_VIRTIO=y >> CONFIG_ATA=y >> CONFIG_SATA_AHCI=y >> CONFIG_SATA_AHCI_PLATFORM=y >> CONFIG_NETDEVICES=y >> -CONFIG_VIRTIO_NET=y >> CONFIG_MACB=y >> CONFIG_E1000E=y >> CONFIG_R8169=y >> @@ -57,15 +54,12 @@ CONFIG_SERIAL_8250_CONSOLE=y >> CONFIG_SERIAL_OF_PLATFORM=y >> CONFIG_SERIAL_EARLYCON_RISCV_SBI=y >> CONFIG_HVC_RISCV_SBI=y >> -CONFIG_VIRTIO_CONSOLE=y >> CONFIG_HW_RANDOM=y >> -CONFIG_HW_RANDOM_VIRTIO=y >> CONFIG_SPI=y >> CONFIG_SPI_SIFIVE=y >> # CONFIG_PTP_1588_CLOCK is not set >> CONFIG_DRM=y >> CONFIG_DRM_RADEON=y >> -CONFIG_DRM_VIRTIO_GPU=y >> CONFIG_FRAMEBUFFER_CONSOLE=y >> CONFIG_USB=y >> CONFIG_USB_XHCI_HCD=y >> @@ -78,12 +72,6 @@ CONFIG_USB_STORAGE=y >> CONFIG_USB_UAS=y >> CONFIG_MMC=y >> CONFIG_MMC_SPI=y >> -CONFIG_VIRTIO_PCI=y >> -CONFIG_VIRTIO_BALLOON=y >> -CONFIG_VIRTIO_INPUT=y >> -CONFIG_VIRTIO_MMIO=y >> -CONFIG_RPMSG_CHAR=y >> -CONFIG_RPMSG_VIRTIO=y >> CONFIG_EXT4_FS=y >> CONFIG_EXT4_FS_POSIX_ACL=y >> CONFIG_AUTOFS4_FS=y >> @@ -98,6 +86,5 @@ CONFIG_NFS_V4_2=y >> CONFIG_ROOT_NFS=y >> CONFIG_9P_FS=y >> CONFIG_CRYPTO_USER_API_HASH=y >> -CONFIG_CRYPTO_DEV_VIRTIO=y >> CONFIG_PRINTK_TIME=y >> # CONFIG_RCU_TRACE is not set >> diff --git a/arch/riscv/configs/rv32_defconfig >> b/arch/riscv/configs/rv32_defconfig >> index 87ee6e62b64b..bbcf14fd6f40 100644 >> --- a/arch/riscv/configs/rv32_defconfig >> +++ b/arch/riscv/configs/rv32_defconfig >> @@ -14,6 +14,7 @@ CONFIG_CHECKPOINT_RESTORE=y >> CONFIG_BLK_DEV_INITRD=y >> CONFIG_EXPERT=y >> CONFIG_BPF_SYSCALL=y >> +CONFIG_SOC_VIRT=y >> CONFIG_ARCH_RV32I=y >> CONFIG_SMP=y >> CONFIG_MODULES=y >> @@ -30,7 +31,6 @@ CONFIG_IP_PNP_BOOTP=y >> CONFIG_IP_PNP_RARP=y >> CONFIG_NETLINK_DIAG=y >> CONFIG_NET_9P=y >> -CONFIG_NET_9P_VIRTIO=y >> CONFIG_PCI=y >> CONFIG_PCIEPORTBUS=y >> CONFIG_PCI_HOST_GENERIC=y >> @@ -38,15 +38,12 @@ CONFIG_PCIE_XILINX=y >> CONFIG_DEVTMPFS=y >> CONFIG_DEVTMPFS_MOUNT=y >> CONFIG_BLK_DEV_LOOP=y >> -CONFIG_VIRTIO_BLK=y >> CONFIG_BLK_DEV_SD=y >> CONFIG_BLK_DEV_SR=y >> -CONFIG_SCSI_VIRTIO=y >> CONFIG_ATA=y >> CONFIG_SATA_AHCI=y >> CONFIG_SATA_AHCI_PLATFORM=y >> CONFIG_NETDEVICES=y >> -CONFIG_VIRTIO_NET=y >> CONFIG_MACB=y >> CONFIG_E1000E=y >> CONFIG_R8169=y >> @@ -57,13 +54,10 @@ CONFIG_SERIAL_8250_CONSOLE=y >> CONFIG_SERIAL_OF_PLATFORM=y >> CONFIG_SERIAL_EARLYCON_RISCV_SBI=y >> CONFIG_HVC_RISCV_SBI=y >> -CONFIG_VIRTIO_CONSOLE=y >> CONFIG_HW_RANDOM=y >> -CONFIG_HW_RANDOM_VIRTIO=y >> # CONFIG_PTP_1588_CLOCK is not set >> CONFIG_DRM=y >> CONFIG_DRM_RADEON=y >> -CONFIG_DRM_VIRTIO_GPU=y >> CONFIG_FRAMEBUFFER_CONSOLE=y >> CONFIG_USB=y >> CONFIG_USB_XHCI_HCD=y >> @@ -74,13 +68,6 @@ CONFIG_USB_OHCI_HCD=y >> CONFIG_USB_OHCI_HCD_PLATFORM=y >> CONFIG_USB_STORAGE=y >> CONFIG_USB_UAS=y >> -CONFIG_VIRTIO_PCI=y >> -CONFIG_VIRTIO_BALLOON=y >> -CONFIG_VIRTIO_INPUT=y >> -CONFIG_VIRTIO_MMIO=y >> -CONFIG_RPMSG_CHAR=y >> -CONFIG_RPMSG_VIRTIO=y >> -CONFIG_SIFIVE_PLIC=y >> CONFIG_EXT4_FS=y >> CONFIG_EXT4_FS_POSIX_ACL=y >> CONFIG_AUTOFS4_FS=y >> @@ -95,6 +82,5 @@ CONFIG_NFS_V4_2=y >> CONFIG_ROOT_NFS=y >> CONFIG_9P_FS=y >> CONFIG_CRYPTO_USER_API_HASH=y >> -CONFIG_CRYPTO_DEV_VIRTIO=y >> CONFIG_PRINTK_TIME=y >> # CONFIG_RCU_TRACE is not set > > Otherwise, looks good. > > Reviewed-by: Atish Patra Reviewed-by: Palmer Dabbelt _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv