From: Palmer Dabbelt <palmer@sifive.com>
To: nickhu@andestech.com
Cc: kstewart@linuxfoundation.org, aou@eecs.berkeley.edu,
nickhu@andestech.com, alankao@andestech.com, corbet@lwn.net,
Greg KH <gregkh@linuxfoundation.org>,
Anup Patel <Anup.Patel@wdc.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
kasan-dev@googlegroups.com, linux-mm@kvack.org,
alexios.zavras@intel.com, glider@google.com, allison@lohutok.net,
Paul Walmsley <paul.walmsley@sifive.com>,
aryabinin@virtuozzo.com, tglx@linutronix.de,
Atish Patra <Atish.Patra@wdc.com>,
linux-riscv@lists.infradead.org, dvyukov@google.com
Subject: Re: [PATCH v3 1/3] kasan: Archs don't check memmove if not support it.
Date: Wed, 16 Oct 2019 12:23:02 -0700 (PDT) [thread overview]
Message-ID: <mhng-5f3ce9b5-2b64-48d7-a661-7bedf58c50a5@palmer-si-x1e> (raw)
In-Reply-To: <c9fa9eb25a5c0b1f733494dfd439f056c6e938fd.1570514544.git.nickhu@andestech.com>
On Mon, 07 Oct 2019 23:11:51 PDT (-0700), nickhu@andestech.com wrote:
> Skip the memmove checking for those archs who don't support it.
>
> Signed-off-by: Nick Hu <nickhu@andestech.com>
> ---
> mm/kasan/common.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/mm/kasan/common.c b/mm/kasan/common.c
> index 6814d6d6a023..897f9520bab3 100644
> --- a/mm/kasan/common.c
> +++ b/mm/kasan/common.c
> @@ -107,6 +107,7 @@ void *memset(void *addr, int c, size_t len)
> return __memset(addr, c, len);
> }
>
> +#ifdef __HAVE_ARCH_MEMMOVE
> #undef memmove
> void *memmove(void *dest, const void *src, size_t len)
> {
> @@ -115,6 +116,7 @@ void *memmove(void *dest, const void *src, size_t len)
>
> return __memmove(dest, src, len);
> }
> +#endif
>
> #undef memcpy
> void *memcpy(void *dest, const void *src, size_t len)
I think this is backwards: we shouldn't be defining an arch-specific memmove
symbol when KASAN is enabled. If we do it this way then we're defeating the
memmove checks, which doesn't seem like the right way to go.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2019-10-16 19:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 6:11 [PATCH v3 0/3] KASAN support for RISC-V Nick Hu
2019-10-08 6:11 ` [PATCH v3 1/3] kasan: Archs don't check memmove if not support it Nick Hu
2019-10-16 19:23 ` Palmer Dabbelt [this message]
2019-10-17 10:39 ` Andrey Ryabinin
2019-10-18 2:58 ` Paul Walmsley
2019-10-22 2:09 ` Nick Hu
2019-10-08 6:11 ` [PATCH v3 2/3] riscv: Add KASAN support Nick Hu
2019-10-21 9:33 ` Greentime Hu
2019-10-22 3:30 ` Nick Hu
2019-10-08 6:11 ` [PATCH v3 3/3] kasan: Add riscv to KASAN documentation Nick Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-5f3ce9b5-2b64-48d7-a661-7bedf58c50a5@palmer-si-x1e \
--to=palmer@sifive.com \
--cc=Anup.Patel@wdc.com \
--cc=Atish.Patra@wdc.com \
--cc=alankao@andestech.com \
--cc=alexios.zavras@intel.com \
--cc=allison@lohutok.net \
--cc=aou@eecs.berkeley.edu \
--cc=aryabinin@virtuozzo.com \
--cc=corbet@lwn.net \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kasan-dev@googlegroups.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=nickhu@andestech.com \
--cc=paul.walmsley@sifive.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).