linux-riscv.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] RISC-V: Add CONFIG_PREEMPT=y to defconfig
@ 2018-12-20  1:45 Guenter Roeck
  2018-12-20  5:25 ` Guenter Roeck
  2018-12-20 21:33 ` Palmer Dabbelt
  0 siblings, 2 replies; 10+ messages in thread
From: Guenter Roeck @ 2018-12-20  1:45 UTC (permalink / raw)
  To: Palmer Dabbelt; +Cc: linux-riscv, Albert Ou

On Wed, Nov 21, 2018 at 10:58:05AM -0800, Palmer Dabbelt wrote:
> I don't remember who suggested this, but I was talking to someone at
> Plumbers about all the horrible bugs we've had lurking around in our
> port despite it still getting to userspace and they suggested that I
> enable CONFIG_PREEMPT in our defconfig as it'll help shake out more
> issues.
> 
> This patch enables CONFIG_PREEMPT in the single RISC-V defconfig.  It
> still passes my tests (ie, booting Fedora on QEMU).  Maybe I'm too
> paranoid, but I still don't trust our port enough to just pull the
> trigger on this without at least accumulating some "Tested-by"s on it.
> 
> Signed-off-by: Palmer Dabbelt <palmer@sifive.com>

I can only give you a

Fails-miserably-for: Guenter Roeck <linux@roeck-us.net>

Not the new defconfig itself, but the new defconfig plus a variety of
selftest options. I don't know what exactly is failing, but here is
my list of enabled selftests on top of defconfig:

CONFIG_CRYPTO_MANAGER_DISABLE_TESTS=y
CONFIG_CRC32_SELFTEST=y
CONFIG_DEBUG_LOCKING_API_SELFTESTS=y
CONFIG_DEBUG_NMI_SELFTEST=y
CONFIG_DEBUG_RODATA_TEST=y
CONFIG_DEBUG_TLBFLUSH=y
CONFIG_DMATEST=y
CONFIG_GLOB_SELFTEST=y
CONFIG_OF_UNITTEST=y
CONFIG_PCI_EPF_TEST=y
CONFIG_PCI_ENDPOINT_TEST=y
CONFIG_PROVE_LOCKING=y
CONFIG_PROVE_RCU=y
CONFIG_RCU_EQS_DEBUG=y
CONFIG_STATIC_KEYS_SELFTEST=y
CONFIG_STRING_SELFTEST=y
CONFIG_TEST_BITMAP=y
CONFIG_TEST_FIRMWARE=y
CONFIG_TEST_SORT=y
CONFIG_TEST_SYSCTL=y
CONFIG_TEST_UUID=y
CONFIG_USB_TEST=y
CONFIG_USB_EHSET_TEST_FIXTURE=y
CONFIG_USB_LINK_LAYER_TEST=y
CONFIG_WW_MUTEX_SELFTEST=y
CONFIG_TORTURE_TEST=y
CONFIG_LOCK_TORTURE_TEST=y
CONFIG_RCU_TORTURE_TEST=y
CONFIG_RBTREE_TEST=y
CONFIG_INTERVAL_TREE_TEST=y

Tests pass after disabling those tests (or after reverting your patch).

Guenter

> ---
>  arch/riscv/configs/defconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig
> index ef4f15df9adf..8869471af0fc 100644
> --- a/arch/riscv/configs/defconfig
> +++ b/arch/riscv/configs/defconfig
> @@ -1,5 +1,6 @@
>  CONFIG_SYSVIPC=y
>  CONFIG_POSIX_MQUEUE=y
> +CONFIG_PREEMPT=y
>  CONFIG_IKCONFIG=y
>  CONFIG_IKCONFIG_PROC=y
>  CONFIG_CGROUPS=y
> @@ -77,4 +78,3 @@ CONFIG_NFS_V4_2=y
>  CONFIG_ROOT_NFS=y
>  CONFIG_CRYPTO_USER_API_HASH=y
>  CONFIG_PRINTK_TIME=y
> -# CONFIG_RCU_TRACE is not set
> -- 
> 2.7.4

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2019-01-08 19:24 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-20  1:45 [PATCH] RISC-V: Add CONFIG_PREEMPT=y to defconfig Guenter Roeck
2018-12-20  5:25 ` Guenter Roeck
2018-12-26  3:23   ` Guenter Roeck
2018-12-26 17:19     ` Palmer Dabbelt
2019-01-03  2:59       ` Vincent Chen
2019-01-03  3:51         ` Guenter Roeck
2019-01-03  5:21           ` Vincent Chen
2019-01-03  5:29             ` Guenter Roeck
2019-01-08 19:24         ` Palmer Dabbelt
2018-12-20 21:33 ` Palmer Dabbelt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).