linux-riscv.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Palmer Dabbelt <palmer@sifive.com>
To: antonynpavlov@gmail.com, Christoph Hellwig <hch@infradead.org>
Cc: linux-riscv@lists.infradead.org, aou@eecs.berkeley.edu
Subject: Re: [PATCH] RISC-V: asm/page.h: fix spelling mistake "CONFIG_64BITS" -> "CONFIG_64BIT"
Date: Wed, 23 Jan 2019 10:57:18 -0800 (PST)	[thread overview]
Message-ID: <mhng-ccbc59c2-8283-46b1-9ae5-b9397e55752a@palmer-si-x1c4> (raw)
In-Reply-To: <20190108194538.28669-1-antonynpavlov@gmail.com>
In-Reply-To: <20190115135730.GI28946@infradead.org>

On Tue, 15 Jan 2019 05:57:30 PST (-0800), Christoph Hellwig wrote:
> On Tue, Jan 08, 2019 at 10:45:38PM +0300, Antony Pavlov wrote:
>> There is no CONFIG_64BITS Kconfig macro.
>> Please see arch/riscv/Kconfig for details, e.g.
>>
>>   linux$ git grep -HnA 1 "config 64BIT" arch/riscv/Kconfig
>>   arch/riscv/Kconfig:6:config 64BIT
>>   arch/riscv/Kconfig-7-        bool
>>
>> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
>
> This looks correct.  But I wonder why we even bother with the explicit
> width and don't just use "%lx" directly without the macro.

I don't think there's any hard reason for it, but from grepping around it 
appears other arches (arm64 and all the one-liners) pad it with either zeros or 
spaces.

I'm happy with the patch, as at least it's not broken :)

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

      reply	other threads:[~2019-01-23 18:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-08 19:45 [PATCH] RISC-V: asm/page.h: fix spelling mistake "CONFIG_64BITS" -> "CONFIG_64BIT" Antony Pavlov
2019-01-15 13:57 ` Christoph Hellwig
2019-01-23 18:57   ` Palmer Dabbelt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mhng-ccbc59c2-8283-46b1-9ae5-b9397e55752a@palmer-si-x1c4 \
    --to=palmer@sifive.com \
    --cc=antonynpavlov@gmail.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=hch@infradead.org \
    --cc=linux-riscv@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).