From: Palmer Dabbelt <palmer@dabbelt.com>
To: Damien Le Moal <Damien.LeMoal@wdc.com>
Cc: linux-riscv@lists.infradead.org
Subject: Re: [PATCH] riscv: Fix compilation error with Canaan SoC
Date: Tue, 16 Mar 2021 21:21:09 -0700 (PDT) [thread overview]
Message-ID: <mhng-cf63c6e5-9054-458e-b3a9-577ccfc6bd52@palmerdabbelt-glaptop> (raw)
In-Reply-To: <20210311102424.34743-1-damien.lemoal@wdc.com>
On Thu, 11 Mar 2021 02:24:24 PST (-0800), Damien Le Moal wrote:
> When CONFIG_SOC_CANAAN is selected, the K210 sysctl driver is always
> compiled. Since this driver early init function calls the function
> k210_clk_early_init() implemented by the K210 clk driver, this driver
> must also always be selected for compilation ot avoid build failures.
>
> Avoid such build failures by always selecting CONFIG_COMMON_CLK and
> CONFIG_COMMON_CLK_K210 when CONFIG_SOC_CANAAN is enabled.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
> ---
> arch/riscv/Kconfig.socs | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs
> index 7efcece8896c..e1b2690b6e45 100644
> --- a/arch/riscv/Kconfig.socs
> +++ b/arch/riscv/Kconfig.socs
> @@ -31,6 +31,8 @@ config SOC_CANAAN
> select SIFIVE_PLIC
> select ARCH_HAS_RESET_CONTROLLER
> select PINCTRL
> + select COMMON_CLK
> + select COMMON_CLK_K210
> help
> This enables support for Canaan Kendryte K210 SoC platform hardware.
Thanks, this is on fixes.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2021-03-17 4:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 10:24 [PATCH] riscv: Fix compilation error with Canaan SoC Damien Le Moal
2021-03-17 4:21 ` Palmer Dabbelt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-cf63c6e5-9054-458e-b3a9-577ccfc6bd52@palmerdabbelt-glaptop \
--to=palmer@dabbelt.com \
--cc=Damien.LeMoal@wdc.com \
--cc=linux-riscv@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).