linux-riscv.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Palmer Dabbelt <palmer@sifive.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] RISC-V Patches for the 5.2 Merge Window, Part 1 v2
Date: Thu, 16 May 2019 20:07:08 -0700 (PDT)	[thread overview]
Message-ID: <mhng-dd3bf038-f2d1-4318-af23-018200dd31af@palmer-mbp2014> (raw)
In-Reply-To: <CAHk-=wiHtaVsbK4dZ79_h0R307Qv-Fdgdkp3SZ+F+QvzHHGrOQ@mail.gmail.com>

On Thu, 16 May 2019 19:17:17 PDT (-0700), Linus Torvalds wrote:
> On Thu, May 16, 2019 at 5:27 PM Palmer Dabbelt <palmer@sifive.com> wrote:
>>
>>
>>   git://git.kernel.org/pub/scm/linux/kernel/git/palmer/riscv-linux.git tags/riscv-for-linus-5.2-mw1
>
> Oh no no no.
>
> You're creating a binary file from your build or something like that:
>
>>  modules.builtin.modinfo                            | Bin 0 -> 46064 bytes
>
> which is completely unacceptable.
>
> I have no idea what you're doing, but this kind of "random garbage in
> git commits" is not going to fly. And the fact that you're adding
> random files really means that you are doing something *horribly*
> wrong.

Sorry, I have no idea how I missed that.  It looks like I managed to screw
something up while trying to fix up that patch, but I'm not really sure what I
did.  I'll try to figure out how to not screw it up next time.

Thanks for catching this!

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

      reply	other threads:[~2019-05-17  3:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-17  0:27 [GIT PULL] RISC-V Patches for the 5.2 Merge Window, Part 1 v2 Palmer Dabbelt
2019-05-17  2:17 ` Linus Torvalds
2019-05-17  3:07   ` Palmer Dabbelt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mhng-dd3bf038-f2d1-4318-af23-018200dd31af@palmer-mbp2014 \
    --to=palmer@sifive.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).