From: Palmer Dabbelt <palmer@dabbelt.com>
To: alex@ghiti.fr
Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
alex@ghiti.fr, Paul Walmsley <paul.walmsley@sifive.com>
Subject: Re: [PATCH] riscv: Use p*d_leaf macros to define p*d_huge
Date: Thu, 05 Mar 2020 13:15:39 -0800 (PST) [thread overview]
Message-ID: <mhng-e9025d02-f23d-486a-bbbf-083fe0932619@palmerdabbelt-glaptop1> (raw)
In-Reply-To: <20200220061023.958-1-alex@ghiti.fr>
On Wed, 19 Feb 2020 22:10:23 PST (-0800), alex@ghiti.fr wrote:
> The newly introduced p*d_leaf macros allow to check if an entry of the
> page table map to a physical page instead of the next level. To avoid
> duplication of code, use those macros to determine if a page table entry
> points to a hugepage.
>
> Suggested-by: Paul Walmsley <paul.walmsley@sifive.com>
> Signed-off-by: Alexandre Ghiti <alex@ghiti.fr>
> ---
> arch/riscv/mm/hugetlbpage.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/arch/riscv/mm/hugetlbpage.c b/arch/riscv/mm/hugetlbpage.c
> index 0d4747e9d5b5..a6189ed36c5f 100644
> --- a/arch/riscv/mm/hugetlbpage.c
> +++ b/arch/riscv/mm/hugetlbpage.c
> @@ -4,14 +4,12 @@
>
> int pud_huge(pud_t pud)
> {
> - return pud_present(pud) &&
> - (pud_val(pud) & (_PAGE_READ | _PAGE_WRITE | _PAGE_EXEC));
> + return pud_leaf(pud);
> }
>
> int pmd_huge(pmd_t pmd)
> {
> - return pmd_present(pmd) &&
> - (pmd_val(pmd) & (_PAGE_READ | _PAGE_WRITE | _PAGE_EXEC));
> + return pmd_leaf(pmd);
> }
>
> static __init int setup_hugepagesz(char *opt)
Thanks, this is on for-next.
prev parent reply other threads:[~2020-03-05 21:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 6:10 [PATCH] riscv: Use p*d_leaf macros to define p*d_huge Alexandre Ghiti
2020-02-20 6:12 ` Anup Patel
2020-03-05 21:15 ` Palmer Dabbelt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-e9025d02-f23d-486a-bbbf-083fe0932619@palmerdabbelt-glaptop1 \
--to=palmer@dabbelt.com \
--cc=alex@ghiti.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).