From: palmer@sifive.com (Palmer Dabbelt)
To: linux-riscv@lists.infradead.org
Subject: [PATCH] RISC-V: add of_node_put()
Date: Tue, 20 Nov 2018 09:29:50 -0800 (PST) [thread overview]
Message-ID: <mhng-f6900077-f39d-46e8-8fce-e5f7af872ced@palmer-si-x1c4> (raw)
In-Reply-To: <20181120141102.20534-1-tiny.windzz@gmail.com>
On Tue, 20 Nov 2018 06:11:02 PST (-0800), tiny.windzz at gmail.com wrote:
> use of_node_put() to release the refcount.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> arch/riscv/kernel/time.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/riscv/kernel/time.c b/arch/riscv/kernel/time.c
> index 1911c8f6b8a6..40470e669a35 100644
> --- a/arch/riscv/kernel/time.c
> +++ b/arch/riscv/kernel/time.c
> @@ -26,6 +26,7 @@ void __init time_init(void)
> cpu = of_find_node_by_path("/cpus");
> if (!cpu || of_property_read_u32(cpu, "timebase-frequency", &prop))
> panic(KERN_WARNING "RISC-V system with no 'timebase-frequency' in DTS\n");
> + of_node_put(cpu);
> riscv_timebase = prop;
>
> lpj_fine = riscv_timebase / HZ;
Thanks. I'm going to target this for next week's PR.
WARNING: multiple messages have this Message-ID (diff)
From: Palmer Dabbelt <palmer@sifive.com>
To: tiny.windzz@gmail.com
Cc: aou@eecs.berkeley.edu, dmitriy@oss-tech.org,
tiny.windzz@gmail.com, linux-kernel@vger.kernel.org,
atish.patra@wdc.com, tglx@linutronix.de,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH] RISC-V: add of_node_put()
Date: Tue, 20 Nov 2018 09:29:50 -0800 (PST) [thread overview]
Message-ID: <mhng-f6900077-f39d-46e8-8fce-e5f7af872ced@palmer-si-x1c4> (raw)
Message-ID: <20181120172950.EVCekbNK_nAZ3KP8F2R5GXMB_pRE_YjwEgM1iq9vLek@z> (raw)
In-Reply-To: <20181120141102.20534-1-tiny.windzz@gmail.com>
On Tue, 20 Nov 2018 06:11:02 PST (-0800), tiny.windzz@gmail.com wrote:
> use of_node_put() to release the refcount.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> arch/riscv/kernel/time.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/riscv/kernel/time.c b/arch/riscv/kernel/time.c
> index 1911c8f6b8a6..40470e669a35 100644
> --- a/arch/riscv/kernel/time.c
> +++ b/arch/riscv/kernel/time.c
> @@ -26,6 +26,7 @@ void __init time_init(void)
> cpu = of_find_node_by_path("/cpus");
> if (!cpu || of_property_read_u32(cpu, "timebase-frequency", &prop))
> panic(KERN_WARNING "RISC-V system with no 'timebase-frequency' in DTS\n");
> + of_node_put(cpu);
> riscv_timebase = prop;
>
> lpj_fine = riscv_timebase / HZ;
Thanks. I'm going to target this for next week's PR.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2018-11-20 17:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 14:11 [PATCH] RISC-V: add of_node_put() Yangtao Li
2018-11-20 14:11 ` Yangtao Li
2018-11-20 17:29 ` Palmer Dabbelt [this message]
2018-11-20 17:29 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-f6900077-f39d-46e8-8fce-e5f7af872ced@palmer-si-x1c4 \
--to=palmer@sifive.com \
--cc=linux-riscv@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).