From: Andreas Schwab <schwab@suse.de>
To: Atish Patra <atish.patra@wdc.com>
Cc: "Patrick Stählin" <me@packi.ch>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Damien Le Moal" <Damien.LeMoal@wdc.com>,
"Jason Cooper" <jason@lakedaemon.net>,
"Alan Kao" <alankao@andestech.com>,
"Dmitriy Cherkasov" <dmitriy@oss-tech.org>,
"Anup Patel" <anup@brainfault.org>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
linux-kernel@vger.kernel.org, "Zong Li" <zongbox@gmail.com>,
"Marc Zyngier" <marc.zyngier@arm.com>,
"Palmer Dabbelt" <palmer@sifive.com>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
linux-riscv@lists.infradead.org,
"Thomas Gleixner" <tglx@linutronix.de>
Subject: Re: [v3 PATCH 8/8] RISC-V: Assign hwcap only according to boot cpu.
Date: Mon, 11 Feb 2019 14:23:15 +0100 [thread overview]
Message-ID: <mvmo97iv4qk.fsf@suse.de> (raw)
In-Reply-To: <1549590681-24125-9-git-send-email-atish.patra@wdc.com> (Atish Patra's message of "Thu, 7 Feb 2019 17:51:21 -0800")
On Feb 07 2019, Atish Patra <atish.patra@wdc.com> wrote:
> + while ((node = of_find_node_by_type(node, "cpu"))) {
> + if (!node) {
That can never be true.
> + pr_warn("Unable to find \"cpu\" devicetree entry");
> + return;
> + }
> +
> + hartid = riscv_of_processor_hartid(node);
> + if (hartid < 0)
> + continue;
>
> - if (of_property_read_string(node, "riscv,isa", &isa)) {
> - pr_warning("Unable to find \"riscv,isa\" devicetree entry");
> + if (of_property_read_string(node, "riscv,isa", &isa)) {
> + pr_warn("Unable to find \"riscv,isa\" devicetree entry");
> + of_node_put(node);
> + return;
> + }
> of_node_put(node);
[ 0.000000] OF: ERROR: Bad of_node_put() on /cpus/cpu@1
[ 0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted 5.0.0-rc6-00020-g5903f30f1310 #12
[ 0.000000] Call Trace:
[ 0.000000] [<ffffffe001076812>] walk_stackframe+0x0/0xa4
[ 0.000000] [<ffffffe001076a12>] show_stack+0x2a/0x34
[ 0.000000] [<ffffffe0015cf9ea>] dump_stack+0x62/0x7c
[ 0.000000] [<ffffffe00149fed4>] of_node_release+0xbe/0xc0
[ 0.000000] [<ffffffe0015d465a>] kobject_put+0xa6/0x1e8
[ 0.000000] [<ffffffe00149f44e>] of_node_put+0x16/0x20
[ 0.000000] [<ffffffe00149b45e>] of_find_node_by_type+0x66/0xa4
[ 0.000000] [<ffffffe0010755ca>] riscv_fill_hwcap+0x14c/0x1ce
[ 0.000000] [<ffffffe0000026d4>] 0xffffffe0000026d4
[ 0.000000] [<ffffffe0000006ec>] 0xffffffe0000006ec
[ 0.000000] [<ffffffe000000076>] 0xffffffe000000076
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
prev parent reply other threads:[~2019-02-11 13:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 1:51 [v3 PATCH 0/8] Various SMP related fixes Atish Patra
2019-02-08 1:51 ` [v3 PATCH 1/8] RISC-V: Do not wait indefinitely in __cpu_up Atish Patra
2019-02-08 9:01 ` Christoph Hellwig
2019-02-08 1:51 ` [v3 PATCH 2/8] RISC-V: Move cpuid to hartid mapping to SMP Atish Patra
2019-02-08 9:03 ` Christoph Hellwig
2019-02-08 22:56 ` Atish Patra
2019-02-08 1:51 ` [v3 PATCH 3/8] RISC-V: Remove NR_CPUs check during hartid search from DT Atish Patra
2019-02-08 1:51 ` [v3 PATCH 4/8] RISC-V: Allow hartid-to-cpuid function to fail Atish Patra
2019-02-08 1:51 ` [v3 PATCH 5/8] RISC-V: Compare cpuid with NR_CPUS before mapping Atish Patra
2019-02-08 1:51 ` [v3 PATCH 6/8] clocksource/drivers/riscv: Add required checks during clock source init Atish Patra
2019-02-08 9:04 ` Christoph Hellwig
2019-02-08 22:56 ` Atish Patra
2019-02-08 1:51 ` [v3 PATCH 7/8] irqchip/irq-sifive-plic:: Check and continue in case of an invalid cpuid Atish Patra
2019-02-08 1:51 ` [v3 PATCH 8/8] RISC-V: Assign hwcap only according to boot cpu Atish Patra
2019-02-08 9:11 ` Christoph Hellwig
2019-02-08 23:02 ` Atish Patra
2019-02-09 4:26 ` David Abdurachmanov
2019-02-09 16:11 ` Marc Zyngier
2019-02-11 19:02 ` Palmer Dabbelt
2019-02-11 20:03 ` Atish Patra
2019-02-11 22:13 ` Marc Zyngier
2019-02-11 22:23 ` Palmer Dabbelt
2019-02-11 23:25 ` Atish Patra
2019-02-11 13:23 ` Andreas Schwab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvmo97iv4qk.fsf@suse.de \
--to=schwab@suse.de \
--cc=Damien.LeMoal@wdc.com \
--cc=alankao@andestech.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=atish.patra@wdc.com \
--cc=daniel.lezcano@linaro.org \
--cc=dmitriy@oss-tech.org \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=marc.zyngier@arm.com \
--cc=me@packi.ch \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=tglx@linutronix.de \
--cc=zongbox@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).