From: Hans Verkuil <hverkuil@xs4all.nl>
To: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
linux-media@vger.kernel.org
Cc: mchehab@kernel.org, dafna3@gmail.com, tfiga@chromium.org,
linux-rockchip@lists.infradead.org, helen.koike@collabora.com,
laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com,
kernel@collabora.com, ezequiel@collabora.com
Subject: Re: [PATCH v2 1/2] media: uapi: add MEDIA_BUS_FMT_METADATA_FIXED media bus format.
Date: Fri, 30 Oct 2020 12:58:46 +0100 [thread overview]
Message-ID: <0532e316-ff0f-6a6c-8a12-6b013f866e58@xs4all.nl> (raw)
In-Reply-To: <36159037-bf65-f7be-8deb-735afd726eee@collabora.com>
On 30/10/2020 12:34, Dafna Hirschfeld wrote:
>
>
> Am 30.10.20 um 09:58 schrieb Hans Verkuil:
>> On 20/10/2020 17:45, Dafna Hirschfeld wrote:
>>> MEDIA_BUS_FMT_METADATA_FIXED should be used when
>>> the same driver handles both sides of the link and
>>> the bus format is a fixed metadata format that is
>>> not configurable from userspace.
>>> The width and height will be set to 0 for this format.
>>>
>>> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
>>> Acked-by: Helen Koike <helen.koike@collabora.com>
>>> ---
>>> changes since v1:
>>> 1. replace "This format may have 0 height and width."
>>> with "Width and height will be set to 0 for this format."
>>> and add it also to the commit log
>>> 2. s/meida:/media:/ in the patch subject line
>>>
>>> include/uapi/linux/media-bus-format.h | 8 ++++++++
>>> 1 file changed, 8 insertions(+)
>>>
>>> diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h
>>> index 84fa53ffb13f..2ce3d891d344 100644
>>> --- a/include/uapi/linux/media-bus-format.h
>>> +++ b/include/uapi/linux/media-bus-format.h
>>> @@ -156,4 +156,12 @@
>>> /* HSV - next is 0x6002 */
>>> #define MEDIA_BUS_FMT_AHSV8888_1X32 0x6001
>>>
>>> +/*
>>> + * This format should be used when the same driver handles
>>> + * both sides of the link and the bus format is a fixed
>>> + * metadata format that is not configurable from userspace.
>>> + * Width and height will be set to 0 for this format.
>>> + */
>>> +#define MEDIA_BUS_FMT_METADATA_FIXED 0x7001
>>> +
>>> #endif /* __LINUX_MEDIA_BUS_FORMAT_H */
>>>
>>
>> Documentation/userspace-api/media/v4l/subdev-formats.rst also needs to
>> be updated.
>
> hi,
> I wonder what should be the documentation, since this mbus code
Basically the same as you wrote in the comment above.
> is for very specific use case. You think that the 0x7* mbus codes
> should be 'metadata mbus codes'?
Yes.
Regards,
Hans
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
prev parent reply other threads:[~2020-10-30 11:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 15:45 [PATCH v2 1/2] media: uapi: add MEDIA_BUS_FMT_METADATA_FIXED media bus format Dafna Hirschfeld
2020-10-20 15:45 ` [PATCH v2 2/2] media: staging: rkisp1: isp: set metadata pads to MEDIA_BUS_FMT_METADATA_FIXED Dafna Hirschfeld
2020-10-30 8:58 ` [PATCH v2 1/2] media: uapi: add MEDIA_BUS_FMT_METADATA_FIXED media bus format Hans Verkuil
2020-10-30 11:34 ` Dafna Hirschfeld
2020-10-30 11:58 ` Hans Verkuil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0532e316-ff0f-6a6c-8a12-6b013f866e58@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=dafna.hirschfeld@collabora.com \
--cc=dafna3@gmail.com \
--cc=ezequiel@collabora.com \
--cc=helen.koike@collabora.com \
--cc=kernel@collabora.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).