linux-rockchip.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Emmanuel Vadot <manu-xXdDKFdH5B3kFDPD4ZthVA@public.gmane.org>
To: Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	Kever Yang <kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
	u-boot-0aAXYlwwYIKGBzrmiIFOJg@public.gmane.org,
	Philipp Tomsich
	<philipp.tomsich-SN7IsUiht6C/RdPyistoZJqQE7yCjDx5@public.gmane.org>,
	linux-amarula
	<linux-amarula-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
Subject: Re: [PATCH 10/11] rockpro-rk3399: Enable SPI Flash
Date: Mon, 30 Dec 2019 12:51:34 +0100	[thread overview]
Message-ID: <20191230125134.189ba860e7fc99b4ad2f1def@bidouilliste.com> (raw)
In-Reply-To: <20191221075440.6944-11-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>


 Hi Jagan,

On Sat, 21 Dec 2019 13:24:39 +0530
Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> wrote:

> Enable winbond SPI flash for ROC-PC-RK3399 board.

 s/ROC-PC-RK3399/RockPro64/

> 
> Signed-off-by: Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
> ---
>  arch/arm/dts/rk3399-rockpro64-u-boot.dtsi | 4 ++++
>  configs/rockpro64-rk3399_defconfig        | 2 ++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> index 4648513ea9..deaa3efd39 100644
> --- a/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> +++ b/arch/arm/dts/rk3399-rockpro64-u-boot.dtsi
> @@ -6,6 +6,10 @@
>  #include "rk3399-u-boot.dtsi"
>  #include "rk3399-sdram-lpddr4-100.dtsi"
>  / {
> +	aliases {
> +		spi0 = &spi1;

 That looks weird ... what's the point of this alias exactly ?

> +	};
> +
>  	chosen {
>  		u-boot,spl-boot-order = "same-as-spl", &sdmmc, &sdhci;
>  	};
> diff --git a/configs/rockpro64-rk3399_defconfig b/configs/rockpro64-rk3399_defconfig
> index 49e27c91cb..6a50ec7dbc 100644
> --- a/configs/rockpro64-rk3399_defconfig
> +++ b/configs/rockpro64-rk3399_defconfig
> @@ -46,6 +46,8 @@ CONFIG_RAM_RK3399_LPDDR4=y
>  CONFIG_BAUDRATE=1500000
>  CONFIG_DEBUG_UART_SHIFT=2
>  CONFIG_SYSRESET=y
> +CONFIG_SPI_FLASH_GIGADEVICE=y
> +CONFIG_ROCKCHIP_SPI=y
>  CONFIG_USB=y
>  CONFIG_USB_XHCI_HCD=y
>  CONFIG_USB_XHCI_DWC3=y
> -- 
> 2.18.0.321.gffc6fa0e3


-- 
Emmanuel Vadot <manu-xXdDKFdH5B3kFDPD4ZthVA@public.gmane.org>

  parent reply	other threads:[~2019-12-30 11:51 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-21  7:54 [PATCH 00/11] rk3399: SPI boot support (fixes, updates) Jagan Teki
     [not found] ` <20191221075440.6944-1-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2019-12-21  7:54   ` [PATCH 01/11] spi: rk: Limit transfers to (64K - 1) bytes Jagan Teki
     [not found]     ` <20191221075440.6944-2-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2019-12-23  2:30       ` Kever Yang
2019-12-27  5:55         ` Jagan Teki
2019-12-21  7:54   ` [PATCH 02/11] distro_bootcmd: Add SF support Jagan Teki
2019-12-30  3:07     ` Kever Yang
2020-01-20 17:22     ` Tom Rini
2020-01-20 17:40       ` Alexander Graf
2020-01-23 16:55         ` Jagan Teki
2020-01-23 17:03           ` Tom Rini
2020-01-23 17:11             ` Jagan Teki
2020-01-23 17:15               ` Tom Rini
2020-01-23 17:29                 ` Jagan Teki
2020-01-23 17:59                   ` Tom Rini
2019-12-21  7:54   ` [PATCH 03/11] rockchip: Include SF on distrocmd devices Jagan Teki
     [not found]     ` <20191221075440.6944-4-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2019-12-30  3:07       ` Kever Yang
2020-01-07  8:44     ` Kever Yang
2019-12-21  7:54   ` [PATCH 04/11] rk3399: Add boot flash script offet, size Jagan Teki
2019-12-30  3:06     ` Kever Yang
2019-12-21  7:54   ` [PATCH 05/11] rk3399: Check MMC env while defining it Jagan Teki
2019-12-30  3:06     ` Kever Yang
2019-12-21  7:54   ` [PATCH 06/11] env: kconfig: Restrict rockchip env for MMC Jagan Teki
2019-12-30  3:05     ` Kever Yang
2019-12-21  7:54   ` [PATCH 07/11] env: Enable SPI flash env for rockchip Jagan Teki
2019-12-23  2:34     ` Kever Yang
2019-12-27  6:50       ` Jagan Teki
2019-12-27 10:02         ` Kever Yang
2019-12-27 10:10           ` Jagan Teki
2019-12-27 10:30         ` Soeren Moch
2019-12-27 12:04           ` Jagan Teki
2019-12-27 13:19             ` Soeren Moch
     [not found]               ` <30fdf54b-0f71-ffbf-ac57-51050a29b56d-S0/GAf8tV78@public.gmane.org>
2019-12-28 12:08                 ` Jagan Teki
2019-12-30  9:04                   ` Soeren Moch
2019-12-30  2:59     ` Kever Yang
2019-12-21  7:54   ` [PATCH 08/11] rockchip: dts: Sync ROC-RK3399-PC changes from Linux Jagan Teki
     [not found]     ` <20191221075440.6944-9-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2019-12-30  3:00       ` Kever Yang
2019-12-21  7:54   ` [PATCH 09/11] roc-pc-rk3399: Enable SPI Flash Jagan Teki
     [not found]     ` <20191221075440.6944-10-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2019-12-30  3:00       ` Kever Yang
2019-12-21  7:54   ` [PATCH 10/11] rockpro-rk3399: " Jagan Teki
2019-12-30  3:00     ` Kever Yang
     [not found]     ` <20191221075440.6944-11-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2019-12-30 11:51       ` Emmanuel Vadot [this message]
2020-01-08 12:59         ` Jagan Teki
2019-12-21  7:54   ` [PATCH 11/11] roc-rk3399-pc: Add SPI boot support Jagan Teki
2019-12-30  3:05     ` Kever Yang
2019-12-30  7:52       ` Jagan Teki
     [not found]         ` <CAMty3ZA1u3-21QN4N6W=9Sq3n493BBBB2W_FzAEQC9aze4SoMg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-01-07  8:53           ` Kever Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191230125134.189ba860e7fc99b4ad2f1def@bidouilliste.com \
    --to=manu-xxddkfdh5b3kfdpd4zthva@public.gmane.org \
    --cc=jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org \
    --cc=kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    --cc=linux-amarula-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org \
    --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=philipp.tomsich-SN7IsUiht6C/RdPyistoZJqQE7yCjDx5@public.gmane.org \
    --cc=sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=u-boot-0aAXYlwwYIKGBzrmiIFOJg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).