From: Rob Herring <robh@kernel.org>
To: Johan Jonker <jbx6244@gmail.com>
Cc: kishon@ti.com, heiko@sntech.de, robh+dt@kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/2] dt-bindings: phy: convert phy-rockchip-inno-usb2 bindings to yaml
Date: Thu, 19 Mar 2020 11:13:05 -0600 [thread overview]
Message-ID: <20200319171305.GA19150@bogus> (raw)
In-Reply-To: <20200318192901.5023-1-jbx6244@gmail.com>
On Wed, 18 Mar 2020 20:29:00 +0100, Johan Jonker wrote:
> Current dts files for Rockchip with 'usb2-phy' subnodes
> are manually verified. In order to automate this process
> phy-rockchip-inno-usb2.txt has to be converted to yaml.
>
> Changed:
> Removed unused "rockchip,rk3366-usb2phy" support.
> Replaced example with something that has SoC support
> in the kernel.
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
> .../bindings/phy/phy-rockchip-inno-usb2.txt | 81 -----------
> .../bindings/phy/phy-rockchip-inno-usb2.yaml | 149 +++++++++++++++++++++
> 2 files changed, 149 insertions(+), 81 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt
> create mode 100644 Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.example.dt.yaml: usb2-phy@e450: '#phy-cells' is a required property
See https://patchwork.ozlabs.org/patch/1257721
Please check and re-submit.
prev parent reply other threads:[~2020-03-19 17:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 19:29 [RFC PATCH 1/2] dt-bindings: phy: convert phy-rockchip-inno-usb2 bindings to yaml Johan Jonker
[not found] ` <20200318192901.5023-1-jbx6244-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-03-18 19:29 ` [RFC PATCH 2/2] phy: phy-rockchip-inno-usb2: remove support for rockchip,rk3366-usb2phy Johan Jonker
[not found] ` <20200318192901.5023-2-jbx6244-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-03-19 13:07 ` [RFC PATCH 2/2] phy: phy-rockchip-inno-usb2: remove support for rockchip, rk3366-usb2phy Robin Murphy
2020-03-19 14:01 ` Johan Jonker
2020-03-19 12:12 ` [RFC PATCH 1/2] dt-bindings: phy: convert phy-rockchip-inno-usb2 bindings to yaml Johan Jonker
2020-03-19 17:13 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200319171305.GA19150@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).