Linux-Rockchip Archive on
 help / color / Atom feed
From: Alexandru Stan <>
To: "Thierry Reding" <>,
	"Uwe Kleine-König" <>,
	"Lee Jones" <>,
	"Daniel Thompson" <>,
	"Jingoo Han" <>,
	"Bartlomiej Zolnierkiewicz" <>,
	"Heiko Stuebner" <>,
	"Rob Herring" <>,
	"Andy Gross" <>,
	"Bjorn Andersson" <>
	Alexandru Stan <>,,,
	Douglas Anderson <>,,,,
	Matthias Kaehlcke <>,
	Enric Balletbo i Serra <>,
Subject: [PATCH v2 0/3] PWM backlight interpolation adjustments
Date: Tue, 13 Oct 2020 01:01:00 -0700
Message-ID: <> (raw)

I was trying to adjust the brightness-levels for the trogdor boards:
Like on a lot of panels, trogdor's low end needs to be cropped,
and now that we have the interpolation stuff I wanted to make use of it
and bake in even the curve that's customary to have on chromebooks.

I found the current behavior of the pwm_bl driver a little unintuitive
and non-linear. See patch 1 for a suggested fix for this.

A few veyron dts files were relying on this (perhaps weird) behavior.
Those devices also want a minimum brightness like trogdor, so changed
them to use the new way.

Finally, given that trogdor's dts is part of linux-next now, add the
brightness-levels to it, since that's the original reason I was looking at

Changes in v2:
- Fixed type promotion in the driver
- Removed "backlight: pwm_bl: Artificially add 0% during interpolation",
userspace works just fine without it because it already knows how to use
bl_power for turning off the display.
- Added brightness-levels to trogdor as well, now the dts is upstream.

Alexandru Stan (3):
  backlight: pwm_bl: Fix interpolation
  ARM: dts: rockchip: veyron: Remove 0 point from brightness-levels
  arm64: dts: qcom: trogdor: Add brightness-levels

 arch/arm/boot/dts/rk3288-veyron-jaq.dts      |  2 +-
 arch/arm/boot/dts/rk3288-veyron-minnie.dts   |  2 +-
 arch/arm/boot/dts/rk3288-veyron-tiger.dts    |  2 +-
 arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi |  9 +++
 drivers/video/backlight/pwm_bl.c             | 70 +++++++++-----------
 5 files changed, 43 insertions(+), 42 deletions(-)


Linux-rockchip mailing list

             reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-13  8:01 Alexandru Stan [this message]
2020-10-13  8:01 ` [PATCH v2 2/3] ARM: dts: rockchip: veyron: Remove 0 point from brightness-levels Alexandru Stan
2020-10-14 14:19   ` Daniel Thompson
2020-10-15 21:29     ` Alexandru M Stan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Rockchip Archive on

Archives are clonable:
	git clone --mirror linux-rockchip/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-rockchip linux-rockchip/ \
	public-inbox-index linux-rockchip

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone