Linux-Rockchip Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v2] drm/of: Consider the state in which the ep is disabled
@ 2020-07-07 11:25 Sandy Huang
  2020-07-07 11:33 ` Heiko Stübner
                   ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: Sandy Huang @ 2020-07-07 11:25 UTC (permalink / raw)
  To: heiko, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
	David Airlie, Daniel Vetter
  Cc: huangtao, andy.yan, linux-rockchip, dri-devel, kever.yang,
	Sandy Huang, linux-kernel

don't mask possible_crtcs if remote-point is disabled.

Signed-off-by: Sandy Huang <hjc@rock-chips.com>
---
 drivers/gpu/drm/drm_of.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
index fdb05fbf72a0..565f05f5f11b 100644
--- a/drivers/gpu/drm/drm_of.c
+++ b/drivers/gpu/drm/drm_of.c
@@ -66,6 +66,9 @@ uint32_t drm_of_find_possible_crtcs(struct drm_device *dev,
 	uint32_t possible_crtcs = 0;
 
 	for_each_endpoint_of_node(port, ep) {
+		if (!of_device_is_available(ep))
+			continue;
+
 		remote_port = of_graph_get_remote_port(ep);
 		if (!remote_port) {
 			of_node_put(ep);
-- 
2.17.1

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2] drm/of: Consider the state in which the ep is disabled
  2020-07-07 11:25 [PATCH v2] drm/of: Consider the state in which the ep is disabled Sandy Huang
@ 2020-07-07 11:33 ` Heiko Stübner
  2020-07-22 19:01 ` Heiko Stübner
  2020-10-14  1:48 ` Kever Yang
  2 siblings, 0 replies; 9+ messages in thread
From: Heiko Stübner @ 2020-07-07 11:33 UTC (permalink / raw)
  To: Sandy Huang
  Cc: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
	David Airlie, Daniel Vetter, huangtao, andy.yan, linux-rockchip,
	dri-devel, kever.yang, linux-kernel

Am Dienstag, 7. Juli 2020, 13:25:26 CEST schrieb Sandy Huang:
> don't mask possible_crtcs if remote-point is disabled.
> 
> Signed-off-by: Sandy Huang <hjc@rock-chips.com>

Reviewed-by: Heiko Stuebner <heiko@sntech.de>

I guess this could've benefitted from a "changelog":

changes in v2:
- drop additional of_node_put, as ep will be put with the next
  iteration of for_each_endpoint_of_node()


> ---
>  drivers/gpu/drm/drm_of.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
> index fdb05fbf72a0..565f05f5f11b 100644
> --- a/drivers/gpu/drm/drm_of.c
> +++ b/drivers/gpu/drm/drm_of.c
> @@ -66,6 +66,9 @@ uint32_t drm_of_find_possible_crtcs(struct drm_device *dev,
>  	uint32_t possible_crtcs = 0;
>  
>  	for_each_endpoint_of_node(port, ep) {
> +		if (!of_device_is_available(ep))
> +			continue;
> +
>  		remote_port = of_graph_get_remote_port(ep);
>  		if (!remote_port) {
>  			of_node_put(ep);
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2] drm/of: Consider the state in which the ep is disabled
  2020-07-07 11:25 [PATCH v2] drm/of: Consider the state in which the ep is disabled Sandy Huang
  2020-07-07 11:33 ` Heiko Stübner
@ 2020-07-22 19:01 ` Heiko Stübner
  2020-08-13  6:31   ` Huang Jiachai
  2020-10-14  1:48 ` Kever Yang
  2 siblings, 1 reply; 9+ messages in thread
From: Heiko Stübner @ 2020-07-22 19:01 UTC (permalink / raw)
  To: Sandy Huang
  Cc: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
	David Airlie, Daniel Vetter, huangtao, andy.yan, linux-rockchip,
	dri-devel, kever.yang, linux-kernel

Am Dienstag, 7. Juli 2020, 13:25:26 CEST schrieb Sandy Huang:
> don't mask possible_crtcs if remote-point is disabled.
> 
> Signed-off-by: Sandy Huang <hjc@rock-chips.com>

Reviewed-by: Heiko Stuebner <heiko@sntech.de>

changes in v2:
- drop additional of_node_put, as ep will be put with the next
  iteration of for_each_endpoint_of_node()


As this touches a pretty central function is there something
to keep in mind in regards to other DRM drivers?
[question for the broader audience ;-) ]

Heiko

> ---
>  drivers/gpu/drm/drm_of.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
> index fdb05fbf72a0..565f05f5f11b 100644
> --- a/drivers/gpu/drm/drm_of.c
> +++ b/drivers/gpu/drm/drm_of.c
> @@ -66,6 +66,9 @@ uint32_t drm_of_find_possible_crtcs(struct drm_device *dev,
>  	uint32_t possible_crtcs = 0;
>  
>  	for_each_endpoint_of_node(port, ep) {
> +		if (!of_device_is_available(ep))
> +			continue;
> +
>  		remote_port = of_graph_get_remote_port(ep);
>  		if (!remote_port) {
>  			of_node_put(ep);
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2] drm/of: Consider the state in which the ep is disabled
  2020-07-22 19:01 ` Heiko Stübner
@ 2020-08-13  6:31   ` Huang Jiachai
  2020-09-02 11:56     ` Huang Jiachai
  0 siblings, 1 reply; 9+ messages in thread
From: Huang Jiachai @ 2020-08-13  6:31 UTC (permalink / raw)
  To: Heiko Stübner, David Airlie
  Cc: huangtao, Thomas Zimmermann, David Airlie, Maarten Lankhorst,
	kever.yang, Maxime Ripard, linux-kernel, linux-rockchip,
	dri-devel, Daniel Vetter, andy.yan

ping...

在 2020/7/23 3:01, Heiko Stübner 写道:
> Am Dienstag, 7. Juli 2020, 13:25:26 CEST schrieb Sandy Huang:
>> don't mask possible_crtcs if remote-point is disabled.
>>
>> Signed-off-by: Sandy Huang <hjc@rock-chips.com>
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
>
> changes in v2:
> - drop additional of_node_put, as ep will be put with the next
>    iteration of for_each_endpoint_of_node()
>
>
> As this touches a pretty central function is there something
> to keep in mind in regards to other DRM drivers?
> [question for the broader audience ;-) ]
>
> Heiko
>
>> ---
>>   drivers/gpu/drm/drm_of.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
>> index fdb05fbf72a0..565f05f5f11b 100644
>> --- a/drivers/gpu/drm/drm_of.c
>> +++ b/drivers/gpu/drm/drm_of.c
>> @@ -66,6 +66,9 @@ uint32_t drm_of_find_possible_crtcs(struct drm_device *dev,
>>   	uint32_t possible_crtcs = 0;
>>   
>>   	for_each_endpoint_of_node(port, ep) {
>> +		if (!of_device_is_available(ep))
>> +			continue;
>> +
>>   		remote_port = of_graph_get_remote_port(ep);
>>   		if (!remote_port) {
>>   			of_node_put(ep);
>>
>
>
>
>
>
-- 
Best Regard

黄家钗
Sandy Huang
Addr: 福州市鼓楼区铜盘路软件大道89号福州软件园A区21号楼(350003)
       No. 21 Building, A District, No.89,software Boulevard Fuzhou,Fujian,PRC
Tel:+86 0591-87884919  8690
E-mail:hjc@rock-chips.com




_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2] drm/of: Consider the state in which the ep is disabled
  2020-08-13  6:31   ` Huang Jiachai
@ 2020-09-02 11:56     ` Huang Jiachai
  0 siblings, 0 replies; 9+ messages in thread
From: Huang Jiachai @ 2020-09-02 11:56 UTC (permalink / raw)
  To: Heiko Stübner, David Airlie
  Cc: huangtao, Thomas Zimmermann, Maarten Lankhorst, kever.yang,
	Maxime Ripard, linux-kernel, linux-rockchip, dri-devel,
	Daniel Vetter, andy.yan

Hi David Airlie,

     Please help to confirm whether this modification is reasonable when 
you are free, thanks.


在 2020/8/13 14:31, Huang Jiachai 写道:
> ping...
>
> 在 2020/7/23 3:01, Heiko Stübner 写道:
>> Am Dienstag, 7. Juli 2020, 13:25:26 CEST schrieb Sandy Huang:
>>> don't mask possible_crtcs if remote-point is disabled.
>>>
>>> Signed-off-by: Sandy Huang <hjc@rock-chips.com>
>> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
>>
>> changes in v2:
>> - drop additional of_node_put, as ep will be put with the next
>>    iteration of for_each_endpoint_of_node()
>>
>>
>> As this touches a pretty central function is there something
>> to keep in mind in regards to other DRM drivers?
>> [question for the broader audience ;-) ]
>>
>> Heiko
>>
>>> ---
>>>   drivers/gpu/drm/drm_of.c | 3 +++
>>>   1 file changed, 3 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
>>> index fdb05fbf72a0..565f05f5f11b 100644
>>> --- a/drivers/gpu/drm/drm_of.c
>>> +++ b/drivers/gpu/drm/drm_of.c
>>> @@ -66,6 +66,9 @@ uint32_t drm_of_find_possible_crtcs(struct 
>>> drm_device *dev,
>>>       uint32_t possible_crtcs = 0;
>>>         for_each_endpoint_of_node(port, ep) {
>>> +        if (!of_device_is_available(ep))
>>> +            continue;
>>> +
>>>           remote_port = of_graph_get_remote_port(ep);
>>>           if (!remote_port) {
>>>               of_node_put(ep);
>>>
>>
>>
>>
>>
>>
-- 
Best Regard

黄家钗
Sandy Huang
Addr: 福州市鼓楼区铜盘路软件大道89号福州软件园A区21号楼(350003)
       No. 21 Building, A District, No.89,software Boulevard Fuzhou,Fujian,PRC
Tel:+86 0591-87884919  8690
E-mail:hjc@rock-chips.com




_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2] drm/of: Consider the state in which the ep is disabled
  2020-07-07 11:25 [PATCH v2] drm/of: Consider the state in which the ep is disabled Sandy Huang
  2020-07-07 11:33 ` Heiko Stübner
  2020-07-22 19:01 ` Heiko Stübner
@ 2020-10-14  1:48 ` Kever Yang
  2020-10-15 15:23   ` Daniel Vetter
  2 siblings, 1 reply; 9+ messages in thread
From: Kever Yang @ 2020-10-14  1:48 UTC (permalink / raw)
  To: Sandy Huang, heiko, Maarten Lankhorst, Maxime Ripard,
	Thomas Zimmermann, David Airlie, Daniel Vetter
  Cc: huangtao, andy.yan, linux-kernel, dri-devel, linux-rockchip

Hi Maintainers,

     Does this patch ready to merge?

On 2020/7/7 下午7:25, Sandy Huang wrote:
> don't mask possible_crtcs if remote-point is disabled.
>
> Signed-off-by: Sandy Huang <hjc@rock-chips.com>
> ---
>   drivers/gpu/drm/drm_of.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
> index fdb05fbf72a0..565f05f5f11b 100644
> --- a/drivers/gpu/drm/drm_of.c
> +++ b/drivers/gpu/drm/drm_of.c
> @@ -66,6 +66,9 @@ uint32_t drm_of_find_possible_crtcs(struct drm_device *dev,
>   	uint32_t possible_crtcs = 0;
>   
>   	for_each_endpoint_of_node(port, ep) {
> +		if (!of_device_is_available(ep))
> +			continue;
> +
>   		remote_port = of_graph_get_remote_port(ep);
>   		if (!remote_port) {
>   			of_node_put(ep);

Looks good to me.


Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2] drm/of: Consider the state in which the ep is disabled
  2020-10-14  1:48 ` Kever Yang
@ 2020-10-15 15:23   ` Daniel Vetter
  2020-10-19  3:43     ` Kever Yang
  0 siblings, 1 reply; 9+ messages in thread
From: Daniel Vetter @ 2020-10-15 15:23 UTC (permalink / raw)
  To: Kever Yang
  Cc: huangtao, heiko, David Airlie, Maarten Lankhorst, Sandy Huang,
	Maxime Ripard, linux-kernel, linux-rockchip, dri-devel,
	Thomas Zimmermann, andy.yan, Daniel Vetter

On Wed, Oct 14, 2020 at 09:48:43AM +0800, Kever Yang wrote:
> Hi Maintainers,
> 
>     Does this patch ready to merge?

Would maybe be good to get some acks from other drivers using this, then
Sandy can push to drm-misc-next.
-Daniel
> 
> On 2020/7/7 下午7:25, Sandy Huang wrote:
> > don't mask possible_crtcs if remote-point is disabled.
> > 
> > Signed-off-by: Sandy Huang <hjc@rock-chips.com>
> > ---
> >   drivers/gpu/drm/drm_of.c | 3 +++
> >   1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
> > index fdb05fbf72a0..565f05f5f11b 100644
> > --- a/drivers/gpu/drm/drm_of.c
> > +++ b/drivers/gpu/drm/drm_of.c
> > @@ -66,6 +66,9 @@ uint32_t drm_of_find_possible_crtcs(struct drm_device *dev,
> >   	uint32_t possible_crtcs = 0;
> >   	for_each_endpoint_of_node(port, ep) {
> > +		if (!of_device_is_available(ep))
> > +			continue;
> > +
> >   		remote_port = of_graph_get_remote_port(ep);
> >   		if (!remote_port) {
> >   			of_node_put(ep);
> 
> Looks good to me.
> 
> 
> Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2] drm/of: Consider the state in which the ep is disabled
  2020-10-15 15:23   ` Daniel Vetter
@ 2020-10-19  3:43     ` Kever Yang
  2020-10-20  8:13       ` Daniel Vetter
  0 siblings, 1 reply; 9+ messages in thread
From: Kever Yang @ 2020-10-19  3:43 UTC (permalink / raw)
  To: Sandy Huang, heiko, Maarten Lankhorst, Maxime Ripard,
	Thomas Zimmermann, David Airlie, huangtao, andy.yan,
	linux-rockchip, dri-devel, linux-kernel

Hi Daniel,

On 2020/10/15 下午11:23, Daniel Vetter wrote:
> On Wed, Oct 14, 2020 at 09:48:43AM +0800, Kever Yang wrote:
>> Hi Maintainers,
>>
>>      Does this patch ready to merge?
> Would maybe be good to get some acks from other drivers using this, then
> Sandy can push to drm-misc-next.

Thanks for your reply, I can understand more 'acks' will be better, but 
there is no comments object to this patch

or any 'NAK' common for more then 3 months, maintainers should move to 
next step.


Thanks,

- Kever

> -Daniel
>> On 2020/7/7 下午7:25, Sandy Huang wrote:
>>> don't mask possible_crtcs if remote-point is disabled.
>>>
>>> Signed-off-by: Sandy Huang <hjc@rock-chips.com>
>>> ---
>>>    drivers/gpu/drm/drm_of.c | 3 +++
>>>    1 file changed, 3 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
>>> index fdb05fbf72a0..565f05f5f11b 100644
>>> --- a/drivers/gpu/drm/drm_of.c
>>> +++ b/drivers/gpu/drm/drm_of.c
>>> @@ -66,6 +66,9 @@ uint32_t drm_of_find_possible_crtcs(struct drm_device *dev,
>>>    	uint32_t possible_crtcs = 0;
>>>    	for_each_endpoint_of_node(port, ep) {
>>> +		if (!of_device_is_available(ep))
>>> +			continue;
>>> +
>>>    		remote_port = of_graph_get_remote_port(ep);
>>>    		if (!remote_port) {
>>>    			of_node_put(ep);
>> Looks good to me.
>>
>>
>> Reviewed-by: Kever Yang <kever.yang@rock-chips.com>



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2] drm/of: Consider the state in which the ep is disabled
  2020-10-19  3:43     ` Kever Yang
@ 2020-10-20  8:13       ` Daniel Vetter
  0 siblings, 0 replies; 9+ messages in thread
From: Daniel Vetter @ 2020-10-20  8:13 UTC (permalink / raw)
  To: Kever Yang
  Cc: huangtao, heiko, David Airlie, Maarten Lankhorst, Sandy Huang,
	Maxime Ripard, linux-kernel, linux-rockchip, dri-devel,
	Thomas Zimmermann, andy.yan

On Mon, Oct 19, 2020 at 11:43:53AM +0800, Kever Yang wrote:
> Hi Daniel,
> 
> On 2020/10/15 下午11:23, Daniel Vetter wrote:
> > On Wed, Oct 14, 2020 at 09:48:43AM +0800, Kever Yang wrote:
> > > Hi Maintainers,
> > > 
> > >      Does this patch ready to merge?
> > Would maybe be good to get some acks from other drivers using this, then
> > Sandy can push to drm-misc-next.
> 
> Thanks for your reply, I can understand more 'acks' will be better, but
> there is no comments object to this patch
> 
> or any 'NAK' common for more then 3 months, maintainers should move to next
> step.

I expect you to poke relevant driver maintainers directly for these acks.
That was the purpose of my mail. All communication going through
maintainers, being exclusively orchestrated by maintainers, just doesn't
scale. So not an option for a big subsystem like drivers/gpu.

Hope that makes it clear.

For merging Sandy has commit rights to drm-misc, so that's not the
problem.

Cheers, Daniel

> 
> 
> Thanks,
> 
> - Kever
> 
> > -Daniel
> > > On 2020/7/7 下午7:25, Sandy Huang wrote:
> > > > don't mask possible_crtcs if remote-point is disabled.
> > > > 
> > > > Signed-off-by: Sandy Huang <hjc@rock-chips.com>
> > > > ---
> > > >    drivers/gpu/drm/drm_of.c | 3 +++
> > > >    1 file changed, 3 insertions(+)
> > > > 
> > > > diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
> > > > index fdb05fbf72a0..565f05f5f11b 100644
> > > > --- a/drivers/gpu/drm/drm_of.c
> > > > +++ b/drivers/gpu/drm/drm_of.c
> > > > @@ -66,6 +66,9 @@ uint32_t drm_of_find_possible_crtcs(struct drm_device *dev,
> > > >    	uint32_t possible_crtcs = 0;
> > > >    	for_each_endpoint_of_node(port, ep) {
> > > > +		if (!of_device_is_available(ep))
> > > > +			continue;
> > > > +
> > > >    		remote_port = of_graph_get_remote_port(ep);
> > > >    		if (!remote_port) {
> > > >    			of_node_put(ep);
> > > Looks good to me.
> > > 
> > > 
> > > Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
> 
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, back to index

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-07 11:25 [PATCH v2] drm/of: Consider the state in which the ep is disabled Sandy Huang
2020-07-07 11:33 ` Heiko Stübner
2020-07-22 19:01 ` Heiko Stübner
2020-08-13  6:31   ` Huang Jiachai
2020-09-02 11:56     ` Huang Jiachai
2020-10-14  1:48 ` Kever Yang
2020-10-15 15:23   ` Daniel Vetter
2020-10-19  3:43     ` Kever Yang
2020-10-20  8:13       ` Daniel Vetter

Linux-Rockchip Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-rockchip/0 linux-rockchip/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-rockchip linux-rockchip/ https://lore.kernel.org/linux-rockchip \
		linux-rockchip@lists.infradead.org
	public-inbox-index linux-rockchip

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-rockchip


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git