From: Arnd Bergmann <arnd@kernel.org>
To: Mark Brown <broonie@kernel.org>, Heiko Stuebner <heiko@sntech.de>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Emil Renner Berthing <kernel@esmil.dk>
Cc: Arnd Bergmann <arnd@arndb.de>,
Alexander Kochetkov <al.kochet@gmail.com>,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
linux-rockchip@lists.infradead.org,
Jon Lin <jon.lin@rock-chips.com>,
clang-built-linux@googlegroups.com,
Vincent Pelletier <plr.vincent@gmail.com>,
Johan Jonker <jbx6244@gmail.com>,
Chris Ruehl <chris.ruehl@gtsys.com.hk>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH] spi: rockchip: avoid objtool warning
Date: Thu, 25 Feb 2021 13:55:34 +0100 [thread overview]
Message-ID: <20210225125541.1808719-1-arnd@kernel.org> (raw)
From: Arnd Bergmann <arnd@arndb.de>
Building this file with clang leads to a an unreachable code path
causing a warning from objtool:
drivers/spi/spi-rockchip.o: warning: objtool: rockchip_spi_transfer_one()+0x2e0: sibling call from callable instruction with modified stack frame
Use BUG() instead of unreachable() to avoid the undefined behavior
if it does happen.
Fixes: 65498c6ae241 ("spi: rockchip: support 4bit words")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/spi/spi-rockchip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c
index 936ef54e0903..972beac1169a 100644
--- a/drivers/spi/spi-rockchip.c
+++ b/drivers/spi/spi-rockchip.c
@@ -521,7 +521,7 @@ static void rockchip_spi_config(struct rockchip_spi *rs,
* ctlr->bits_per_word_mask, so this shouldn't
* happen
*/
- unreachable();
+ BUG();
}
if (use_dma) {
--
2.29.2
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next reply other threads:[~2021-02-25 12:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 12:55 Arnd Bergmann [this message]
2021-02-25 14:09 ` [PATCH] spi: rockchip: avoid objtool warning Emil Renner Berthing
2021-02-25 21:16 ` Nick Desaulniers
2021-02-25 21:19 ` Heiko Stübner
2021-02-26 8:15 ` Pratyush Yadav
2021-02-26 9:49 ` Arnd Bergmann
2021-02-26 11:04 ` Pratyush Yadav
2021-02-26 11:15 ` Arnd Bergmann
2021-03-01 23:37 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210225125541.1808719-1-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=al.kochet@gmail.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=chris.ruehl@gtsys.com.hk \
--cc=clang-built-linux@googlegroups.com \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=jon.lin@rock-chips.com \
--cc=kernel@esmil.dk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=plr.vincent@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).