From: andreas@rammhold.de
To: Punit Agrawal <punitagrawal@gmail.com>
Cc: "Andreas Rammhold" <andreas@rammhold.de>,
"Jakub Kicinski" <kuba@kernel.org>,
"Heiko Stübner" <heiko@sntech.de>,
netdev@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, davem@davemloft.net,
peppe.cavallaro@st.com, alexandre.torgue@foss.st.com,
"Michael Riesch" <michael.riesch@wolfvision.net>
Subject: Re: [PATCH] net: stmmac: dwmac-rk: Fix ethernet on rk3399 based devices
Date: Tue, 5 Oct 2021 11:08:56 +0200 [thread overview]
Message-ID: <20211005090856.ccuccgbjejs5g7gd@wrt> (raw)
In-Reply-To: <87h7dx2dvv.fsf@stealth>
On 21:06 04.10.21, Punit Agrawal wrote:
> Andreas Rammhold <andreas@rammhold.de> writes:
>
> > On 17:20 02.10.21, Jakub Kicinski wrote:
> >> On Sat, 2 Oct 2021 23:33:03 +0200 Andreas Rammhold wrote:
> >> > On 16:02 01.10.21, Jakub Kicinski wrote:
> >> > > On Wed, 29 Sep 2021 23:02:35 +0200 Heiko Stübner wrote:
> >> > > > On a rk3399-puma which has the described issue,
> >> > > > Tested-by: Heiko Stuebner <heiko@sntech.de>
> >> > >
> >> > > Applied, thanks!
> >> >
> >> > This also fixed the issue on a RockPi4.
> >> >
> >> > Will any of you submit this to the stable kernels (as this broke within
> >> > 3.13 for me) or shall I do that?
> >>
> >> I won't. The patch should be in Linus's tree in around 1 week - at which
> >> point anyone can request the backport.
> >>
> >> That said, as you probably know, 4.4 is the oldest active stable branch,
> >> the ship has sailed for anything 3.x.
> >
> > I am sorry. I meant 5.13.
>
> AFAICT, 2d26f6e39afb ("net: stmmac: dwmac-rk: fix unbalanced
> pm_runtime_enable warnings") is not in 5.13 stable.
>
> Either you're not using the stable kernel or there's another issue
> breaking things on the RockPi4.
I was using the 5.13 branch, somewhere after 5.13.12 the network started
to fail on bootup. Due to the nature of the system I don't have
persistent logs on it. When I next looked at the system (and updated to
5.14.x) the issue still occured until I applied this patch on to 5.14.8.
Might have been the same use-facing issue but different bugs?
I can try to narrow the issue down further. It'll probably take a few
evenings to test this out.
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
prev parent reply other threads:[~2021-10-05 9:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 13:50 [PATCH] net: stmmac: dwmac-rk: Fix ethernet on rk3399 based devices Punit Agrawal
2021-09-29 21:02 ` Heiko Stübner
2021-10-01 23:02 ` Jakub Kicinski
2021-10-02 21:33 ` Andreas Rammhold
2021-10-03 0:20 ` Jakub Kicinski
2021-10-03 0:41 ` Andreas Rammhold
2021-10-03 9:15 ` Heiko Stübner
2021-10-04 12:06 ` Punit Agrawal
2021-10-05 9:08 ` andreas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211005090856.ccuccgbjejs5g7gd@wrt \
--to=andreas@rammhold.de \
--cc=alexandre.torgue@foss.st.com \
--cc=davem@davemloft.net \
--cc=heiko@sntech.de \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=michael.riesch@wolfvision.net \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=punitagrawal@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).