From: Sascha Hauer <s.hauer@pengutronix.de>
To: dri-devel@lists.freedesktop.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
kernel@pengutronix.de, "Andy Yan" <andy.yan@rock-chips.com>,
"Benjamin Gaignard" <benjamin.gaignard@collabora.com>,
"Michael Riesch" <michael.riesch@wolfvision.net>,
"Sandy Huang" <hjc@rock-chips.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Peter Geis" <pgwipeout@gmail.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>
Subject: [PATCH 01/18] drm/rockchip: dw_hdmi: Do not leave clock enabled in error case
Date: Wed, 8 Dec 2021 16:12:13 +0100 [thread overview]
Message-ID: <20211208151230.3695378-2-s.hauer@pengutronix.de> (raw)
In-Reply-To: <20211208151230.3695378-1-s.hauer@pengutronix.de>
The driver returns an error when devm_phy_optional_get() fails leaving
the previously enabled clock turned on. Change order and enable the
clock only after the phy has been acquired.
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
index 830bdd5e9b7ce..8677c82716784 100644
--- a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
+++ b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c
@@ -529,13 +529,6 @@ static int dw_hdmi_rockchip_bind(struct device *dev, struct device *master,
return ret;
}
- ret = clk_prepare_enable(hdmi->vpll_clk);
- if (ret) {
- DRM_DEV_ERROR(hdmi->dev, "Failed to enable HDMI vpll: %d\n",
- ret);
- return ret;
- }
-
hdmi->phy = devm_phy_optional_get(dev, "hdmi");
if (IS_ERR(hdmi->phy)) {
ret = PTR_ERR(hdmi->phy);
@@ -544,6 +537,13 @@ static int dw_hdmi_rockchip_bind(struct device *dev, struct device *master,
return ret;
}
+ ret = clk_prepare_enable(hdmi->vpll_clk);
+ if (ret) {
+ DRM_DEV_ERROR(hdmi->dev, "Failed to enable HDMI vpll: %d\n",
+ ret);
+ return ret;
+ }
+
drm_encoder_helper_add(encoder, &dw_hdmi_rockchip_encoder_helper_funcs);
drm_simple_encoder_init(drm, encoder, DRM_MODE_ENCODER_TMDS);
--
2.30.2
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2021-12-08 15:20 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 15:12 [PATCH v2 00/18] drm/rockchip: RK356x VOP2 support Sascha Hauer
2021-12-08 15:12 ` Sascha Hauer [this message]
2021-12-08 15:12 ` [PATCH 02/18] drm/rockchip: dw_hdmi: rename vpll clock to reference clock Sascha Hauer
2021-12-08 15:12 ` [PATCH 03/18] drm/rockchip: dw_hdmi: add rk3568 support Sascha Hauer
2021-12-08 15:12 ` [PATCH 04/18] drm/rockchip: dw_hdmi: add regulator support Sascha Hauer
2021-12-08 15:12 ` [PATCH 05/18] dt-bindings: display: rockchip: dw-hdmi: Add compatible for rk3568 HDMI Sascha Hauer
2021-12-08 15:12 ` [PATCH 06/18] dt-bindings: display: rockchip: dw-hdmi: Make unwedge pinctrl optional Sascha Hauer
2021-12-15 16:27 ` Rob Herring
2021-12-08 15:12 ` [PATCH 07/18] dt-bindings: display: rockchip: dw-hdmi: Allow "ref" as clock name Sascha Hauer
2021-12-12 22:09 ` Heiko Stuebner
2021-12-13 11:08 ` Sascha Hauer
2021-12-08 15:12 ` [PATCH 08/18] dt-bindings: display: rockchip: dw-hdmi: Add regulator support Sascha Hauer
2021-12-08 16:35 ` Robin Murphy
2021-12-08 15:12 ` [PATCH 09/18] arm64: dts: rockchip: rk3399: reorder hmdi clocks Sascha Hauer
2021-12-08 15:12 ` [PATCH 10/18] dt-bindings: display: rockchip: Add binding for VOP2 Sascha Hauer
2021-12-15 16:38 ` Rob Herring
2021-12-08 15:12 ` [PATCH 11/18] arm64: dts: rockchip: rk356x: Add VOP2 nodes Sascha Hauer
2021-12-08 15:12 ` [PATCH 12/18] arm64: dts: rockchip: rk356x: Add HDMI nodes Sascha Hauer
2021-12-08 15:12 ` [PATCH 13/18] arm64: dts: rockchip: rk3568-evb: Enable VOP2 and hdmi Sascha Hauer
2021-12-08 17:30 ` Johan Jonker
2021-12-08 15:12 ` [PATCH 14/18] arm64: dts: rockchip: enable vop2 and hdmi tx on quartz64a Sascha Hauer
2021-12-08 15:12 ` [PATCH 15/18] drm/encoder: Add of_graph port to struct drm_encoder Sascha Hauer
2021-12-08 15:12 ` [PATCH 16/18] drm/rockchip: Make VOP driver optional Sascha Hauer
2021-12-08 15:12 ` [PATCH 17/18] drm: rockchip: Add VOP2 driver Sascha Hauer
2021-12-08 16:59 ` Johan Jonker
2021-12-10 8:55 ` Sascha Hauer
2021-12-08 21:50 ` kernel test robot
2021-12-09 0:49 ` kernel test robot
2021-12-08 15:12 ` [PATCH 18/18] [HACK, RFC] clk: rk3568: do not divide dclk_vop0 Sascha Hauer
2021-12-08 16:51 ` Heiko Stübner
2021-12-10 8:51 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211208151230.3695378-2-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=andy.yan@rock-chips.com \
--cc=benjamin.gaignard@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=michael.riesch@wolfvision.net \
--cc=pgwipeout@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).