From: "jay.xu@rock-chips.com" <jay.xu@rock-chips.com>
To: linus.walleij <linus.walleij@linaro.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>
Cc: "Heiko Stübner" <heiko@sntech.de>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"robert.moore" <robert.moore@intel.com>, robh <robh@kernel.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
lenb <lenb@kernel.org>, rafael <rafael@kernel.org>
Subject: Re: Re: [PATCH 11/20] gpio/rockchip: add of_node for gpiochip
Date: Sat, 8 Oct 2022 14:19:28 +0800 [thread overview]
Message-ID: <2022100814192810242455@rock-chips.com> (raw)
In-Reply-To: CACRpkdbA_h4m0cY98=0C2fCbTYEtowFRm9RF=tv=XSgjKxjcAQ@mail.gmail.com
Hi walleij
Thanks for revewing, i have got your reivews, and will update after heiko's review
to avoid too much patchset vision.
the gc->of_node is a fix for my patch serial, without this the gpiochip will fail to register.
BR
--------------
jay.xu@rock-chips.com
>On Tue, Oct 4, 2022 at 10:30 AM Andy Shevchenko
><andriy.shevchenko@linux.intel.com> wrote:
>> On Tue, Oct 04, 2022 at 09:14:38AM +0200, Linus Walleij wrote:
>> > On Tue, Sep 20, 2022 at 12:31 PM Jianqun Xu <jay.xu@rock-chips.com> wrote:
>> > > The Rockchip GPIO driver will probe before pinctrl and has no parent dt
>> > > node, lack of the of_node will cause the driver probe failure.
>> > >
>> > > Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
>> >
>> > > +#ifdef CONFIG_OF_GPIO
>> > > + gc->of_node = of_node_get(bank->dev->of_node);
>> > > +#endif
>> >
>> > Any introduction of of_node_get() needs to be balanced with a
>> > corresponding of_node_put().
>>
>> No, this code should not have been existed in the first place. We don't allow
>> anymore any of of_node usage in the GPIO drivers. There is an fwnode and parent
>> and logic to retrieve fwnode from parent in the GPIO library for the most of
>> the cases.
>
>Hm yeah given that the series want to introduce ACPI as well it makes
>a lot of sense.
>
>Yours,
>Linus Walleij
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2022-10-08 6:20 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 10:30 [PATCH 00/20] Rockchip pinctrl/GPIO support ACPI Jianqun Xu
2022-09-20 10:30 ` [PATCH 01/20] ACPI: utils: Add acpi_dev_uid_to_integer() helper to get _UID as integer Jianqun Xu
2022-09-20 10:30 ` [PATCH 02/20] pinctrl/rockchip: populate GPIO platform early Jianqun Xu
2022-09-20 10:30 ` [PATCH 03/20] pinctrl/rockchip: use fwnode instead of of_node Jianqun Xu
2022-09-20 10:30 ` [PATCH 04/20] pinctrl/rockchip: switch to use device_get_match_data Jianqun Xu
2022-10-04 7:13 ` Linus Walleij
2022-09-20 10:30 ` [PATCH 05/20] pinctrl/rockchip: of_populate_platform for gpio only for of node Jianqun Xu
2022-09-20 10:30 ` [PATCH 06/20] pinctrl/rockchip: parse dt only if the fwnode is " Jianqun Xu
2022-09-20 10:30 ` [PATCH 07/20] pinctrl/rockchip: print a message if driver probed successfully Jianqun Xu
2022-09-20 10:30 ` [PATCH 08/20] gpiolib: make gpiochip_find_by_name to be common function Jianqun Xu
2022-09-20 10:30 ` [PATCH 09/20] gpio/rockchip: drop 'bank->name' from the driver Jianqun Xu
2022-09-20 10:30 ` [PATCH 10/20] gpio/rockchip: revert deferred output settings on probe Jianqun Xu
2022-09-20 10:30 ` [PATCH 11/20] gpio/rockchip: add of_node for gpiochip Jianqun Xu
2022-10-04 7:14 ` Linus Walleij
2022-10-04 8:30 ` Andy Shevchenko
2022-10-04 9:06 ` Linus Walleij
2022-10-08 6:19 ` jay.xu [this message]
2022-10-08 18:21 ` Andy Shevchenko
2022-09-20 10:31 ` [PATCH 12/20] gpio/rockchip: add return check for clock rate set Jianqun Xu
2022-09-30 9:17 ` Bartosz Golaszewski
2022-09-30 9:28 ` Bartosz Golaszewski
2022-09-20 10:31 ` [PATCH 13/20] gpio/rockchip: disable and put clocks when remove Jianqun Xu
2022-09-30 9:23 ` Bartosz Golaszewski
2022-09-20 10:31 ` [PATCH 14/20] gpio/rockchip: switch to use irq_domain_create_linear Jianqun Xu
2022-09-20 10:31 ` [PATCH 15/20] gpio/rockchip: disable and put clocks when gpiolib register failed Jianqun Xu
2022-10-04 7:16 ` Linus Walleij
2022-10-04 7:16 ` Linus Walleij
2022-09-20 10:31 ` [PATCH 16/20] gpio/rockchip: try to get gpio id from uid when ACPI enabled Jianqun Xu
2022-09-20 10:31 ` [PATCH 17/20] gpio/rockchip: print device with fwnode name when probe successful Jianqun Xu
2022-09-30 9:21 ` Bartosz Golaszewski
2022-09-20 10:31 ` [PATCH 18/20] gpio/rockchip: make use of device property Jianqun Xu
2022-09-20 10:31 ` [PATCH 19/20] gpio/rockchip: make GPIO module work well under ACPI enabled Jianqun Xu
2022-09-20 10:31 ` [PATCH 20/20] pinctrl/rockchip: find existed gpiochip by gpio label Jianqun Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2022100814192810242455@rock-chips.com \
--to=jay.xu@rock-chips.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=heiko@sntech.de \
--cc=lenb@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).