From: "Ondřej Jirman" <megi@xff.cz>
To: Chukun Pan <amadeus@jmu.edu.cn>
Cc: aholmes@omnom.net, devicetree@vger.kernel.org,
ezequiel@vanguardiasur.com.ar, frank-w@public-files.de,
frattaroli.nicolas@gmail.com, heiko@sntech.de,
krzysztof.kozlowski+dt@linaro.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
macromorgan@hotmail.com, mark.kettenis@xs4all.nl,
michael.riesch@wolfvision.net, pgwipeout@gmail.com,
robh+dt@kernel.org, robin.murphy@arm.com, s.hauer@pengutronix.de,
yifeng.zhao@rock-chips.com
Subject: Re: [PATCH 1/1] arm64: dts: rockchip: rk356x: Fix PCIe register and range mappings
Date: Mon, 5 Dec 2022 19:15:19 +0100 [thread overview]
Message-ID: <20221205181519.7e5diejvhiynqmv5@core> (raw)
In-Reply-To: <20221205162322.149967-1-amadeus@jmu.edu.cn>
On Tue, Dec 06, 2022 at 12:23:22AM +0800, Chukun Pan wrote:
> > The register and range mappings for the PCIe controller in Rockchip's
> > RK356x SoCs are incorrect. Replace them with corrected values from the
> > vendor BSP sources, updated to match current DT schema.
>
> Hi, Andrew
>
> This patch broken pcie3x2 on my board.
That's because 32bit mapping for pcie3x2 config should start at 0xf0000000 and
the patch declares it incorrectly at 0xf2000000.
https://megous.com/dl/tmp/6d1a04195112b1e0.png
> And the wireless card on pcie2x1 is still not working.
> [ 0.405341] pcieport 0000:00:00.0: of_irq_parse_pci: failed with rc=-22
> [ 0.670522] rockchip-dw-pcie 3c0800000.pcie: can't request region for resource [mem 0xf2000000-0xf2ffffff]
> [ 0.671527] rockchip-dw-pcie: probe of 3c0800000.pcie failed with error -16
> [ 7.354521] pci 0000:00:00.0: of_irq_parse_pci: failed with rc=-22
> [ 7.355116] mt7921e 0000:01:00.0: enabling device (0000 -> 0002)
> [ 7.355812] mt7921e: probe of 0000:01:00.0 failed with error -28
That's ENOSPC. Who knows where it's comming from. Something for you to debug. ;)
regards,
o.
>
> --
> Thanks,
> Chukun
>
> --
> 2.25.1
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
prev parent reply other threads:[~2022-12-05 18:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-12 11:41 [PATCH 0/1] arm64: dts: rockchip: rk356x: Fix PCIe register and range mappings Andrew Powers-Holmes
2022-11-12 11:41 ` [PATCH 1/1] " Andrew Powers-Holmes
2022-12-05 16:23 ` Chukun Pan
2022-12-05 18:15 ` Ondřej Jirman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221205181519.7e5diejvhiynqmv5@core \
--to=megi@xff.cz \
--cc=aholmes@omnom.net \
--cc=amadeus@jmu.edu.cn \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=frank-w@public-files.de \
--cc=frattaroli.nicolas@gmail.com \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=macromorgan@hotmail.com \
--cc=mark.kettenis@xs4all.nl \
--cc=michael.riesch@wolfvision.net \
--cc=pgwipeout@gmail.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=s.hauer@pengutronix.de \
--cc=yifeng.zhao@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).