From: Boris Brezillon <boris.brezillon@collabora.com>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Heiko Stuebner <heiko@sntech.de>,
linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@collabora.com
Subject: Re: [PATCH v1 3/4] arm64: dts: rockchip: rk3588-rock5b: Enable GPU
Date: Mon, 25 Mar 2024 18:01:17 +0100 [thread overview]
Message-ID: <20240325180117.39d72749@collabora.com> (raw)
In-Reply-To: <a6uu7b3y7d4nirxbplc5cj4oeuyblx2grpvvldeovofhx3tnqc@dlse3vixhpws>
On Mon, 25 Mar 2024 16:58:47 +0100
Sebastian Reichel <sebastian.reichel@collabora.com> wrote:
> Hi,
>
> On Mon, Mar 25, 2024 at 04:44:41PM +0100, Boris Brezillon wrote:
> > On Mon, 25 Mar 2024 16:37:20 +0100
> > Sebastian Reichel <sebastian.reichel@collabora.com> wrote:
> >
> > > From: Boris Brezillon <boris.brezillon@collabora.com>
> > >
> > > Enable the Mali GPU in the Rock 5B.
> > >
> > > Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
> >
> > I don't remember writing this patch ;-), maybe I screwed authorship at
> > some point, dunno.
>
> mh, I cherry-picked the DT patches from your branch before
> cleaning them up.
Yep, I probably wrote this patch and asked someone else to test. I
couldn't find any traces of this patch where I'm not flagged as the
author in any of my local branches.
>
> > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> > > ---
> > > arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 6 ++++++
> > > 1 file changed, 6 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> > > index 1fe8b2a0ed75..096ee7a98b89 100644
> > > --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> > > +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> > > @@ -180,6 +180,11 @@ &cpu_l3 {
> > > cpu-supply = <&vdd_cpu_lit_s0>;
> > > };
> > >
> > > +&gpu {
> > > + mali-supply = <&vdd_gpu_s0>;
> > > + status = "okay";
> > > +};
> > > +
> > > &i2c0 {
> > > pinctrl-names = "default";
> > > pinctrl-0 = <&i2c0m2_xfer>;
> > > @@ -470,6 +475,7 @@ rk806_dvs3_null: dvs3-null-pins {
> > >
> > > regulators {
> > > vdd_gpu_s0: vdd_gpu_mem_s0: dcdc-reg1 {
> > > + regulator-always-on;
> >
> > Hm, should we mention why the regulator is always on here?
>
> In case of the EVB1 it's needed because the generic coupler driver
> cannot handle regulators that are not always on.
Ah, okay. I thought I added that for a different reason.
> I'm not sure why
> it was added for the Rock 5B. I will check if it works without that
> flag.
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2024-03-25 17:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 15:37 [PATCH v1 0/4] RK3588 GPU support Sebastian Reichel
2024-03-25 15:37 ` [PATCH v1 1/4] arm64: defconfig: support Mali CSF-based GPUs Sebastian Reichel
2024-03-25 15:37 ` [PATCH v1 2/4] arm64: dts: rockchip: rk3588: Add GPU nodes Sebastian Reichel
2024-03-25 15:37 ` [PATCH v1 3/4] arm64: dts: rockchip: rk3588-rock5b: Enable GPU Sebastian Reichel
2024-03-25 15:44 ` Boris Brezillon
2024-03-25 15:58 ` Sebastian Reichel
2024-03-25 17:01 ` Boris Brezillon [this message]
2024-03-25 15:37 ` [PATCH v1 4/4] arm64: dts: rockchip: rk3588-evb1: " Sebastian Reichel
2024-03-25 15:53 ` Boris Brezillon
2024-03-25 16:06 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240325180117.39d72749@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).