From: Helen Koike <helen.koike@collabora.com>
To: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
linux-media@vger.kernel.org
Cc: mchehab@kernel.org, dafna3@gmail.com, tfiga@chromium.org,
hverkuil@xs4all.nl, linux-rockchip@lists.infradead.org,
laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com,
kernel@collabora.com, ezequiel@collabora.com
Subject: Re: [PATCH 1/4] media: staging: rkisp1: fix coding style issues
Date: Tue, 20 Oct 2020 14:13:11 -0300 [thread overview]
Message-ID: <42b40780-f9ca-18fb-161c-e45f8500d161@collabora.com> (raw)
In-Reply-To: <20201019205956.6980-2-dafna.hirschfeld@collabora.com>
Hi Dafna,
On 10/19/20 5:59 PM, Dafna Hirschfeld wrote:
> Fix checkpatch issues:
> Blank lines aren't necessary before a close brace '}'
> Alignment should match open parenthesis
Just a nit, usually, it's one patch per checkpatch error.
With the split:
Acked-by: Helen Koike <helen.koike@collabora.com>
Thanks
Helen
>
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
> ---
> drivers/staging/media/rkisp1/rkisp1-dev.c | 4 ++--
> drivers/staging/media/rkisp1/rkisp1-isp.c | 1 -
> drivers/staging/media/rkisp1/rkisp1-resizer.c | 4 ++--
> 3 files changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/media/rkisp1/rkisp1-dev.c b/drivers/staging/media/rkisp1/rkisp1-dev.c
> index 91584695804b..4f6ae1a01253 100644
> --- a/drivers/staging/media/rkisp1/rkisp1-dev.c
> +++ b/drivers/staging/media/rkisp1/rkisp1-dev.c
> @@ -254,8 +254,8 @@ static int rkisp1_subdev_notifier(struct rkisp1_device *rkisp1)
> struct rkisp1_sensor_async *rk_asd = NULL;
> struct fwnode_handle *ep;
>
> - ep = fwnode_graph_get_endpoint_by_id(dev_fwnode(rkisp1->dev),
> - 0, next_id, FWNODE_GRAPH_ENDPOINT_NEXT);
> + ep = fwnode_graph_get_endpoint_by_id(dev_fwnode(rkisp1->dev), 0, next_id,
> + FWNODE_GRAPH_ENDPOINT_NEXT);
> if (!ep)
> break;
>
> diff --git a/drivers/staging/media/rkisp1/rkisp1-isp.c b/drivers/staging/media/rkisp1/rkisp1-isp.c
> index a9715b0b7264..fb23461d865c 100644
> --- a/drivers/staging/media/rkisp1/rkisp1-isp.c
> +++ b/drivers/staging/media/rkisp1/rkisp1-isp.c
> @@ -1157,5 +1157,4 @@ void rkisp1_isp_isr(struct rkisp1_device *rkisp1)
> */
> rkisp1_params_isr(rkisp1);
> }
> -
> }
> diff --git a/drivers/staging/media/rkisp1/rkisp1-resizer.c b/drivers/staging/media/rkisp1/rkisp1-resizer.c
> index 1687d82e6c68..a9d537c11ecb 100644
> --- a/drivers/staging/media/rkisp1/rkisp1-resizer.c
> +++ b/drivers/staging/media/rkisp1/rkisp1-resizer.c
> @@ -610,8 +610,8 @@ static void rkisp1_rsz_set_sink_fmt(struct rkisp1_resizer *rsz,
> RKISP1_ISP_MIN_WIDTH,
> RKISP1_ISP_MAX_WIDTH);
> sink_fmt->height = clamp_t(u32, format->height,
> - RKISP1_ISP_MIN_HEIGHT,
> - RKISP1_ISP_MAX_HEIGHT);
> + RKISP1_ISP_MIN_HEIGHT,
> + RKISP1_ISP_MAX_HEIGHT);
>
> *format = *sink_fmt;
>
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2020-10-20 17:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 20:59 [PATCH 0/4] media: staging: rkisp1: send cleanups and checkpatch fixes Dafna Hirschfeld
2020-10-19 20:59 ` [PATCH 1/4] media: staging: rkisp1: fix coding style issues Dafna Hirschfeld
2020-10-20 17:13 ` Helen Koike [this message]
2020-10-19 20:59 ` [PATCH 2/4] media: staging: rkisp1: params: remove unnecessary "!!" Dafna Hirschfeld
2020-10-20 17:13 ` Helen Koike
2020-10-19 20:59 ` [PATCH 3/4] media: staging: rkisp1: params: remove unnecessary parentheses Dafna Hirschfeld
2020-10-20 17:13 ` Helen Koike
2020-10-19 20:59 ` [PATCH 4/4] media: staging: rkisp1: params: remove extra 'if' conditions Dafna Hirschfeld
2020-10-20 17:13 ` Helen Koike
2020-10-20 17:21 ` Dafna Hirschfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42b40780-f9ca-18fb-161c-e45f8500d161@collabora.com \
--to=helen.koike@collabora.com \
--cc=dafna.hirschfeld@collabora.com \
--cc=dafna3@gmail.com \
--cc=ezequiel@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=kernel@collabora.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).