Re: [PATCH 09/28] media: platform: samsung: s5p-jpeg: drop of_match_ptr for ID table

From: Andrzej Pietrasiewicz <andrzejtp2010@gmail.com>
To: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
	"Joe Tessler" <jrt@google.com>,
	"Hans Verkuil" <hverkuil-cisco@xs4all.nl>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	"Kevin Hilman" <khilman@baylibre.com>,
	"Jerome Brunet" <jbrunet@baylibre.com>,
	"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Michael Tretter" <m.tretter@pengutronix.de>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Jacopo Mondi" <jacopo+renesas@jmondi.org>,
	"Kieran Bingham" <kieran.bingham+renesas@ideasonboard.com>,
	"Laurent Pinchart" <laurent.pinchart+renesas@ideasonboard.com>,
	"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
	"Rui Miguel Silva" <rmfrfs@gmail.com>,
	"Wenyou Yang" <wenyou.yang@microchip.com>,
	"Bin Liu" <bin.liu@mediatek.com>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"Minghsiu Tsai" <minghsiu.tsai@mediatek.com>,
	"Houlong Wei" <houlong.wei@mediatek.com>,
	"Andrew-CT Chen" <andrew-ct.chen@mediatek.com>,
	"Jacek Anaszewski" <jacek.anaszewski@gmail.com>,
	"Sylwester Nawrocki" <s.nawrocki@samsung.com>,
	"Patrice Chotard" <patrice.chotard@foss.st.com>,
	"Yong Deng" <yong.deng@magewell.com>,
	"Paul Kocialkowski" <paul.kocialkowski@bootlin.com>,
	"Chen-Yu Tsai" <wens@csie.org>,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"Samuel Holland" <samuel@sholland.org>,
	"Lad, Prabhakar" <prabhakar.csengg@gmail.com>,
	"Ezequiel Garcia" <ezequiel@vanguardiasur.com.ar>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Sean Young" <sean@mess.org>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-amlogic@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org,
	linux-sunxi@lists.linux.dev, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 09/28] media: platform: samsung: s5p-jpeg: drop of_match_ptr for ID table
Date: Mon, 13 Mar 2023 18:08:42 +0100	[thread overview]
Message-ID: <66b78cd3-0d0d-cee8-6a93-996ade3a07a9@gmail.com> (raw)
In-Reply-To: <20230312131318.351173-9-krzysztof.kozlowski@linaro.org>

Hi,


W dniu 12.03.2023 o 14:12, Krzysztof Kozlowski pisze:
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it might not be relevant here).  This
> also fixes !CONFIG_OF error:
> 
>    drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c:3124:34: error: ‘samsung_jpeg_match’ defined but not used [-Werror=unused-const-variable=]
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Acked-by: Andrzej Pietrasiewicz <andrzejtp2010@gmail.com>

> ---
>   drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c b/drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c
> index 55814041b8d8..8be8e3596e07 100644
> --- a/drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c
> +++ b/drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c
> @@ -3166,7 +3166,7 @@ static struct platform_driver s5p_jpeg_driver = {
>   	.probe = s5p_jpeg_probe,
>   	.remove = s5p_jpeg_remove,
>   	.driver = {
> -		.of_match_table	= of_match_ptr(samsung_jpeg_match),
> +		.of_match_table	= samsung_jpeg_match,
>   		.name		= S5P_JPEG_M2M_NAME,
>   		.pm		= &s5p_jpeg_pm_ops,
>   	},

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip