* [PATCH v3 0/3] rockchip-pinctrl fixes @ 2020-10-13 6:37 Jianqun Xu 2020-10-13 6:37 ` [PATCH v3 1/3] pinctrl: rockchip: make driver be tristate module Jianqun Xu ` (4 more replies) 0 siblings, 5 replies; 11+ messages in thread From: Jianqun Xu @ 2020-10-13 6:37 UTC (permalink / raw) To: linus.walleij, heiko; +Cc: linux-gpio, Jianqun Xu, linux-kernel, linux-rockchip These patches are required by GKI. Jianqun Xu (3): pinctrl: rockchip: make driver be tristate module pinctrl: rockchip: enable gpio pclk for rockchip_gpio_to_irq pinctrl: rockchip: create irq mapping in gpio_to_irq drivers/pinctrl/Kconfig | 2 +- drivers/pinctrl/pinctrl-rockchip.c | 43 +++++++++++++++++++----------- 2 files changed, 28 insertions(+), 17 deletions(-) -- 2.17.1 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v3 1/3] pinctrl: rockchip: make driver be tristate module 2020-10-13 6:37 [PATCH v3 0/3] rockchip-pinctrl fixes Jianqun Xu @ 2020-10-13 6:37 ` Jianqun Xu 2020-10-14 0:23 ` [PATCH v3 1/3] pinctrl: rockchip: make driver be tristate module【请注意,邮件由linux-rockchip-bounces+kever.yang=rock-chips.com@lists.infradead.org代发】 Kever Yang 2020-10-13 6:37 ` [PATCH v3 2/3] pinctrl: rockchip: enable gpio pclk for rockchip_gpio_to_irq Jianqun Xu ` (3 subsequent siblings) 4 siblings, 1 reply; 11+ messages in thread From: Jianqun Xu @ 2020-10-13 6:37 UTC (permalink / raw) To: linus.walleij, heiko; +Cc: linux-gpio, Jianqun Xu, linux-kernel, linux-rockchip Make pinctrl-rockchip driver to be tristate module, support to build as a module, this is useful for GKI. Reviewed-by: Heiko Stuebner <heiko@sntech.de> Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com> --- drivers/pinctrl/Kconfig | 2 +- drivers/pinctrl/pinctrl-rockchip.c | 13 +++++++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index 815095326e2d..bc9774c1ae8d 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig @@ -207,7 +207,7 @@ config PINCTRL_OXNAS select MFD_SYSCON config PINCTRL_ROCKCHIP - bool + tristate "Rockchip gpio and pinctrl driver" depends on OF select PINMUX select GENERIC_PINCONF diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c index 0401c1da79dd..927d132d6716 100644 --- a/drivers/pinctrl/pinctrl-rockchip.c +++ b/drivers/pinctrl/pinctrl-rockchip.c @@ -16,10 +16,12 @@ */ #include <linux/init.h> +#include <linux/module.h> #include <linux/platform_device.h> #include <linux/io.h> #include <linux/bitops.h> #include <linux/gpio/driver.h> +#include <linux/of_device.h> #include <linux/of_address.h> #include <linux/of_irq.h> #include <linux/pinctrl/machine.h> @@ -4258,3 +4260,14 @@ static int __init rockchip_pinctrl_drv_register(void) return platform_driver_register(&rockchip_pinctrl_driver); } postcore_initcall(rockchip_pinctrl_drv_register); + +static void __exit rockchip_pinctrl_drv_unregister(void) +{ + platform_driver_unregister(&rockchip_pinctrl_driver); +} +module_exit(rockchip_pinctrl_drv_unregister); + +MODULE_DESCRIPTION("ROCKCHIP Pin Controller Driver"); +MODULE_LICENSE("GPL"); +MODULE_ALIAS("platform:pinctrl-rockchip"); +MODULE_DEVICE_TABLE(of, rockchip_pinctrl_dt_match); -- 2.17.1 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v3 1/3] pinctrl: rockchip: make driver be tristate module【请注意,邮件由linux-rockchip-bounces+kever.yang=rock-chips.com@lists.infradead.org代发】 2020-10-13 6:37 ` [PATCH v3 1/3] pinctrl: rockchip: make driver be tristate module Jianqun Xu @ 2020-10-14 0:23 ` Kever Yang 0 siblings, 0 replies; 11+ messages in thread From: Kever Yang @ 2020-10-14 0:23 UTC (permalink / raw) To: Jianqun Xu, linus.walleij, heiko; +Cc: linux-gpio, linux-kernel, linux-rockchip On 2020/10/13 下午2:37, Jianqun Xu wrote: > Make pinctrl-rockchip driver to be tristate module, support to build as > a module, this is useful for GKI. > > Reviewed-by: Heiko Stuebner <heiko@sntech.de> > Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com> > --- > drivers/pinctrl/Kconfig | 2 +- > drivers/pinctrl/pinctrl-rockchip.c | 13 +++++++++++++ > 2 files changed, 14 insertions(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > index 815095326e2d..bc9774c1ae8d 100644 > --- a/drivers/pinctrl/Kconfig > +++ b/drivers/pinctrl/Kconfig > @@ -207,7 +207,7 @@ config PINCTRL_OXNAS > select MFD_SYSCON > > config PINCTRL_ROCKCHIP > - bool > + tristate "Rockchip gpio and pinctrl driver" > depends on OF > select PINMUX > select GENERIC_PINCONF > diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c > index 0401c1da79dd..927d132d6716 100644 > --- a/drivers/pinctrl/pinctrl-rockchip.c > +++ b/drivers/pinctrl/pinctrl-rockchip.c > @@ -16,10 +16,12 @@ > */ > > #include <linux/init.h> > +#include <linux/module.h> > #include <linux/platform_device.h> > #include <linux/io.h> > #include <linux/bitops.h> > #include <linux/gpio/driver.h> > +#include <linux/of_device.h> > #include <linux/of_address.h> > #include <linux/of_irq.h> > #include <linux/pinctrl/machine.h> > @@ -4258,3 +4260,14 @@ static int __init rockchip_pinctrl_drv_register(void) > return platform_driver_register(&rockchip_pinctrl_driver); > } > postcore_initcall(rockchip_pinctrl_drv_register); > + > +static void __exit rockchip_pinctrl_drv_unregister(void) > +{ > + platform_driver_unregister(&rockchip_pinctrl_driver); > +} > +module_exit(rockchip_pinctrl_drv_unregister); > + > +MODULE_DESCRIPTION("ROCKCHIP Pin Controller Driver"); > +MODULE_LICENSE("GPL"); > +MODULE_ALIAS("platform:pinctrl-rockchip"); > +MODULE_DEVICE_TABLE(of, rockchip_pinctrl_dt_match); Looks good to me, Reviewed-by: Kever Yang<kever.yang@rock-chips.com> Thanks, - Kever _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v3 2/3] pinctrl: rockchip: enable gpio pclk for rockchip_gpio_to_irq 2020-10-13 6:37 [PATCH v3 0/3] rockchip-pinctrl fixes Jianqun Xu 2020-10-13 6:37 ` [PATCH v3 1/3] pinctrl: rockchip: make driver be tristate module Jianqun Xu @ 2020-10-13 6:37 ` Jianqun Xu 2020-10-14 0:23 ` [PATCH v3 2/3] pinctrl: rockchip: enable gpio pclk for rockchip_gpio_to_irq【请注意,邮件由linux-rockchip-bounces+kever.yang=rock-chips.com@lists.infradead.org代发】 Kever Yang 2020-10-13 6:37 ` [PATCH v3 3/3] pinctrl: rockchip: create irq mapping in gpio_to_irq Jianqun Xu ` (2 subsequent siblings) 4 siblings, 1 reply; 11+ messages in thread From: Jianqun Xu @ 2020-10-13 6:37 UTC (permalink / raw) To: linus.walleij, heiko; +Cc: linux-gpio, Jianqun Xu, linux-kernel, linux-rockchip There need to enable pclk_gpio when do irq_create_mapping, since it will do access to gpio controller. Reviewed-by: Heiko Stuebner <heiko@sntech.de> Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com> --- drivers/pinctrl/pinctrl-rockchip.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c index 927d132d6716..a2f361aa6d05 100644 --- a/drivers/pinctrl/pinctrl-rockchip.c +++ b/drivers/pinctrl/pinctrl-rockchip.c @@ -3157,7 +3157,9 @@ static int rockchip_gpio_to_irq(struct gpio_chip *gc, unsigned offset) if (!bank->domain) return -ENXIO; + clk_enable(bank->clk); virq = irq_create_mapping(bank->domain, offset); + clk_disable(bank->clk); return (virq) ? : -ENXIO; } -- 2.17.1 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v3 2/3] pinctrl: rockchip: enable gpio pclk for rockchip_gpio_to_irq【请注意,邮件由linux-rockchip-bounces+kever.yang=rock-chips.com@lists.infradead.org代发】 2020-10-13 6:37 ` [PATCH v3 2/3] pinctrl: rockchip: enable gpio pclk for rockchip_gpio_to_irq Jianqun Xu @ 2020-10-14 0:23 ` Kever Yang 0 siblings, 0 replies; 11+ messages in thread From: Kever Yang @ 2020-10-14 0:23 UTC (permalink / raw) To: Jianqun Xu, linus.walleij, heiko; +Cc: linux-gpio, linux-kernel, linux-rockchip On 2020/10/13 下午2:37, Jianqun Xu wrote: > There need to enable pclk_gpio when do irq_create_mapping, since it will > do access to gpio controller. > > Reviewed-by: Heiko Stuebner <heiko@sntech.de> > Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com> > --- > drivers/pinctrl/pinctrl-rockchip.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c > index 927d132d6716..a2f361aa6d05 100644 > --- a/drivers/pinctrl/pinctrl-rockchip.c > +++ b/drivers/pinctrl/pinctrl-rockchip.c > @@ -3157,7 +3157,9 @@ static int rockchip_gpio_to_irq(struct gpio_chip *gc, unsigned offset) > if (!bank->domain) > return -ENXIO; > > + clk_enable(bank->clk); > virq = irq_create_mapping(bank->domain, offset); > + clk_disable(bank->clk); > > return (virq) ? : -ENXIO; > } Looks good to me, Reviewed-by: Kever Yang<kever.yang@rock-chips.com> Thanks, - Kever _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v3 3/3] pinctrl: rockchip: create irq mapping in gpio_to_irq 2020-10-13 6:37 [PATCH v3 0/3] rockchip-pinctrl fixes Jianqun Xu 2020-10-13 6:37 ` [PATCH v3 1/3] pinctrl: rockchip: make driver be tristate module Jianqun Xu 2020-10-13 6:37 ` [PATCH v3 2/3] pinctrl: rockchip: enable gpio pclk for rockchip_gpio_to_irq Jianqun Xu @ 2020-10-13 6:37 ` Jianqun Xu 2020-10-14 0:24 ` [PATCH v3 3/3] pinctrl: rockchip: create irq mapping in gpio_to_irq【请注意,邮件由linux-rockchip-bounces+kever.yang=rock-chips.com@lists.infradead.org代发】 Kever Yang 2020-10-13 8:22 ` [PATCH v3 0/3] rockchip-pinctrl fixes Heiko Stübner 2020-10-28 15:54 ` Linus Walleij 4 siblings, 1 reply; 11+ messages in thread From: Jianqun Xu @ 2020-10-13 6:37 UTC (permalink / raw) To: linus.walleij, heiko; +Cc: linux-gpio, Jianqun Xu, linux-kernel, linux-rockchip Remove totally irq mappings create in probe, the gpio irq mapping will be created when do gpio_to_irq -> rockchip_gpio_to_irq -> irq_create_mapping This patch can speed up system boot on, also abandon many unused irq mappings' create. Reviewed-by: Heiko Stuebner <heiko@sntech.de> Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com> --- drivers/pinctrl/pinctrl-rockchip.c | 28 ++++++++++++---------------- 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c index a2f361aa6d05..70dc03af5699 100644 --- a/drivers/pinctrl/pinctrl-rockchip.c +++ b/drivers/pinctrl/pinctrl-rockchip.c @@ -3198,7 +3198,7 @@ static void rockchip_irq_demux(struct irq_desc *desc) irq = __ffs(pend); pend &= ~BIT(irq); - virq = irq_linear_revmap(bank->domain, irq); + virq = irq_find_mapping(bank->domain, irq); if (!virq) { dev_err(bank->drvdata->dev, "unmapped irq %d\n", irq); @@ -3377,7 +3377,7 @@ static int rockchip_interrupts_register(struct platform_device *pdev, unsigned int clr = IRQ_NOREQUEST | IRQ_NOPROBE | IRQ_NOAUTOEN; struct irq_chip_generic *gc; int ret; - int i, j; + int i; for (i = 0; i < ctrl->nr_banks; ++i, ++bank) { if (!bank->valid) { @@ -3404,7 +3404,7 @@ static int rockchip_interrupts_register(struct platform_device *pdev, ret = irq_alloc_domain_generic_chips(bank->domain, 32, 1, "rockchip_gpio_irq", handle_level_irq, - clr, 0, IRQ_GC_INIT_MASK_CACHE); + clr, 0, 0); if (ret) { dev_err(&pdev->dev, "could not alloc generic chips for bank %s\n", bank->name); @@ -3413,14 +3413,6 @@ static int rockchip_interrupts_register(struct platform_device *pdev, continue; } - /* - * Linux assumes that all interrupts start out disabled/masked. - * Our driver only uses the concept of masked and always keeps - * things enabled, so for us that's all masked and all enabled. - */ - writel_relaxed(0xffffffff, bank->reg_base + GPIO_INTMASK); - writel_relaxed(0xffffffff, bank->reg_base + GPIO_INTEN); - gc = irq_get_domain_generic_chip(bank->domain, 0); gc->reg_base = bank->reg_base; gc->private = bank; @@ -3437,13 +3429,17 @@ static int rockchip_interrupts_register(struct platform_device *pdev, gc->chip_types[0].chip.irq_set_type = rockchip_irq_set_type; gc->wake_enabled = IRQ_MSK(bank->nr_pins); + /* + * Linux assumes that all interrupts start out disabled/masked. + * Our driver only uses the concept of masked and always keeps + * things enabled, so for us that's all masked and all enabled. + */ + writel_relaxed(0xffffffff, bank->reg_base + GPIO_INTMASK); + writel_relaxed(0xffffffff, bank->reg_base + GPIO_INTEN); + gc->mask_cache = 0xffffffff; + irq_set_chained_handler_and_data(bank->irq, rockchip_irq_demux, bank); - - /* map the gpio irqs here, when the clock is still running */ - for (j = 0 ; j < 32 ; j++) - irq_create_mapping(bank->domain, j); - clk_disable(bank->clk); } -- 2.17.1 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v3 3/3] pinctrl: rockchip: create irq mapping in gpio_to_irq【请注意,邮件由linux-rockchip-bounces+kever.yang=rock-chips.com@lists.infradead.org代发】 2020-10-13 6:37 ` [PATCH v3 3/3] pinctrl: rockchip: create irq mapping in gpio_to_irq Jianqun Xu @ 2020-10-14 0:24 ` Kever Yang 0 siblings, 0 replies; 11+ messages in thread From: Kever Yang @ 2020-10-14 0:24 UTC (permalink / raw) To: Jianqun Xu, linus.walleij, heiko; +Cc: linux-gpio, linux-kernel, linux-rockchip On 2020/10/13 下午2:37, Jianqun Xu wrote: > Remove totally irq mappings create in probe, the gpio irq mapping will > be created when do > gpio_to_irq -> > rockchip_gpio_to_irq -> > irq_create_mapping > > This patch can speed up system boot on, also abandon many unused irq > mappings' create. > > Reviewed-by: Heiko Stuebner <heiko@sntech.de> > Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com> > --- > drivers/pinctrl/pinctrl-rockchip.c | 28 ++++++++++++---------------- > 1 file changed, 12 insertions(+), 16 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c > index a2f361aa6d05..70dc03af5699 100644 > --- a/drivers/pinctrl/pinctrl-rockchip.c > +++ b/drivers/pinctrl/pinctrl-rockchip.c > @@ -3198,7 +3198,7 @@ static void rockchip_irq_demux(struct irq_desc *desc) > > irq = __ffs(pend); > pend &= ~BIT(irq); > - virq = irq_linear_revmap(bank->domain, irq); > + virq = irq_find_mapping(bank->domain, irq); > > if (!virq) { > dev_err(bank->drvdata->dev, "unmapped irq %d\n", irq); > @@ -3377,7 +3377,7 @@ static int rockchip_interrupts_register(struct platform_device *pdev, > unsigned int clr = IRQ_NOREQUEST | IRQ_NOPROBE | IRQ_NOAUTOEN; > struct irq_chip_generic *gc; > int ret; > - int i, j; > + int i; > > for (i = 0; i < ctrl->nr_banks; ++i, ++bank) { > if (!bank->valid) { > @@ -3404,7 +3404,7 @@ static int rockchip_interrupts_register(struct platform_device *pdev, > > ret = irq_alloc_domain_generic_chips(bank->domain, 32, 1, > "rockchip_gpio_irq", handle_level_irq, > - clr, 0, IRQ_GC_INIT_MASK_CACHE); > + clr, 0, 0); > if (ret) { > dev_err(&pdev->dev, "could not alloc generic chips for bank %s\n", > bank->name); > @@ -3413,14 +3413,6 @@ static int rockchip_interrupts_register(struct platform_device *pdev, > continue; > } > > - /* > - * Linux assumes that all interrupts start out disabled/masked. > - * Our driver only uses the concept of masked and always keeps > - * things enabled, so for us that's all masked and all enabled. > - */ > - writel_relaxed(0xffffffff, bank->reg_base + GPIO_INTMASK); > - writel_relaxed(0xffffffff, bank->reg_base + GPIO_INTEN); > - > gc = irq_get_domain_generic_chip(bank->domain, 0); > gc->reg_base = bank->reg_base; > gc->private = bank; > @@ -3437,13 +3429,17 @@ static int rockchip_interrupts_register(struct platform_device *pdev, > gc->chip_types[0].chip.irq_set_type = rockchip_irq_set_type; > gc->wake_enabled = IRQ_MSK(bank->nr_pins); > > + /* > + * Linux assumes that all interrupts start out disabled/masked. > + * Our driver only uses the concept of masked and always keeps > + * things enabled, so for us that's all masked and all enabled. > + */ > + writel_relaxed(0xffffffff, bank->reg_base + GPIO_INTMASK); > + writel_relaxed(0xffffffff, bank->reg_base + GPIO_INTEN); > + gc->mask_cache = 0xffffffff; > + > irq_set_chained_handler_and_data(bank->irq, > rockchip_irq_demux, bank); > - > - /* map the gpio irqs here, when the clock is still running */ > - for (j = 0 ; j < 32 ; j++) > - irq_create_mapping(bank->domain, j); > - > clk_disable(bank->clk); > } > Looks good to me, Reviewed-by: Kever Yang<kever.yang@rock-chips.com> Thanks, - Kever _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3 0/3] rockchip-pinctrl fixes 2020-10-13 6:37 [PATCH v3 0/3] rockchip-pinctrl fixes Jianqun Xu ` (2 preceding siblings ...) 2020-10-13 6:37 ` [PATCH v3 3/3] pinctrl: rockchip: create irq mapping in gpio_to_irq Jianqun Xu @ 2020-10-13 8:22 ` Heiko Stübner 2020-10-28 15:55 ` Linus Walleij 2020-10-28 15:54 ` Linus Walleij 4 siblings, 1 reply; 11+ messages in thread From: Heiko Stübner @ 2020-10-13 8:22 UTC (permalink / raw) To: linus.walleij, Jianqun Xu Cc: linux-gpio, Jianqun Xu, linux-kernel, linux-rockchip Hi Jianqun, Am Dienstag, 13. Oktober 2020, 08:37:28 CEST schrieb Jianqun Xu: > These patches are required by GKI. > > Jianqun Xu (3): > pinctrl: rockchip: make driver be tristate module > pinctrl: rockchip: enable gpio pclk for rockchip_gpio_to_irq > pinctrl: rockchip: create irq mapping in gpio_to_irq looks good to go as fixes. What happenend to the "populate platform device for rockchip gpio" patch though - more out of cursiosity. Heiko _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3 0/3] rockchip-pinctrl fixes 2020-10-13 8:22 ` [PATCH v3 0/3] rockchip-pinctrl fixes Heiko Stübner @ 2020-10-28 15:55 ` Linus Walleij 2020-10-28 15:56 ` Linus Walleij 0 siblings, 1 reply; 11+ messages in thread From: Linus Walleij @ 2020-10-28 15:55 UTC (permalink / raw) To: Heiko Stübner Cc: open list:GPIO SUBSYSTEM, Jianqun Xu, linux-kernel, open list:ARM/Rockchip SoC... On Tue, Oct 13, 2020 at 10:22 AM Heiko Stübner <heiko@sntech.de> wrote: > > Jianqun Xu (3): > > pinctrl: rockchip: make driver be tristate module > > pinctrl: rockchip: enable gpio pclk for rockchip_gpio_to_irq > > pinctrl: rockchip: create irq mapping in gpio_to_irq > > looks good to go as fixes. I record that as Acked-by :) Yours, Linus Walleij _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3 0/3] rockchip-pinctrl fixes 2020-10-28 15:55 ` Linus Walleij @ 2020-10-28 15:56 ` Linus Walleij 0 siblings, 0 replies; 11+ messages in thread From: Linus Walleij @ 2020-10-28 15:56 UTC (permalink / raw) To: Heiko Stübner Cc: open list:GPIO SUBSYSTEM, Jianqun Xu, linux-kernel, open list:ARM/Rockchip SoC... On Wed, Oct 28, 2020 at 4:55 PM Linus Walleij <linus.walleij@linaro.org> wrote: > On Tue, Oct 13, 2020 at 10:22 AM Heiko Stübner <heiko@sntech.de> wrote: > > > > Jianqun Xu (3): > > > pinctrl: rockchip: make driver be tristate module > > > pinctrl: rockchip: enable gpio pclk for rockchip_gpio_to_irq > > > pinctrl: rockchip: create irq mapping in gpio_to_irq > > > > looks good to go as fixes. > > I record that as Acked-by :) Aha they are already reviewed-by in the patches. OK then, sorry for the confusion. Yours, Linus Walleij _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3 0/3] rockchip-pinctrl fixes 2020-10-13 6:37 [PATCH v3 0/3] rockchip-pinctrl fixes Jianqun Xu ` (3 preceding siblings ...) 2020-10-13 8:22 ` [PATCH v3 0/3] rockchip-pinctrl fixes Heiko Stübner @ 2020-10-28 15:54 ` Linus Walleij 4 siblings, 0 replies; 11+ messages in thread From: Linus Walleij @ 2020-10-28 15:54 UTC (permalink / raw) To: Jianqun Xu Cc: open list:GPIO SUBSYSTEM, open list:ARM/Rockchip SoC..., Heiko Stübner, linux-kernel On Tue, Oct 13, 2020 at 8:37 AM Jianqun Xu <jay.xu@rock-chips.com> wrote: > These patches are required by GKI. > > Jianqun Xu (3): > pinctrl: rockchip: make driver be tristate module > pinctrl: rockchip: enable gpio pclk for rockchip_gpio_to_irq > pinctrl: rockchip: create irq mapping in gpio_to_irq Patches applied for fixes. Yours, Linus Walleij _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2020-10-28 15:56 UTC | newest] Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-10-13 6:37 [PATCH v3 0/3] rockchip-pinctrl fixes Jianqun Xu 2020-10-13 6:37 ` [PATCH v3 1/3] pinctrl: rockchip: make driver be tristate module Jianqun Xu 2020-10-14 0:23 ` [PATCH v3 1/3] pinctrl: rockchip: make driver be tristate module【请注意,邮件由linux-rockchip-bounces+kever.yang=rock-chips.com@lists.infradead.org代发】 Kever Yang 2020-10-13 6:37 ` [PATCH v3 2/3] pinctrl: rockchip: enable gpio pclk for rockchip_gpio_to_irq Jianqun Xu 2020-10-14 0:23 ` [PATCH v3 2/3] pinctrl: rockchip: enable gpio pclk for rockchip_gpio_to_irq【请注意,邮件由linux-rockchip-bounces+kever.yang=rock-chips.com@lists.infradead.org代发】 Kever Yang 2020-10-13 6:37 ` [PATCH v3 3/3] pinctrl: rockchip: create irq mapping in gpio_to_irq Jianqun Xu 2020-10-14 0:24 ` [PATCH v3 3/3] pinctrl: rockchip: create irq mapping in gpio_to_irq【请注意,邮件由linux-rockchip-bounces+kever.yang=rock-chips.com@lists.infradead.org代发】 Kever Yang 2020-10-13 8:22 ` [PATCH v3 0/3] rockchip-pinctrl fixes Heiko Stübner 2020-10-28 15:55 ` Linus Walleij 2020-10-28 15:56 ` Linus Walleij 2020-10-28 15:54 ` Linus Walleij
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).