From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0755BC433E7 for ; Wed, 14 Oct 2020 20:28:18 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 704E022247 for ; Wed, 14 Oct 2020 20:28:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iZ8LHWh9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 704E022247 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nbpUMvRUfQcHy7nhqdadwa+MHjZ6L1J5wxBBtbkNpSk=; b=iZ8LHWh9ppH8w1GcsUGzPu9rs DfxscYiddk7pS5cxz/jqwjb0CqAnRrrUi5idsvt7+5Ui+d/ZQAU3t88sN9dtA09whr2ugV8K+LueD tPf2k59KUtSjZ1AoqSPOl1SLwW1qzmeaIasOS5zSK6lEoKlfUoOxuIdWR9KsoUD9Jd3fVqDmjrXXM RXMWvpxdJhZQUGqqWiEKUN/N+N3UkyexEgIiS8tWJDMO4te5gziWVseUF94kKj/g4ax2KaeLjSepB zb4eIAEqVGdzJJnn+YI0X9OTpZWxl88v7QX1ZfyDfnZHSFv2tjEkOIQZ9f9CW4OuqTix3b9xMGDI9 7SzdTUuvA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSnNd-0000DV-Ei; Wed, 14 Oct 2020 20:28:13 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSnNW-00007d-QR for linux-rockchip@lists.infradead.org; Wed, 14 Oct 2020 20:28:08 +0000 Received: from [IPv6:2804:14c:483:7f66::1004] (unknown [IPv6:2804:14c:483:7f66::1004]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: koike) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 8745A1F4582F; Wed, 14 Oct 2020 21:27:51 +0100 (BST) Subject: Re: [PATCH 3/6] media: staging: rkisp1: initialize buffer lists only on probe To: Dafna Hirschfeld , linux-media@vger.kernel.org References: <20201002184222.7094-1-dafna.hirschfeld@collabora.com> <20201002184222.7094-4-dafna.hirschfeld@collabora.com> From: Helen Koike Message-ID: <77970c1e-c723-6115-6d61-e19cc8afe42d@collabora.com> Date: Wed, 14 Oct 2020 17:27:46 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.2 MIME-Version: 1.0 In-Reply-To: <20201002184222.7094-4-dafna.hirschfeld@collabora.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201014_162807_003834_495AFF23 X-CRM114-Status: GOOD ( 17.07 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mchehab@kernel.org, dafna3@gmail.com, tfiga@chromium.org, hverkuil@xs4all.nl, linux-rockchip@lists.infradead.org, laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com, kernel@collabora.com, ezequiel@collabora.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On 10/2/20 3:42 PM, Dafna Hirschfeld wrote: > The buffer lists of stats and params entities > are initialized in queue_setup callback with > 'INIT_LIST_HEAD'. It is enough to initialize > the lists only upon registration. > For the stats entity the list is already > initialize upon registration. > > Signed-off-by: Dafna Hirschfeld Acked-by: Helen Koike Thanks Helen > --- > drivers/staging/media/rkisp1/rkisp1-params.c | 4 +--- > drivers/staging/media/rkisp1/rkisp1-stats.c | 4 ---- > 2 files changed, 1 insertion(+), 7 deletions(-) > > diff --git a/drivers/staging/media/rkisp1/rkisp1-params.c b/drivers/staging/media/rkisp1/rkisp1-params.c > index cb9f3332a9a0..aa758f8c2264 100644 > --- a/drivers/staging/media/rkisp1/rkisp1-params.c > +++ b/drivers/staging/media/rkisp1/rkisp1-params.c > @@ -1420,8 +1420,6 @@ static int rkisp1_params_vb2_queue_setup(struct vb2_queue *vq, > unsigned int sizes[], > struct device *alloc_devs[]) > { > - struct rkisp1_params *params = vq->drv_priv; > - > *num_buffers = clamp_t(u32, *num_buffers, > RKISP1_ISP_PARAMS_REQ_BUFS_MIN, > RKISP1_ISP_PARAMS_REQ_BUFS_MAX); > @@ -1430,7 +1428,6 @@ static int rkisp1_params_vb2_queue_setup(struct vb2_queue *vq, > > sizes[0] = sizeof(struct rkisp1_params_cfg); > > - INIT_LIST_HEAD(¶ms->params); > return 0; > } > > @@ -1545,6 +1542,7 @@ int rkisp1_params_register(struct rkisp1_device *rkisp1) > > params->rkisp1 = rkisp1; > mutex_init(&node->vlock); > + INIT_LIST_HEAD(¶ms->params); > spin_lock_init(¶ms->config_lock); > > strscpy(vdev->name, RKISP1_PARAMS_DEV_NAME, sizeof(vdev->name)); > diff --git a/drivers/staging/media/rkisp1/rkisp1-stats.c b/drivers/staging/media/rkisp1/rkisp1-stats.c > index 51c64f75fe29..c58ae52b8a98 100644 > --- a/drivers/staging/media/rkisp1/rkisp1-stats.c > +++ b/drivers/staging/media/rkisp1/rkisp1-stats.c > @@ -94,8 +94,6 @@ static int rkisp1_stats_vb2_queue_setup(struct vb2_queue *vq, > unsigned int sizes[], > struct device *alloc_devs[]) > { > - struct rkisp1_stats *stats = vq->drv_priv; > - > *num_planes = 1; > > *num_buffers = clamp_t(u32, *num_buffers, RKISP1_ISP_STATS_REQ_BUFS_MIN, > @@ -103,8 +101,6 @@ static int rkisp1_stats_vb2_queue_setup(struct vb2_queue *vq, > > sizes[0] = sizeof(struct rkisp1_stat_buffer); > > - INIT_LIST_HEAD(&stats->stat); > - > return 0; > } > > _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip