From: Thomas Zimmermann <tzimmermann@suse.de>
To: Sam Ravnborg <sam@ravnborg.org>,
dri-devel@lists.freedesktop.org, Heiko Stuebner <heiko@sntech.de>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
linux-rockchip@lists.infradead.org, stable@vger.kernel.org,
Sandy Huang <hjc@rock-chips.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 1/2] drm/rockchip: fix build due to undefined drm_gem_cma_vm_ops
Date: Tue, 29 Sep 2020 08:53:06 +0200 [thread overview]
Message-ID: <83650213-3b09-aea0-4485-cd20de1d9548@suse.de> (raw)
In-Reply-To: <20200925215524.2899527-2-sam@ravnborg.org>
[-- Attachment #1.1.1: Type: text/plain, Size: 1765 bytes --]
Hi Sam
Am 25.09.20 um 23:55 schrieb Sam Ravnborg:
> Commit 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs")
> introduced the following build error:
>
> rockchip_drm_gem.c:304:13: error: ‘drm_gem_cma_vm_ops’ undeclared here
> 304 | .vm_ops = &drm_gem_cma_vm_ops,
> | ^~~~~~~~~~~~~~~~~~
> | drm_gem_mmap_obj
>
> Fixed by adding missing include file.
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Didn't you review exactly this change yesterday? Anyway, you should add
Fixes: 0d590af3140d ("drm/rockchip: Convert to drm_gem_object_funcs")
and
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
It might happen that I land my patch first, depending on the urgency of
the issue.
Best regards
Thomas
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Sandy Huang <hjc@rock-chips.com>
> Cc: "Heiko Stübner" <heiko@sntech.de>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-rockchip@lists.infradead.org
> ---
> drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> index bb3578469b03..6da15faf0192 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> @@ -10,6 +10,7 @@
>
> #include <drm/drm.h>
> #include <drm/drm_gem.h>
> +#include <drm/drm_gem_cma_helper.h>
> #include <drm/drm_prime.h>
> #include <drm/drm_vma_manager.h>
>
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 516 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2020-09-29 6:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 21:55 [PATCH v1 0/2] drm/rockchip: fix build + warning Sam Ravnborg
2020-09-25 21:55 ` [PATCH v1 1/2] drm/rockchip: fix build due to undefined drm_gem_cma_vm_ops Sam Ravnborg
2020-09-29 6:53 ` Thomas Zimmermann [this message]
2020-09-29 7:17 ` Sam Ravnborg
2020-09-29 7:47 ` Thomas Zimmermann
2020-09-25 21:55 ` [PATCH v1 2/2] drm/rockchip: fix warning from cdn_dp_resume Sam Ravnborg
2020-09-28 14:42 ` Enric Balletbo i Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83650213-3b09-aea0-4485-cd20de1d9548@suse.de \
--to=tzimmermann@suse.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=enric.balletbo@collabora.com \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=sam@ravnborg.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).