From: Daniel Lezcano <daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: "Mark Rutland" <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Eduardo Valentin"
<edubezval-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"open list:ARM/Rockchip SoC support"
<linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Manivannan Sadhasivam"
<manivannan.sadhasivam-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"moderated list:ARM/Rockchip SoC support"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: Define values for the IPA governor for rock960
Date: Sun, 9 Jun 2019 00:05:15 +0200 [thread overview]
Message-ID: <945577ba-d57a-cdbc-27a3-755e13dade37@linaro.org> (raw)
In-Reply-To: <CACRpkdazSvjt0G58dQOr=cw6mJTptNd3ZmEXduXVh4=01YHNvQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 08/06/2019 00:18, Linus Walleij wrote:
> On Tue, Jun 4, 2019 at 6:58 PM Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
>
>> The intelligent power allocator PID coefficient to be set in sysfs
>> are:
>>
>> k_d: 0
>> k_po: 79
>> k_i: 10
>> k_pu: 50
>
> With all the other interesting parametrization in the device tree
> I kind of wonder why the PID regulator constants defaults are
> not set up from device tree?
>
> Any specific reason?
None I'm aware of. I guess these constants are considered as tweak
values and not hardware related.
> To me it seems like the kind of stuff userpace will invariably just
> get wrong or forget about (somebody just runs a different
> distribution without the extra magic to set sysfs right) unless
> we supply good defaults.
I agree.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2019-06-08 22:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 16:57 [PATCH 1/2] arm64: dts: rockchip: Fix multiple thermal zones conflict in rk3399.dtsi Daniel Lezcano
2019-06-04 16:57 ` [PATCH 2/2] arm64: dts: rockchip: Define values for the IPA governor for rock960 Daniel Lezcano
2019-06-07 22:18 ` Linus Walleij
[not found] ` <CACRpkdazSvjt0G58dQOr=cw6mJTptNd3ZmEXduXVh4=01YHNvQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-06-08 22:05 ` Daniel Lezcano [this message]
2019-06-12 14:55 ` [PATCH 1/2] arm64: dts: rockchip: Fix multiple thermal zones conflict in rk3399.dtsi Daniel Lezcano
2019-06-14 9:35 ` Heiko Stuebner
2019-06-14 10:09 ` Robin Murphy
2019-06-14 13:03 ` Daniel Lezcano
2019-06-14 14:02 ` Robin Murphy
2019-06-14 14:30 ` Daniel Lezcano
2019-06-16 9:31 ` Krzysztof Kozlowski
2019-06-16 17:47 ` Daniel Lezcano
2019-06-24 7:31 ` Daniel Lezcano
2019-06-26 22:26 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=945577ba-d57a-cdbc-27a3-755e13dade37@linaro.org \
--to=daniel.lezcano-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=edubezval-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=manivannan.sadhasivam-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).